Re: [PATCH v2] tests: Refactor building xorriso command for iso9660 tests

2021-12-16 Thread Daniel Kiper
On Fri, Dec 10, 2021 at 10:03:09PM +0100, Thomas Schmitt wrote: > Hi, > > On Fri, 10 Dec 2021 02:41:44 -0600, Glenn Washburn wrote: > > The iso9660 tests test creating isos with different combinations of joliet, > > rockridge, and iso9660 conformance level. Refactor xorriso argument > > generation

Re: [PATCH 3/4] luks2: set up dummy sector size during scan

2021-12-16 Thread Fabian Vogt
Hi, (I *finally* got to this topic again...) Am Sonntag, 8. August 2021, 16:20:12 CET schrieb Patrick Steinhardt: > On Fri, Aug 06, 2021 at 12:51:10PM +0800, Michael Chang via Grub-devel wrote: > [snip] > > diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c > > index 90f82b2d3

Re: [PATCH v3] misc: Allow selective disabling of debug facility names

2021-12-16 Thread Daniel Kiper
On Fri, Dec 10, 2021 at 02:13:52AM -0600, Glenn Washburn wrote: > Sometimes you know only know which debug logging facility names you want to s/only know/only/ > turn off, not necessarily all the ones you want enabled. This patch allows > the debug string to contain facility names in the $debug v

Re: [PATCH v2] Use full btrfs bootloader area

2021-12-16 Thread Daniel Kiper
On Mon, Dec 13, 2021 at 02:25:49PM +0800, Michael Chang via Grub-devel wrote: > Up to now GRUB can only embed to the first 64 KiB before primary > superblock of btrfs, effectively limiting the size that could > consequently pose restrictions to feature enablement like advanced zstd > compression. >

Re: [PATCH 5/6] mm: document grub_mm_init_region

2021-12-16 Thread Daniel Kiper
On Mon, Dec 13, 2021 at 11:20:22PM +1100, Daniel Axtens wrote: > Daniel Kiper writes: > > > On Thu, Nov 25, 2021 at 02:22:49AM +1100, Daniel Axtens wrote: > >> grub_mm_init_region does some things that seem magical, especially > >> around region merging. Make it a bit clearer. > >> > >> Signed-off

Re: [PATCH v5 1/9] luks2: Add debug message to align with luks and geli modules

2021-12-16 Thread Daniel Kiper
On Thu, Dec 09, 2021 at 11:14:50AM -0600, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v5 2/9] cryptodisk: Refactor to discard have_it global

2021-12-16 Thread Daniel Kiper
On Thu, Dec 09, 2021 at 11:14:51AM -0600, Glenn Washburn wrote: > The global "have_it" was never used by the crypto-backends, but was used to > determine if a crypto-backend successfully mounted a cryptodisk with a given > uuid. This is not needed however, because grub_device_iterate() will return

Re: [PATCH v5 3/9] cryptodisk: Return failure in cryptomount when no cryptodisk modules are loaded

2021-12-16 Thread Daniel Kiper
On Thu, Dec 09, 2021 at 11:14:52AM -0600, Glenn Washburn wrote: > This displays an error notifying the user that they'll want to load a > backend module to make cryptomount useful. > > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel __

Re: [PATCH v5 5/9] cryptodisk: Improve cryptomount -u error message

2021-12-16 Thread Daniel Kiper
On Thu, Dec 09, 2021 at 11:14:54AM -0600, Glenn Washburn wrote: > When a cryptmount is specified with a UUID, but no cryptodisk backends find > a disk with that UUID, return a more detailed message giving telling the > user that they might not have a needed cryptobackend module loaded. > > Signed-o

Re: [PATCH v5 4/9] cryptodisk: Improve error messaging in cryptomount invocations

2021-12-16 Thread Daniel Kiper
On Thu, Dec 09, 2021 at 11:14:53AM -0600, Glenn Washburn wrote: > Update such that "cryptomount -u UUID" will not print two error messages > when an invalid passphrase is given and the most relevant error message > will be displayed. > > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper D