Re: [PATCH v3 3/4] cryptodisk: Move global variables into grub_cryptomount_args struct

2021-11-18 Thread Daniel Kiper
On Tue, Oct 12, 2021 at 06:26:28PM -0500, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn > --- > grub-core/disk/cryptodisk.c | 26 +- > grub-core/disk/geli.c | 9 - > grub-core/disk/luks.c | 11 +-- > grub-core/disk/luks2.c | 6 +++

Re: [PATCH v3 4/4] cryptodisk: Remove unneeded found_uuid from cryptomount args

2021-11-18 Thread Daniel Kiper
On Tue, Oct 12, 2021 at 06:26:29PM -0500, Glenn Washburn wrote: > The member found_uuid was never used by the crypto-backends, but was used to Ha! Could you make this patch second in this patch series? Then we could avoid carrying over have_it/found_uuid cruft over succeeding patches. > determine

Re: [RESEND v3 0/3] use confidential computing provisioned secrets for disk decryption

2021-11-18 Thread Daniel Kiper
Hey, Adding Denis, Patrick and Glenn... James, please add them to the loop next time. On Tue, Nov 09, 2021 at 08:53:53AM -0500, James Bottomley wrote: > From: James Bottomley > > v3: make password getter specify prompt requirement. Update for TDX: > Make name more generic and expand size o

Re: [RESEND v3 0/3] use confidential computing provisioned secrets for disk decryption

2021-11-18 Thread James Bottomley
On Thu, 2021-11-18 at 15:49 +0100, Daniel Kiper wrote: > Hey, > > Adding Denis, Patrick and Glenn... > > James, please add them to the loop next time. Sure ... is there some way of telling who should be cc'd (I'm not a fan of the kernel get_maintainer.pl but it gives you a list you can trim)? >