Re: [PATCH 0/2] Fix some Coverity resource leak bugs

2021-11-17 Thread Daniel Kiper
On Wed, Nov 10, 2021 at 03:49:27PM -0500, Alec Brown wrote: > There were a couple of commits which made fixes to a few Coverity bugs > addressing resource leaks, but missed some cases where a variable was not > being > freed before a return statement was called. > > The Coverity Bugs being address

Re: [PATCH v3 1/4] cryptodisk: Add infrastructure to pass data from cryptomount to cryptodisk modules

2021-11-17 Thread Daniel Kiper
On Tue, Oct 12, 2021 at 06:26:26PM -0500, Glenn Washburn wrote: > As an example, passing a password as a cryptomount argument is implemented. I am not very happy with that. Splitting this into separate patch or merging with patch #2 probably would not help either. > However, the backends are not

Re: [PATCH v3 2/4] cryptodisk: Refactor password input out of crypto dev modules into cryptodisk

2021-11-17 Thread Daniel Kiper
On Tue, Oct 12, 2021 at 06:26:27PM -0500, Glenn Washburn wrote: > The crypto device modules should only be setting up the crypto devices and > not getting user input. This has the added benefit of simplifying the code > such that three essentially duplicate pieces of code are merged into one. Most