Re: [PATCH] Drop gnulib fix-base64.patch

2021-11-14 Thread Patrick Steinhardt
On Thu, Oct 28, 2021 at 03:22:27PM -0400, Robbie Harwood wrote: > Originally added in 9fbdec2f6b4fa8b549daa4d49134d1fe89d95ef9 and > subsequently modified in 552c9fd08122a3036c724ce96dfe68aa2f75705f, > fix-base64.patch handled two problems we have using gnulib, which are > exerciesd by the base64 m

Re: [PATCH v3 3/4] cryptodisk: Move global variables into grub_cryptomount_args struct

2021-11-14 Thread Patrick Steinhardt
On Tue, Oct 12, 2021 at 06:26:28PM -0500, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn > --- > grub-core/disk/cryptodisk.c | 26 +- > grub-core/disk/geli.c | 9 - > grub-core/disk/luks.c | 11 +-- > grub-core/disk/luks2.c | 6 +++

Re: [PATCH v3 0/4] Refactor/improve cryptomount data passing to crypto modules

2021-11-14 Thread Patrick Steinhardt
On Tue, Oct 12, 2021 at 06:26:25PM -0500, Glenn Washburn wrote: > Updates since v2: > * Add space after function name in function calls > * Add comments for members of struct grub_cryptomount_args > * Correct commit message for patch #4 > > --- > This patch series refactors the way cryptomount pas