Re: [RESEND v3 3/3] efi: Add API for retrieving the EFI secret for cryptodisk

2021-11-10 Thread Dov Murik
On 09/11/2021 15:53, James Bottomley wrote: > This module is designed to provide an efisecret command which > interrogates the EFI configuration table to find the location of the > confidential computing secret and tries to register the secret with > the cryptodisk. > > The secret is stored in

Re: [PATCH 17/19] [not for merge] print more debug info in mm

2021-11-10 Thread Daniel Kiper
CC-ing Glenn... On Tue, Oct 12, 2021 at 06:30:06PM +1100, Daniel Axtens wrote: > This is handy for debugging - I'm including it in case anyone else hacking > on this area finds it helpful. > > Signed-off-by: Daniel Axtens > --- > grub-core/kern/mm.c | 8 > 1 file changed, 8 insertions(+

Re: [PATCH 19/19] RFC: Ignore REGION_CONSECUTIVE

2021-11-10 Thread Daniel Kiper
On Tue, Oct 12, 2021 at 06:30:08PM +1100, Daniel Axtens wrote: > Looking into the region merging stuff, I started to wonder if we actually > want to just try adding as much memory as we can (up to the limit requested), > even if we cannot satisfy the full allocation (i.e. we are not CONSECUTIVE). >

Re: [PATCH 17/19] [not for merge] print more debug info in mm

2021-11-10 Thread Glenn Washburn
On Wed, 10 Nov 2021 14:47:07 +0100 Daniel Kiper wrote: > CC-ing Glenn... > > On Tue, Oct 12, 2021 at 06:30:06PM +1100, Daniel Axtens wrote: > > This is handy for debugging - I'm including it in case anyone else hacking > > on this area finds it helpful. > > > > Signed-off-by: Daniel Axtens > >

[PATCH 1/2] commands/probe: Fix resource leaks

2021-11-10 Thread Alec Brown
Commit 1fc860bb76bb (commands/probe: Fix a resource leak when probing disks), missed other cases where grub_device_close() should be called before a return statement is called. Also found that grub_disk_close() wasn't being called when an error is being returned. To avoid conflict with grub_errno,

[PATCH 0/2] Fix some Coverity resource leak bugs

2021-11-10 Thread Alec Brown
There were a couple of commits which made fixes to a few Coverity bugs addressing resource leaks, but missed some cases where a variable was not being freed before a return statement was called. The Coverity Bugs being addressed are: CID 292443 CID 73804 Alec Brown (2): commands/probe: Fix

[PATCH 2/2] disk/ldm: Fix resource leak

2021-11-10 Thread Alec Brown
Commit 23e39f50ca7a (disk/ldm: Make sure comp data is freed before exiting from make_vg()) fixed several spots in make_vg() where comp data was leaking memory when an error was being handled but missed one. To avoid leaking memory, comp should be freed when an error is being handled after comp has

Re: [PATCH 17/19] [not for merge] print more debug info in mm

2021-11-10 Thread Daniel Kiper
On Wed, Nov 10, 2021 at 01:35:12PM -0600, Glenn Washburn wrote: > On Wed, 10 Nov 2021 14:47:07 +0100 > Daniel Kiper wrote: > > > CC-ing Glenn... > > > > On Tue, Oct 12, 2021 at 06:30:06PM +1100, Daniel Axtens wrote: > > > This is handy for debugging - I'm including it in case anyone else hacking >

Re: [PATCH 07/19] Add memtool module with memory allocation stress-test

2021-11-10 Thread Daniel Kiper
On Tue, Nov 09, 2021 at 01:54:04PM +0100, Daniel Kiper wrote: > On Tue, Oct 12, 2021 at 06:29:56PM +1100, Daniel Axtens wrote: > > When working on memory, it's nice to be able to test your work. > > > > Add a memtest module. When compiled with --enable-mm-debug, it exposes > > 3 commands: > > > >