Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.

2021-10-19 Thread Glenn Washburn
On Mon, 18 Oct 2021 23:04:59 +0200 Michael Schierl wrote: > > Hello, > > > Am 18.10.2021 um 22:29 schrieb Glenn Washburn: > > > I can't say I'm a fan of another special variable, but I'd also be fine > > with that route. Another route might be a (proc) file, eg. "/gsyms", > > which outputs ad

Re: [DEBUG 1/2] misc: Allow selective disabling of debug conditionals

2021-10-19 Thread Michael Schierl
Hello, Am 19.10.2021 um 08:47 schrieb Glenn Washburn: Note, only the first occurance of the conditional is searched for to determine if the conditional is enabled. So simply appending ",-conditional" to the $debug variable may not disable that conditional, if, for example, the conditional is

Re: [PATCH 07/19] Add memtool module with memory allocation stress-test

2021-10-19 Thread Glenn Washburn
On Tue, 12 Oct 2021 18:29:56 +1100 Daniel Axtens wrote: > When working on memory, it's nice to be able to test your work. > > Add a memtest module. When compiled with --enable-mm-debug, it exposes > 3 commands: > > * lsmem - print all allocations and free space in all regions > * lsfreemem -

Re: [SPECIFICATION RFC v3] The firmware and bootloader log specification

2021-10-19 Thread Alec Brown
On Sun, Sep 19, 2021 at 12:53:35AM +0200, Heinrich Schuchardt wrote: > > > Am 18. September 2021 18:04:13 MESZ schrieb Alec Brown > : > >Hi everyone, > > > >I've been working on improving the specification for the firmware and > >bootloader > >log that Daniel Kiper has proposed and take into a

Re: [External] : Re: [SPECIFICATION RFC v3] The firmware and bootloader log specification

2021-10-19 Thread Alec Brown
On Tue, Sep 21, 2021 at 03:40:20PM +, Peter Stuge wrote: > Alec Brown wrote: > > Below is how the layout of these logs would store their data. > > > > bf_log_header: > >+---+ > > u32| version | > > u32| size | > >

Re: [DEBUG 1/2] misc: Allow selective disabling of debug conditionals

2021-10-19 Thread Glenn Washburn
On Tue, 19 Oct 2021 21:10:27 +0200 Michael Schierl wrote: > > Hello, > > > Am 19.10.2021 um 08:47 schrieb Glenn Washburn: > > > > Note, only the first occurance of the conditional is searched for to > > determine if the conditional is enabled. So simply appending ",-conditional" > > to the $de

Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.

2021-10-19 Thread Robbie Harwood
Glenn Washburn writes: > I don't think we need to agree (that is for you to agree that the issue > I'm describing is something to be concerned about). However, like I > said, I think we can both be satisfied by not leaving out the file:line > and to prepend "\n" to "add-symbol-file" so that it wi

Re: [PATCH 12/19] efi: mm: Pass up errors from `add_memory_regions ()`

2021-10-19 Thread Glenn Washburn
On Tue, 12 Oct 2021 18:30:01 +1100 Daniel Axtens wrote: > From: Patrick Steinhardt > > The function `add_memory_regions ()` is currently only called on system > initialization to allocate a fixed amount of pages. As such, it didn't > need to return any errors: in case it failed, we cannot proce

Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.

2021-10-19 Thread Glenn Washburn
On Tue, 19 Oct 2021 17:08:59 -0400 Robbie Harwood wrote: > Glenn Washburn writes: > > > I don't think we need to agree (that is for you to agree that the issue > > I'm describing is something to be concerned about). However, like I > > said, I think we can both be satisfied by not leaving out t

Re: [PATCH 11/19] efi: mm: Extract function to add memory regions

2021-10-19 Thread Glenn Washburn
On Tue, 12 Oct 2021 18:30:00 +1100 Daniel Axtens wrote: > From: Patrick Steinhardt > > In preparation of support for runtime-allocating additional memory > region, this patch extracts the function to retrieve the EFI memory map > and add a subset of it to GRUB's own memory regions. > > Signed-

Re: [PATCH 11/19] efi: mm: Extract function to add memory regions

2021-10-19 Thread Glenn Washburn
On Tue, 12 Oct 2021 18:30:00 +1100 Daniel Axtens wrote: > From: Patrick Steinhardt > > In preparation of support for runtime-allocating additional memory > region, this patch extracts the function to retrieve the EFI memory map > and add a subset of it to GRUB's own memory regions. > > Signed-

Re: [PATCH 2/2] Make a "gdb" dprintf that tells us load addresses.

2021-10-19 Thread Thomas Schmitt
Hi, Robbie Harwood wrote: > dl.c:694: > add-symbol-file ... > dl.c:694: > add-symbol-file ... > dl.c:694: > add-symbol-file ... > > You can't easily copy-paste that into gdb. It needs to be processed to > remove the file:line stuff. How about hiding the "dl.c" lines behin