Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-09-02 Thread Carlos Maiolino
On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote: > CC-ing Javier... > > On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote: > > Hi. > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: > > >Good day list, > > >Le jeu. 26 août 2021 à 15:26, Carlos Maioli

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-09-02 Thread Daniel Kiper
On Thu, Sep 02, 2021 at 10:56:49AM +0200, Carlos Maiolino wrote: > On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote: > > CC-ing Javier... > > > > On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote: > > > Hi. > > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote:

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Daniel Kiper
On Thu, Sep 02, 2021 at 11:08:47AM +0200, Erwan Velu wrote: > Le 01/09/2021 à 18:24, Daniel Kiper a écrit : > > First of all, thanks for your extensive review, I'll fix all this in a V2. Cool! > [...] > > Here you should add Signed-off-by of original author. > > Yeah, I was wondering that but the

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-09-02 Thread Erwan Velu
> > Cool! Thanks a lot! > > I have a question about this. Considering the impact of this issue, does this trigger a point-release of GRUB ? ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] i386-pc: build btrfs zstd support into separate module

2021-09-02 Thread Daniel Kiper
On Thu, Sep 02, 2021 at 01:48:30PM +0800, Michael Chang via Grub-devel wrote: > On Wed, Sep 01, 2021 at 06:38:22PM +0200, Daniel Kiper wrote: > > On Tue, Aug 31, 2021 at 03:12:28PM +0800, Michael Chang via Grub-devel > > wrote: > > > The zstd support in btrfs brings significant size increment to t

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
[...] The ext_cmd change is cool except the linker isn't happy as it cannot find the associated symbols. I asked a question on the IRC channel on this point. I'm not familiar with the dependencies definition in this project, where should I work to get ext_cmd being linked with kern/efi ? I tried in

Re: [PATCH v3 2/6] mm: Allow dynamically requesting additional memory regions

2021-09-02 Thread Daniel Kiper
On Thu, Sep 02, 2021 at 12:48:24AM +1000, Daniel Axtens wrote: > Patrick Steinhardt writes: > > > Currently, all platforms will set up their heap on initialization of the > > platform code. While this works mostly fine, it poses some limitations > > on memory management on us. Most notably, alloca

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Daniel Kiper
On Thu, Sep 02, 2021 at 02:32:48PM +0200, Erwan Velu wrote: > [...] > The ext_cmd change is cool except the linker isn't happy as it cannot find the > associated symbols. > I asked a question on the IRC channel on this point. > I'm not familiar with the dependencies definition in this project, wher

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-09-02 Thread Daniel Kiper
On Thu, Sep 02, 2021 at 01:39:43PM +0200, Erwan Velu wrote: > Cool! Thanks a lot! > > I have a question about this. Considering the impact of this issue, does this > trigger a point-release of GRUB ? Nope... Daniel ___ Grub-devel mailing list Grub

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-09-02 Thread Erwan Velu
[...] > Nope... > > I'm pretty new at contributing to see project but I really wonder what's the rational being this. I mean, 2.06 is very recent, debuting its life cycle and its now known as totally broken on XFS V4 and we have here a very simple patch. How can we prevent users from installing th

Re: [PATCH] fat: Allow out-of-range FAT modification timestamps

2021-09-02 Thread Daniel Kiper
On Wed, Aug 25, 2021 at 08:51:09AM +0200, Heinrich Schuchardt wrote: > On 8/16/21 4:59 PM, Tomasz Kramkowski via Grub-devel wrote: > > 20def1a3c introduced support for file modification times to allow > > comparison of file ages on EFI systems. This patch used > > grub_datetime2unixtime which uses

Re: [PATCH] [MULTIBOOT2 SPEC PATCH V3] multiboot2: Add module load and preference tag

2021-09-02 Thread Daniel Kiper
On Mon, Aug 16, 2021 at 04:35:12PM +0200, Lukasz Hawrylko wrote: > In the cases of users have preferences over Multiboot2 module load > addresses, currently GRUB has no way to achieve it. > > Similar to the relocatable header tag, this new tag allows users to > specify the minimum and maximum load

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-09-02 Thread Daniel Kiper
On Thu, Sep 02, 2021 at 03:05:13PM +0200, Erwan Velu wrote: > [...] > Nope... > > I'm pretty new at contributing to see project but I really wonder what's the > rational being this. > I mean, 2.06 is very recent, debuting its life cycle and its now known as > totally broken on XFS V4 and we ha

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
Le 01/09/2021 à 18:24, Daniel Kiper a écrit : First of all, thanks for your extensive review, I'll fix all this in a V2. [...] Here you should add Signed-off-by of original author. Yeah, I was wondering that but the only email I have was from his previous company. I have no idea what email

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

2021-09-02 Thread Erwan Velu
Le 02/09/2021 à 15:31, Daniel Kiper a écrit : Making a release is a big hassle for the project right now. I hope it will change in the future but it is what it is. I think distros will take this patch immediately. If that helps I can announce here in separate thread when patch lands in the git r

[PATCH v2] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
This patch got written by Arthur Mesh from Juniper (now at Apple Sec team). It was extracted from https://lists.gnu.org/archive/html/grub-devel/2015-09/msg00065.html Since this email, the this patch was : - rebased against the current tree - added a default timeout value - reworked to be controll

Re: [PATCH] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
Le jeu. 2 sept. 2021 à 11:08, Erwan Velu a écrit : > Le 01/09/2021 à 18:24, Daniel Kiper a écrit : > > First of all, thanks for your extensive review, I'll fix all this in a V2. > > [...] Just sent the V2, hope you'll enjoy this version of the patch. I learned many things on some GRUB internals a

Re: [PATCH] i386-pc: build btrfs zstd support into separate module

2021-09-02 Thread Michael Chang via Grub-devel
On Thu, Sep 02, 2021 at 02:12:52PM +0200, Daniel Kiper wrote: > On Thu, Sep 02, 2021 at 01:48:30PM +0800, Michael Chang via Grub-devel wrote: > > On Wed, Sep 01, 2021 at 06:38:22PM +0200, Daniel Kiper wrote: > > > On Tue, Aug 31, 2021 at 03:12:28PM +0800, Michael Chang via Grub-devel > > > wrote:

Re: [PATCH v2] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Michael Chang via Grub-devel
On Thu, Sep 02, 2021 at 06:50:35PM +0200, Erwan Velu wrote: > This patch got written by Arthur Mesh from Juniper (now at Apple Sec team). > It was extracted from > https://lists.gnu.org/archive/html/grub-devel/2015-09/msg00065.html > > Since this email, the this patch was : > - rebased against th

Re: [PATCH v2] kern/efi: Adding efi-watchdog command

2021-09-02 Thread Erwan Velu
Le 03/09/2021 à 04:09, Michael Chang a écrit : [...] I'd suggest to move this efi-watchdog command registration to grub_register_core_commands() in grub-core/kern/corecmd.c as that helps us tracing or knowing available commands in grub's rescue mode. Also it would be great to see the explainatio