[PATCH 1/1] libgcrypt: avoid -Wsign-compare in rijndael do_setkey

2021-08-13 Thread Heinrich Schuchardt
Avoid a warning lib/libgcrypt-grub/cipher/rijndael.c:352:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare] 352 | for (i = 0; i < keylen; i++) | Signed-off-by: Heinrich Schuchardt --- grub-core/lib/libgcrypt/cipher/rij

[PATCH 1/1] libgcrypt: avoid -Wempty-body in rijndael do_setkey

2021-08-13 Thread Heinrich Schuchardt
Avoid a warning lib/libgcrypt-grub/cipher/rijndael.c:229:9: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] 229 | ; | ^ Signed-off-by: Heinrich Schuchardt --- grub-core/lib/libgcrypt/cipher/rijndael.c | 4 +++- 1 file changed, 3 insertions(+

Re: [PATCH 1/1] libgcrypt: avoid -Wsign-compare in rijndael do_setkey

2021-08-13 Thread Daniel Kiper
On Fri, Aug 13, 2021 at 02:47:45PM +0200, Heinrich Schuchardt wrote: > Avoid a warning > > lib/libgcrypt-grub/cipher/rijndael.c:352:21: warning: > comparison of integer expressions of different signedness: > ‘int’ and ‘unsigned int’ [-Wsign-compare] > 352 | for (i = 0; i < keylen; i++) >

Re: [PATCH 1/1] libgcrypt: avoid -Wempty-body in rijndael do_setkey

2021-08-13 Thread Daniel Kiper
On Fri, Aug 13, 2021 at 02:49:10PM +0200, Heinrich Schuchardt wrote: > Avoid a warning > > lib/libgcrypt-grub/cipher/rijndael.c:229:9: > warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] > 229 | ; > | ^ > > Signed-off-by: Heinrich Schuchardt Rev

[PATCH v2 1/1] libgcrypt: avoid -Wsign-compare in rijndael do_setkey

2021-08-13 Thread Heinrich Schuchardt
Avoid a warning lib/libgcrypt-grub/cipher/rijndael.c:352:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare] 352 | for (i = 0; i < keylen; i++) | Signed-off-by: Heinrich Schuchardt Reviewed-by: Daniel Kiper --- v2:

Re: [PATCH 0/2] efi: device tree fix-up

2021-08-13 Thread Heinrich Schuchardt
On 8/2/21 5:18 PM, Daniel Kiper wrote: Hi Heinrich, On Mon, Aug 02, 2021 at 03:00:55PM +0200, Heinrich Schuchardt wrote: Hello Daniel, I sent this series when you were in the middle of getting GRUB-2.06 out. Unfortunately I did not see any feedback yet. Could you, please, share your thoughts.

[PATCH 1/1] autogen.sh: detect python3

2021-08-13 Thread Heinrich Schuchardt
On some current distributions there is no /usr/bin/python. The Python binary is /usr/bin/python3. If a command python3 is available, use it instead. Signed-off-by: Heinrich Schuchardt --- autogen.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh

Re: [PATCH 0/2] efi: device tree fix-up

2021-08-13 Thread Daniel Kiper
On Fri, Aug 13, 2021 at 06:22:49PM +0200, Heinrich Schuchardt wrote: > On 8/2/21 5:18 PM, Daniel Kiper wrote: > > Hi Heinrich, > > > > On Mon, Aug 02, 2021 at 03:00:55PM +0200, Heinrich Schuchardt wrote: > > > Hello Daniel, > > > > > > I sent this series when you were in the middle of getting GRUB-

Re: [PATCH] commands/setpci: honor write mask argument

2021-08-13 Thread Daniel Kiper
On Thu, Aug 12, 2021 at 04:56:13PM +0200, Wouter van Kesteren wrote: > In the case that one passes a write mask with : > the write_mask is obtained from grub_strtoul and then > promptly overwritten by 0x three lines later. > > This appears to have been so since the initial version of setpci

Re: [PATCH 0/2] efi: device tree fix-up

2021-08-13 Thread Heinrich Schuchardt
Am 13. August 2021 22:22:49 MESZ schrieb Daniel Kiper : >On Fri, Aug 13, 2021 at 06:22:49PM +0200, Heinrich Schuchardt wrote: >> On 8/2/21 5:18 PM, Daniel Kiper wrote: >> > Hi Heinrich, >> > >> > On Mon, Aug 02, 2021 at 03:00:55PM +0200, Heinrich Schuchardt wrote: >> > > Hello Daniel, >> > > >> > >