Re: [PATCH 2/2] efi: Print an error if boot to firmware setup is not supported

2021-07-13 Thread Paul Menzel
Dear Javier, Thank you for this patch. Am 06.07.21 um 11:02 schrieb Javier Martinez Canillas: The "fwsetup" command is only registered if the firmware supports booting to the firmware setup UI. But it could be possible that the GRUB config already contains a "fwsetup" entry, because it was ge

Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

2021-07-13 Thread Paul Menzel
Dear Petr, dear Jeff, Am 08.07.21 um 17:55 schrieb Petr Vorel: From: Jeff Mahoney sysfs_partition_path calls udevadm to resolve the sysfs path for a block device. That can be accomplished by stating the device node and using the major/minor to follow the symlinks in /sys/dev/block/. This cut

Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

2021-07-13 Thread Petr Vorel
Hi Paul, > Dear Petr, dear Jeff, > Am 08.07.21 um 17:55 schrieb Petr Vorel: > > From: Jeff Mahoney > > sysfs_partition_path calls udevadm to resolve the sysfs path for > > a block device. That can be accomplished by stating the device node > > and using the major/minor to follow the symlinks i

Re: [PATCH 1/2] osdep: Introduce major.h and use it

2021-07-13 Thread Daniel Kiper
On Thu, Jul 08, 2021 at 05:55:57PM +0200, Petr Vorel wrote: > Signed-off-by: Petr Vorel > --- > grub-core/osdep/devmapper/getroot.c | 7 +-- > grub-core/osdep/devmapper/hostdisk.c | 7 +-- > grub-core/osdep/linux/getroot.c | 7 +-- > grub-core/osdep/unix/getroot.c | 7

Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

2021-07-13 Thread Daniel Kiper
On Thu, Jul 08, 2021 at 05:55:58PM +0200, Petr Vorel wrote: > From: Jeff Mahoney > > sysfs_partition_path calls udevadm to resolve the sysfs path for > a block device. That can be accomplished by stating the device node > and using the major/minor to follow the symlinks in /sys/dev/block/. > > Thi

Re: [PATCH 1/2] osdep: Introduce major.h and use it

2021-07-13 Thread Petr Vorel
> On Thu, Jul 08, 2021 at 05:55:57PM +0200, Petr Vorel wrote: > > Signed-off-by: Petr Vorel > > --- > > grub-core/osdep/devmapper/getroot.c | 7 +-- > > grub-core/osdep/devmapper/hostdisk.c | 7 +-- > > grub-core/osdep/linux/getroot.c | 7 +-- > > grub-core/osdep/unix/getroot

Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

2021-07-13 Thread Petr Vorel
Hi all, > On 7/13/21 1:48 PM, Daniel Kiper wrote: > > On Thu, Jul 08, 2021 at 05:55:58PM +0200, Petr Vorel wrote: > >> From: Jeff Mahoney > >> sysfs_partition_path calls udevadm to resolve the sysfs path for > >> a block device. That can be accomplished by stating the device node > >> and using

Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

2021-07-13 Thread Jeff Mahoney via Grub-devel
On 7/13/21 1:48 PM, Daniel Kiper wrote: > On Thu, Jul 08, 2021 at 05:55:58PM +0200, Petr Vorel wrote: >> From: Jeff Mahoney >> >> sysfs_partition_path calls udevadm to resolve the sysfs path for >> a block device. That can be accomplished by stating the device node >> and using the major/minor to

Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

2021-07-13 Thread Michael Chang via Grub-devel
On Tue, Jul 13, 2021 at 11:25:49AM +0200, Paul Menzel wrote: > Dear Petr, dear Jeff, > > > Am 08.07.21 um 17:55 schrieb Petr Vorel: > > From: Jeff Mahoney > > > > sysfs_partition_path calls udevadm to resolve the sysfs path for > > a block device. That can be accomplished by stating the device

Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

2021-07-13 Thread Michael Chang via Grub-devel
On Tue, Jul 13, 2021 at 12:52:12PM +0200, Petr Vorel wrote: > Hi Paul, > > > Dear Petr, dear Jeff, > > > > Am 08.07.21 um 17:55 schrieb Petr Vorel: > > > From: Jeff Mahoney > > > > sysfs_partition_path calls udevadm to resolve the sysfs path for > > > a block device. That can be accomplished b

Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup

2021-07-13 Thread Petr Vorel
Hi Michael, > On Tue, Jul 13, 2021 at 12:52:12PM +0200, Petr Vorel wrote: > > Hi Paul, > > > Dear Petr, dear Jeff, > > > Am 08.07.21 um 17:55 schrieb Petr Vorel: > > > > From: Jeff Mahoney > > > > sysfs_partition_path calls udevadm to resolve the sysfs path for > > > > a block device. That ca

Re: [PATCH 1/2] osdep: Introduce major.h and use it

2021-07-13 Thread Petr Vorel
Hi Daniel, > > On Thu, Jul 08, 2021 at 05:55:57PM +0200, Petr Vorel wrote: > > > Signed-off-by: Petr Vorel > > > --- > > > grub-core/osdep/devmapper/getroot.c | 7 +-- > > > grub-core/osdep/devmapper/hostdisk.c | 7 +-- > > > grub-core/osdep/linux/getroot.c | 7 +-- > > > gr