Re: [RFC PATCH v2] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread John Paul Adrian Glaubitz
Hi Javier! On 4/26/21 7:18 PM, Daniel Kiper wrote: > (...) > I think this should be: > layout->kernel_size = ALIGN_UP (layout->kernel_size, > GRUB_PE32_FILE_ALIGNMENT); > > Here we care about alignment in the PE file not in the memory. So, > I think we have to use GRUB_PE32_FILE_ALIGNMENT inst

Re: [RFC PATCH v2] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread Javier Martinez Canillas
Hello Adrian, On 4/27/21 9:55 AM, John Paul Adrian Glaubitz wrote: > Hi Javier! > > On 4/26/21 7:18 PM, Daniel Kiper wrote: >> (...) >> I think this should be: >> layout->kernel_size = ALIGN_UP (layout->kernel_size, >> GRUB_PE32_FILE_ALIGNMENT); >> >> Here we care about alignment in the PE fil

[PATCH v3] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread Javier Martinez Canillas
Commit f60ba9e5945 (util/mkimage: Refactor section setup to use a helper) added a helper function to setup PE sections. But it also changed how the raw data offsets were calculated since all the section sizes are aligned. However, for some platforms, i.e ia64-efi and arm64-efi, the kernel image si

Re: [PATCH v3] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread John Paul Adrian Glaubitz
On 4/27/21 12:25 PM, Javier Martinez Canillas wrote: > Commit f60ba9e5945 (util/mkimage: Refactor section setup to use a helper) > added a helper function to setup PE sections. But it also changed how the > raw data offsets were calculated since all the section sizes are aligned. > > However, for

Re: [PATCH v3] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread Javier Martinez Canillas
On 4/27/21 12:48 PM, John Paul Adrian Glaubitz wrote: > On 4/27/21 12:25 PM, Javier Martinez Canillas wrote: [snip] >> } >> #endif >> + >> + if (image_target->id == IMAGE_EFI) >> +layout->kernel_size = ALIGN_UP (layout->kernel_size, >> +G

grub-2:2.06rc1-2 Installation Messages Related to Secure Boot as Displayed under Arch Linux

2021-04-27 Thread HardenedArray via Grub-devel
As a heads up to those working on the Secure Boot aspects of grub, I wanted to provide the grub-2:2.06rc1-2 installation messages being shown to Arch Linux grub users during a 'pacman -Syu' run that happens to pull in the latest grub upgrade. 2/3) upgrading grub [###

Re: [PATCH v3] util/mkimage: Fix wrong PE32+ section sizes for some arches

2021-04-27 Thread Daniel Kiper
On Tue, Apr 27, 2021 at 12:48:29PM +0200, John Paul Adrian Glaubitz wrote: > On 4/27/21 12:25 PM, Javier Martinez Canillas wrote: > > Commit f60ba9e5945 (util/mkimage: Refactor section setup to use a helper) > > added a helper function to setup PE sections. But it also changed how the > > raw data