Re: [PATCH v4 08/13] error: Use %p format code for pointer types

2021-02-27 Thread Daniel Kiper
On Thu, Feb 18, 2021 at 08:47:09PM -0600, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn > --- > grub-core/loader/i386/pc/linux.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/grub-core/loader/i386/pc/linux.c > b/grub-core/loader/i386/pc/linux.c > index 8149

Re: [PATCH v4 10/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit arg in grub_error

2021-02-27 Thread Daniel Kiper
On Thu, Feb 18, 2021 at 08:47:11PM -0600, Glenn Washburn wrote: > The macro ELF_R_TYPE does not change the underlying type. Here its argument > is a 64-bit Elf64_Xword. Make sure the format code matches. > > For the riscv architecture, rel->r_info could be either Elf32_Xword or > Elf64_Xword depend

Re: [PATCH v4 12/13] error: Use format code llu for 64-bit uint bp->blk_prop in grub_error

2021-02-27 Thread Daniel Kiper
On Thu, Feb 18, 2021 at 08:47:13PM -0600, Glenn Washburn wrote: > For some reason PRIuGRUB_UINT64_T is not expanding to llu, but to lu, which > causes the format string check to fail. Use literal and force cast until > this is debugged. I think the problem is that currently BF64_DECODE() uses "1UL

Re: [PATCH v4 00/13] error: Do compile-time format string checking on grub_error

2021-02-27 Thread Daniel Kiper
On Thu, Feb 18, 2021 at 08:47:01PM -0600, Glenn Washburn wrote: > This patch series fixes all compile errors due to format string issues on > grub_error. This was tested against nearly all supported platforms > successfully. This is important because earlier versions of these changes > compiled suc

Re: [PATCH V2] fs/ext2: fix the file not found error when symlink filesize is 60

2021-02-27 Thread Daniel Kiper
On Fri, Jan 08, 2021 at 08:39:47AM +0800, Yi Zhao wrote: > We encountered a file not found error when the symlink filesize is 60: > $ ls -l initrd > lrwxrwxrwx 1 root root 60 Jan 6 16:37 initrd -> > secure-core-image-initramfs-5.10.2-yoctodev-standard.cpio.gz > > When booting, we got the followin

[PATCH] tpm: Don't propagate measurement failures to the verifiers layer

2021-02-27 Thread Javier Martinez Canillas
Currently if an EFI firmware fails to do a TPM measurement for a file, the error will be propagated to the verifiers framework which will prevent it to be opened. This mean that buggy firmwares will lead to the system not booting because files won't be allowed to be loaded. But a failure to do a T

Re: [PATCH] tpm: Don't propagate measurement failures to the verifiers layer

2021-02-27 Thread James Bottomley
On Sun, 2021-02-28 at 00:05 +0100, Javier Martinez Canillas wrote: > Currently if an EFI firmware fails to do a TPM measurement for a > file, the error will be propagated to the verifiers framework which > will prevent it to be opened. > > This mean that buggy firmwares will lead to the system not