Re: [PATCH] disk: Move hardcoded max disk size literal to a GRUB_DISK_MAX_SECTORS in disk.h

2020-11-30 Thread Daniel Kiper
On Fri, Nov 27, 2020 at 02:36:23AM -0600, Glenn Washburn wrote: > There is a hardcoded maximum disk size that can be read or written from, > currently set at 1EiB in grub_disk_adjust_range. Move the literal into a > macro in disk.h, so our assumptions are more visible. This hard coded limit > does

Re: [PATCH] disk: Move hardcoded max disk size literal to a GRUB_DISK_MAX_SECTORS in disk.h

2020-11-30 Thread Glenn Washburn
On Mon, 30 Nov 2020 15:42:14 +0100 Daniel Kiper wrote: > On Fri, Nov 27, 2020 at 02:36:23AM -0600, Glenn Washburn wrote: > > There is a hardcoded maximum disk size that can be read or written > > from, currently set at 1EiB in grub_disk_adjust_range. Move the > > literal into a macro in disk.h, s

[PATCH v2] disk: Move hardcoded max disk size literal to a GRUB_DISK_MAX_SECTORS in disk.h

2020-11-30 Thread Glenn Washburn
There is a hardcoded maximum disk size that can be read or written from, currently set at 1EiB in grub_disk_adjust_range. Move the literal into a macro in disk.h, so our assumptions are more visible. This hard coded limit does not prevent using larger disks, just grub won't read/write past the limi

Re: [PATCH v2 0/2] error: Do compile-time format string checking on grub_error.

2020-11-30 Thread Glenn Washburn
On Mon, 23 Nov 2020 03:31:23 -0600 Glenn Washburn wrote: > On Sat, 7 Nov 2020 23:26:17 -0600 > Glenn Washburn wrote: > > > I've separated this into two patches from the previous one, but > > nothing else has changed (except the commit message). I think at > > least the first patch should be ap