Re: [PATCH v4 08/15] luks2: Split idx into three variables: keyslot_key, digest_key, segment_key.

2020-11-20 Thread Glenn Washburn
On Tue, 17 Nov 2020 14:47:39 +0100 Daniel Kiper wrote: > On Sun, Nov 15, 2020 at 10:48:37AM +0100, Patrick Steinhardt wrote: > > On Fri, Nov 06, 2020 at 10:44:28PM -0600, Glenn Washburn wrote: > > > Introduce new variables keyslot_key, digest_key, and segment_key > > > which represent the integer

Re: [PATCH v4 10/15] luks2: Use more intuitive keyslot key instead of index when naming keyslot.

2020-11-20 Thread Glenn Washburn
On Sun, 15 Nov 2020 10:55:21 +0100 Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:30PM -0600, Glenn Washburn wrote: > > Use the keyslot key value in the keyslot json array rather than the > > index of the keyslot in the json array. This is less confusing for > > the end user. For examp

Re: [PATCH v4 11/15] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt.

2020-11-20 Thread Glenn Washburn
On Sun, 15 Nov 2020 10:59:33 +0100 Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:31PM -0600, Glenn Washburn wrote: > > This should improve readability of code by providing clues as to > > what the value represents. The new macro GRUB_TYPE_BITS(type) > > returns the number of bits allo

Re: [PATCH v4 12/15] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

2020-11-20 Thread Glenn Washburn
On Tue, 17 Nov 2020 15:06:08 +0100 Daniel Kiper wrote: > On Fri, Nov 06, 2020 at 10:44:32PM -0600, Glenn Washburn wrote: > > The total_length field is named confusingly because length usually > > refers to > > total_length? I think by mistake you left original commit message > here. It is confus

Re: [PATCH v4 13/15] cryptodisk: Properly handle non-512 byte sized sectors.

2020-11-20 Thread Glenn Washburn
On Sun, 15 Nov 2020 11:07:27 +0100 Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:33PM -0600, Glenn Washburn wrote: > > By default, dm-crypt internally uses an IV that corresponds to > > 512-byte sectors, even when a larger sector size is specified. What > > this means is that when usi

Re: [PATCH v4 14/15] luks2: Better error handling when setting up the cryptodisk.

2020-11-20 Thread Glenn Washburn
On Sun, 15 Nov 2020 11:13:04 +0100 Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:34PM -0600, Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > > A commit message would help to set the stage for your changes here, > especially so as they're non-trivial. That's reasonable. I

Re: [PATCH v4 14/15] luks2: Better error handling when setting up the cryptodisk.

2020-11-20 Thread Glenn Washburn
On Tue, 17 Nov 2020 15:26:08 +0100 Daniel Kiper wrote: > On Fri, Nov 06, 2020 at 10:44:34PM -0600, Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > > --- > > grub-core/disk/luks2.c | 70 > > +++--- include/grub/misc.h| > > 2 ++ 2 files changed, 6

Re: [PATCH] arm64: Include missing header

2020-11-20 Thread Daniel Kiper
On Mon, Nov 09, 2020 at 11:40:14AM +0100, Javier Martinez Canillas wrote: > This header uses types defined in but does not include it, > which leads to lead compile errors like the following: > > ../include/grub/cpu/linux.h:27:3: error: unknown type name ‘grub_uint32_t’ >27 | grub_uint32_t c

Re: [PATCH v3 06/10] cryptodisk: Properly handle non-512 byte sized sectors.

2020-11-20 Thread Daniel Kiper
On Thu, Nov 19, 2020 at 11:18:34PM -0600, Glenn Washburn wrote: > On Thu, 19 Nov 2020 15:25:33 +0100 > Daniel Kiper wrote: > > > On Fri, Nov 06, 2020 at 01:08:28PM -0600, Glenn Washburn wrote: > > > On Fri, 30 Oct 2020 21:47:14 +0100 > > > Daniel Kiper wrote: > > > > > > > On Mon, Oct 19, 2020 at

[PATCH 2/2] ieee1275/powerpc: enables device mapper discovery

2020-11-20 Thread Diego Domingos
From: Diego Domingos this patch enables the device mapper discovery on ofpath.c. Currently, when we are dealing with a device like /dev/dm-* the ofpath returns null since there is no function implemented to handle this case. This patch implements a function that will look into /sys/block/dm-* de

[PATCH 0/2] ieee1275/powerpc: implement ofpath to enable hint feature for FC and dm devices

2020-11-20 Thread Diego Domingos
The grub-ofpathname and hint feature for ieee1275 are not working since there is no code implemented to get the information needed about fibre channel devices and device mapper. This patch series implements the codes for both groups of devices and with them we can get the --hint-ieee1275 workin

[PATCH 1/2] ieee1275/powerpc: implements fibre channel discovery for ofpathname

2020-11-20 Thread Diego Domingos
From: Diego Domingos grub-ofpathname doesn't work with fibre channel because there is no function currently implemented for it. This patch enables it by prividing a function that looks for the port name, building the entire path for OF devices. --- grub-core/osdep/linux/ofpath.c | 49 +++

Re: [PATCH v4 14/15] luks2: Better error handling when setting up the cryptodisk.

2020-11-20 Thread Daniel Kiper
On Fri, Nov 20, 2020 at 02:44:53AM -0600, Glenn Washburn wrote: > On Tue, 17 Nov 2020 15:26:08 +0100 > Daniel Kiper wrote: > > > On Fri, Nov 06, 2020 at 10:44:34PM -0600, Glenn Washburn wrote: > > > Signed-off-by: Glenn Washburn > > > --- > > > grub-core/disk/luks2.c | 70 > > > +

[ANNOUNCEMENT] GRUB mini-summit - last virtual session Tue Nov 24 15:00 UTC

2020-11-20 Thread Daniel Kiper
Hi, Last GRUB mini-summit session starts on Tue Nov 24 at 15:00 UTC. More you can find here: https://twitter.com/3mdeb_com/status/1329489364775297025 Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-de

Re: [RFC] ieee1275: Avoiding many unnecessary open/close

2020-11-20 Thread Eric Snowberg
> On Nov 16, 2020, at 10:29 AM, diegodo wrote: > > On 2020-09-24 20:58, Eric Snowberg wrote: >>> On Sep 24, 2020, at 11:11 AM, diegodo wrote: >>> Hi, >>> we are facing some performance issues with ieee1275 platform (ppc64le >>> architecture to be more specific) and I would like to suggest a co

Re: [PATCH v3 06/10] cryptodisk: Properly handle non-512 byte sized sectors.

2020-11-20 Thread Glenn Washburn
On Fri, 20 Nov 2020 15:17:25 +0100 Daniel Kiper wrote: > On Thu, Nov 19, 2020 at 11:18:34PM -0600, Glenn Washburn wrote: > > On Thu, 19 Nov 2020 15:25:33 +0100 > > Daniel Kiper wrote: > > > > > On Fri, Nov 06, 2020 at 01:08:28PM -0600, Glenn Washburn wrote: > > > > On Fri, 30 Oct 2020 21:47:14 +

Re: [PATCH v4 14/15] luks2: Better error handling when setting up the cryptodisk.

2020-11-20 Thread Glenn Washburn
On Fri, 20 Nov 2020 21:24:10 +0100 Daniel Kiper wrote: > On Fri, Nov 20, 2020 at 02:44:53AM -0600, Glenn Washburn wrote: > > On Tue, 17 Nov 2020 15:26:08 +0100 > > Daniel Kiper wrote: > > > > > On Fri, Nov 06, 2020 at 10:44:34PM -0600, Glenn Washburn wrote: > > > > Signed-off-by: Glenn Washburn