[ANNOUNCEMENT] GRUB mini-summit - 3rd virtual session Tue Nov 17 15:00 UTC

2020-11-16 Thread Daniel Kiper
Hi, Next GRUB mini-summit session starts on Tue Nov 17 at 15:00 UTC. More you can find here: https://twitter.com/3mdeb_com/status/1327278804100931587 Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-de

Re: Antw: [EXT] [systemd-devel] [SPECIFICATION RFC] The firmware and bootloader log specification

2020-11-16 Thread Rasmus Villemoes via Grub-devel
On 16/11/2020 08.02, Ulrich Windl wrote: Daniel Kiper schrieb am 14.11.2020 um 00:52 in > Nachricht <20201113235242.k6fzlwmwm2xqh...@tomti.i.net-space.pl>: > ... >> The members of struct bf_log_msg: >> ‑ size: total size of bf_log_msg struct, >> ‑ ts_nsec: timestamp expressed in nanosecon

Re: [PATCH v4 03/15] luks2: Rename source disk variabled named 'disk' to 'source' as in luks.c.

2020-11-16 Thread Daniel Kiper
On Sun, Nov 15, 2020 at 10:39:21AM +0100, Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:23PM -0600, Glenn Washburn wrote: > > This makes it more obvious to the reader that the disk referred to is the > > source disk, as opposed to say the disk holding the cryptodisk. > > > > Signed-off-

Re: [PATCH v4 04/15] types: Define GRUB_CHAR_BIT based on compiler macro instead of using literal.

2020-11-16 Thread Daniel Kiper
On Sun, Nov 15, 2020 at 10:42:39AM +0100, Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:24PM -0600, Glenn Washburn wrote: > > Signed-off-by: Glenn Washburn > > --- > > include/grub/types.h | 10 -- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/includ

Re: [PATCH v4 05/15] luks2: Use correct index variable when looping in luks2_get_keyslot.

2020-11-16 Thread Daniel Kiper
On Sun, Nov 15, 2020 at 10:43:17AM +0100, Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:25PM -0600, Glenn Washburn wrote: > > The loop variable j should be used to index the digests and segments json > > array, instead of the variable i, which is the keyslot index. > > > > Signed-off-by

Re: [PATCH v4 01/15] cryptodisk: Rename total_length field in grub_cryptodisk_t to total_sectors.

2020-11-16 Thread Daniel Kiper
On Sun, Nov 15, 2020 at 10:37:23AM +0100, Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:21PM -0600, Glenn Washburn wrote: > > This creates an alignment with grub_disk_t naming of the same field and is > > more intuitive as to how it should be used. > > > > Signed-off-by: Glenn Washburn

Re: [PATCH v4 07/15] luks2: Rename index variable j to i.

2020-11-16 Thread Daniel Kiper
On Sun, Nov 15, 2020 at 10:44:26AM +0100, Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:27PM -0600, Glenn Washburn wrote: > > Looping variable j was named such because the variable name i was taken. > > Since i has been renamed in the previous patch, we can rename j to i. > > > > Signed

Re: [PATCH v4 02/15] cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors.

2020-11-16 Thread Daniel Kiper
On Sun, Nov 15, 2020 at 10:38:18AM +0100, Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:22PM -0600, Glenn Washburn wrote: > > This makes it clear that the offset represents sectors, not bytes, in order > > to improve readability. > > > > Signed-off-by: Glenn Washburn > > Reviewed-by: P

Re: [PATCH v4 06/15] luks2: Rename variable i to keyslot_idx in luks2_get_keyslot.

2020-11-16 Thread Daniel Kiper
On Sun, Nov 15, 2020 at 10:43:55AM +0100, Patrick Steinhardt wrote: > On Fri, Nov 06, 2020 at 10:44:26PM -0600, Glenn Washburn wrote: > > Variables named i are usually looping variables, so rename to keyslot_idx to > > allow for easier reading of luks2_get_keyslot. > > > > Signed-off-by: Glenn Wash

Re: [RFC] ieee1275: Avoiding many unnecessary open/close

2020-11-16 Thread diegodo
On 2020-09-24 20:58, Eric Snowberg wrote: On Sep 24, 2020, at 11:11 AM, diegodo wrote: Hi, we are facing some performance issues with ieee1275 platform (ppc64le architecture to be more specific) and I would like to suggest a couple of changes to try to avoid them. Sometimes the system can

Re: Network stack status & bugs?

2020-11-16 Thread Faidon Liambotis
Hey Daniel & team, On Thu, Oct 29, 2020 at 03:34:20AM +0200, Faidon Liambotis wrote: > On Tue, Oct 27, 2020 at 10:17:06PM +0100, Daniel Kiper wrote: > > On Mon, Jun 15, 2020 at 12:51:29PM +0300, Faidon Liambotis wrote: > > > Around a year ago, in my attempts to use GRUB for PXE, I ran into quite >