Re: [PATCH v6 5/6] cryptodisk: enable the backends to implement key files

2020-10-04 Thread Glenn Washburn
There are a couple issues with format string conversions that do not currently cause building to fail. However, they will when/if my strict format string checking for grub_error is accepted. Its best to fix them anyway. On Wed, 19 Aug 2020 17:09:13 +0200 Denis 'GNUtoo' Carikli wrote: > From: J

Re: [PATCH] error: Do compile-time format string checking on grub_error.

2020-10-04 Thread Glenn Washburn
On Sat, 3 Oct 2020 17:34:29 -0500 Glenn Washburn wrote: > On Thu, 17 Sep 2020 16:29:23 +0200 > Daniel Kiper wrote: > > > On Fri, Jul 31, 2020 at 09:33:18AM -0500, Glenn Washburn wrote: > > > Fix the many issues this uncovered mostly related to incorrect > > > length modifiers. > > > > Did you

[PATCH] error: Do compile-time format string checking on grub_error.

2020-10-04 Thread Glenn Washburn
Fix the many issues this uncovered mostly related to incorrect length modifiers. Signed-off-by: Glenn Washburn --- grub-core/commands/pgp.c | 2 +- grub-core/disk/ata.c | 4 ++-- grub-core/disk/cryptodisk.c| 14 -- grub-core/disk/dmraid_nvidia.c