Re: [PATCH 1/4] travis: Run bootstrap to fix build

2020-09-17 Thread Daniel Kiper
On Wed, Sep 09, 2020 at 10:02:18PM +0200, Petr Vorel wrote: > autogen.sh isn't enough: > $ ./autogen.sh > Gnulib not yet bootstrapped; run ./bootstrap instead. > The command "./autogen.sh" exited with 1. > > Using bootstrap requires to install autopoint package. > > Signed-off-by: Petr Vorel Revi

Re: [PATCH 2/4] travis: Fix sparc64 build

2020-09-17 Thread Daniel Kiper
On Wed, Sep 09, 2020 at 10:02:19PM +0200, Petr Vorel wrote: > Instead non-existing sparc64-ieee1275 format use all 3 sparc64 formats: > sparc64-ieee1275-{aout,cdcore,raw}. > > Signed-off-by: Petr Vorel > --- > .travis.yml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --gi

Re: [PATCH 3/4] travis: Remove mips builds

2020-09-17 Thread Daniel Kiper
On Wed, Sep 09, 2020 at 10:02:20PM +0200, Petr Vorel wrote: > Remove mips builds fix configure error: > configure: error: could not force big-endian) Could you try to fix mips and risc5 builds instead of removing them? Daniel ___ Grub-devel mailing lis

Re: [PATCH] If $hints is not set, we can reduce the output into grub.cfg from 5 lines to just 1 line.

2020-09-17 Thread Daniel Kiper
On Tue, Sep 01, 2020 at 07:13:20AM +0200, Florian La Roche via Grub-devel wrote: Missing SOB as previously... I can add it on your behalf if you are OK with it. Otherwise Reviewed-by: Daniel Kiper > --- > util/grub-mkconfig_lib.in | 14 +- > 1 file changed, 9 insertions(+), 5 deleti

Re: [PATCH v3 0/9] Cryptodisk fixes for v2.06

2020-09-17 Thread Patrick Steinhardt
On Mon, Sep 07, 2020 at 05:27:27PM +0200, Patrick Steinhardt wrote: > this is the third version of this patchset, collecting various fixes for > LUKS2/cryptodisk for the upcoming release of GRUB v2.06. > > Besides my Reviewed-by tag, the only thing that changed is the final > patch by Glenn. Quoti

Re: [PATCH] error: Do compile-time format string checking on grub_error.

2020-09-17 Thread Daniel Kiper
On Fri, Jul 31, 2020 at 09:33:18AM -0500, Glenn Washburn wrote: > Fix the many issues this uncovered mostly related to incorrect length > modifiers. Did you test the 32-bit and 64-bit builds with this patch? Daniel ___ Grub-devel mailing list Grub-deve

Re: [PATCH] If $hints is not set, we can reduce the output into grub.cfg from 5 lines to just 1 line.

2020-09-17 Thread Florian La Roche via Grub-devel
Hello grub-devel people and Daniel Kiper, Am Do., 17. Sept. 2020 um 16:04 Uhr schrieb Daniel Kiper : > > On Tue, Sep 01, 2020 at 07:13:20AM +0200, Florian La Roche via Grub-devel > wrote: > > Missing SOB as previously... I can add it on your behalf if you are OK > with it. Otherwise Reviewed-by:

Re: [PATCH 3/4] travis: Remove mips builds

2020-09-17 Thread Petr Vorel
Hi Daniel, > On Wed, Sep 09, 2020 at 10:02:20PM +0200, Petr Vorel wrote: > > Remove mips builds fix configure error: > > configure: error: could not force big-endian) > Could you try to fix mips and risc5 builds instead of removing them? Right, I'll try and send v2. Kind regards, Petr _

Re: [PATCH] tests: F2FS test should use MOUNTDEVICE like other tests.

2020-09-17 Thread Daniel Kiper
Adding Jaegeuk and Paul... On Fri, Aug 28, 2020 at 06:30:25PM -0500, Glenn Washburn wrote: > LODEVICES is not an array variable and should not be accessed as such. This > allows the f2fs test to pass as it was failing because a device name had a > space prepended to the path. > > Signed-off-by: Gl

Re: [PATCH] cryptodisk: Use cipher name instead of object in error message.

2020-09-17 Thread Daniel Kiper
On Fri, Jul 31, 2020 at 09:33:19AM -0500, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] script: Do not allow a delimiter between function name and block start.

2020-09-17 Thread Daniel Kiper
On Fri, Jul 31, 2020 at 09:33:22AM -0500, Glenn Washburn wrote: > Currently the following is valid syntax, but should be a syntax error: > > grub> function f; { echo HERE; } > grub> f > HERE > > This fix is not backward compatible, but current syntax is not documented > either and has no functional

Re: [PATCH] crypto: Remove GPG_ERROR_CFLAGS from gpg_err_code_t enum.

2020-09-17 Thread Daniel Kiper
On Fri, Jul 31, 2020 at 09:33:23AM -0500, Glenn Washburn wrote: > This was probably added by accident when originally creating the file. > > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org

Re: [PATCH] lexer: char const * should be const char *.

2020-09-17 Thread Daniel Kiper
On Fri, Jul 31, 2020 at 09:33:20AM -0500, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] docs/grub: Support for loading and concatenating multiple initrds.

2020-09-17 Thread Daniel Kiper
On Fri, Jul 31, 2020 at 09:33:21AM -0500, Glenn Washburn wrote: > This has been available since January of 2012, but has not been documented. > > Signed-off-by: Glenn Washburn Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gn

Re: [PATCH] shim_lock: Enable module for all EFI platforms

2020-09-17 Thread Daniel Kiper
On Wed, Jul 29, 2020 at 03:11:09PM +0800, Tianjia Zhang wrote: > Like tpm, the module is only enabled for x86_64, but there's nothing > specific to x86_64 in the implementation and can be enabled for all > EFI platforms. > > Signed-off-by: Tianjia Zhang > --- > grub-core/Makefile.core.def | 2 +-

Re: [PATCH] tests: F2FS test should use MOUNTDEVICE like other tests.

2020-09-17 Thread Jaegeuk Kim
On 09/17, Daniel Kiper wrote: > Adding Jaegeuk and Paul... > > On Fri, Aug 28, 2020 at 06:30:25PM -0500, Glenn Washburn wrote: > > LODEVICES is not an array variable and should not be accessed as such. This > > allows the f2fs test to pass as it was failing because a device name had a > > space pr

Re: [PATCH] shim_lock: Enable module for all EFI platforms

2020-09-17 Thread Tianjia Zhang
Hi, On 9/17/20 10:58 PM, Daniel Kiper wrote: On Wed, Jul 29, 2020 at 03:11:09PM +0800, Tianjia Zhang wrote: Like tpm, the module is only enabled for x86_64, but there's nothing specific to x86_64 in the implementation and can be enabled for all EFI platforms. Signed-off-by: Tianjia Zhang ---

Re: [PATCH] shim_lock: Enable module for all EFI platforms

2020-09-17 Thread Paul Menzel
Dear Tianjia, Thank you for your patch and your reply. Am 18.09.20 um 07:08 schrieb Tianjia Zhang: On 9/17/20 10:58 PM, Daniel Kiper wrote: On Wed, Jul 29, 2020 at 03:11:09PM +0800, Tianjia Zhang wrote: Like tpm, the module is only enabled for x86_64, but there's nothing specific to x86_64