Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

Hello Daniel, Thanks for the review. On 9/7/20 9:36 PM, Daniel Kiper wrote: > On Tue, Sep 01, 2020 at 02:30:35PM +0200, Javier Martinez Canillas wrote: >> Commit 781b3e5efc3 ("tftp: Do not use priority queue") caused a regression > > Please drop the quotes. > Sure, I can do that but I wonder wh

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

Hey Javier, On Wed, Sep 09, 2020 at 12:47:20PM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > Thanks for the review. > > On 9/7/20 9:36 PM, Daniel Kiper wrote: > > On Tue, Sep 01, 2020 at 02:30:35PM +0200, Javier Martinez Canillas wrote: > >> Commit 781b3e5efc3 ("tftp: Do not use prior

Re: [PATCH v3 9/9] cryptodisk: Properly handle non-512 byte sized sectors

On Mon, Sep 07, 2020 at 05:28:08PM +0200, Patrick Steinhardt wrote: > From: Glenn Washburn > > By default, dm-crypt internally uses an IV that corresponds to 512-byte > sectors, even when a larger sector size is specified. What this means is > that when using a larger sector size, the IV is increm

Re: [PATCH v3 0/9] Cryptodisk fixes for v2.06

Hey Patrick, On Mon, Sep 07, 2020 at 05:27:27PM +0200, Patrick Steinhardt wrote: > Hi, > > this is the third version of this patchset, collecting various fixes for > LUKS2/cryptodisk for the upcoming release of GRUB v2.06. > > Besides my Reviewed-by tag, the only thing that changed is the final >

Re: [PATCH] remove unneccessary trailing semicolon

Hi Florian, Your patch is missing Signed-off-by: Florian La Roche If you are OK with me adding it for you I will take this patch. On Tue, Sep 01, 2020 at 07:11:59AM +0200, Florian La Roche via Grub-devel wrote: > --- > util/grub.d/41_custom.in | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH] remove unneccessary trailing semicolon

Hello Daniel Kiper, Daniel Kiper schrieb am Mi., 9. Sep. 2020, 14:37: > Hi Florian, > > Your patch is missing > Signed-off-by: Florian La Roche > > If you are OK with me adding it for you I will take this patch. > OK. Best regards, Florian La Roche __

[PATCH 0/4] Fix Travis CI

Hi, although grub does not use Travis CI (or at least not publicly) some developers might welcome fixed .travis.yml for testing their patches. I haven't figured out how to fix riscv32 and mips. Kind regards, Petr Petr Vorel (4): travis: Run bootstrap to fix build travis: Fix sparc64 build

[PATCH 3/4] travis: Remove mips builds

Remove mips builds fix configure error: configure: error: could not force big-endian) Signed-off-by: Petr Vorel --- .travis.yml | 4 1 file changed, 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index d019a0172..ca2a1fa5a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -87,10 +87,6 @

[PATCH 2/4] travis: Fix sparc64 build

Instead non-existing sparc64-ieee1275 format use all 3 sparc64 formats: sparc64-ieee1275-{aout,cdcore,raw}. Signed-off-by: Petr Vorel --- .travis.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 4bd05a30a..d019a0172 100644 --- a/.travi

[PATCH 1/4] travis: Run bootstrap to fix build

autogen.sh isn't enough: $ ./autogen.sh Gnulib not yet bootstrapped; run ./bootstrap instead. The command "./autogen.sh" exited with 1. Using bootstrap requires to install autopoint package. Signed-off-by: Petr Vorel --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH 4/4] travis: Remove riscv32 build

To fix travis error: grub-mkimage: error: target 1036 not reachable from pc=ba. Signed-off-by: Petr Vorel --- .travis.yml | 4 1 file changed, 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index ca2a1fa5a..8628c526f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -95,10 +95,6 @@ matr

Re: [PATCH] tftp: roll-over block counter to prevent data packets timeouts

> On Sep 9, 2020, at 4:12 AM, Daniel Kiper wrote: > > Hey Javier, > > On Wed, Sep 09, 2020 at 12:47:20PM +0200, Javier Martinez Canillas wrote: >> Hello Daniel, >> >> Thanks for the review. >> >> On 9/7/20 9:36 PM, Daniel Kiper wrote: >>> On Tue, Sep 01, 2020 at 02:30:35PM +0200, Javier Marti