Re: [PATCH v3 3/9] luks2: Fix use of incorrect index and some error messages

On Mon, Sep 07, 2020 at 05:27:41PM +0200, Patrick Steinhardt wrote: > From: Glenn Washburn It seems to me this patch should be split into two and and begs for commit message improvement. In general it would be nice to know why we need these fixes. Daniel

Re: [PATCH v3 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors

On Mon, Sep 07, 2020 at 05:27:46PM +0200, Patrick Steinhardt wrote: > From: Glenn Washburn > > The total_length field is named confusingly because length usually refers to > bytes, whereas in this case its really the total number of sectors on the > device. Also counter-intuitively, grub_disk_get_

Re: [PATCH v3 6/9] cryptodisk: Unregister cryptomount command when removing module

On Mon, Sep 07, 2020 at 05:27:55PM +0200, Patrick Steinhardt wrote: > From: Glenn Washburn > > Signed-off-by: Glenn Washburn > Reviewed-by: Patrick Steinhardt > --- > grub-core/disk/cryptodisk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/grub-core/disk/cryptodisk.c b/grub-core/dis

Re: [PATCH v3 8/9] cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain'

On Mon, Sep 07, 2020 at 05:28:04PM +0200, Patrick Steinhardt wrote: > From: Glenn Washburn Could explain here why this patch is needed? I know why but I would like to have this explicitly stated in the commit message. Daniel ___ Grub-devel mailing lis