Re: [PATCH] cryptodisk: Incorrect calculation of sector in grub_cryptodisk_read/write.

2020-08-28 Thread Patrick Steinhardt
On Wed, Aug 26, 2020 at 06:50:29PM -0500, Glenn Washburn wrote: > On Wed, 26 Aug 2020 18:44:35 -0500 > Glenn Washburn wrote: > > > Here dev is a grub_cryptodisk_t and dev->offset is offset in sectors > > of size native to the cryptodisk device. The function grub_disk_read > > expects that the giv

Re: [PATCH v2 0/9] Cryptodisk fixes for v2.06

2020-08-28 Thread Patrick Steinhardt
On Wed, Aug 26, 2020 at 05:16:57PM -0500, Glenn Washburn wrote: > On Wed, 26 Aug 2020 10:13:18 +0200 > Patrick Steinhardt wrote: > > > I didn't yet get your test series to work, Glenn. I'll try again on > > another day as I'm not on top of things today. Meanwhile, could you > > please give it a g

Quoting issues in Bash script `grub-fs-tester` causes F2FS test failure

2020-08-28 Thread Paul Menzel
Dear GRUB folks, Running `sudo env make -e check VERBOSE=yes SUBDIRS=` the F2FS is one of the two tests failing. It returns 255. Running only the specific test sudo env TESTS=f2fs_test make -e check VERBOSE=yes SUBDIRS= which runs sudo ./grub-fs-tester f2fs and using `set -ex` in

Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-28 Thread HardenedArray via Grub-devel
I run Arch Linux as an encrypted /, /boot and swap system. That encrypted /boot is nothing more than a folder under /, however two Keyslots are required to boot. If I understand the boot process correctly, LUKS Keyslot 1 is used by grub to unlock /boot, then control is handed off to the kernel

Re: Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-28 Thread Eli Schwartz
On 8/28/20 11:28 AM, HardenedArray via Grub-devel wrote: > I run Arch Linux as an encrypted /, /boot and swap system. That > encrypted /boot is nothing more than a folder under /, however two > Keyslots are required to boot. > > If I understand the boot process correctly, LUKS Keyslot 1 is used by

Re: Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-28 Thread HardenedArray via Grub-devel
Hi Eli, Unless I missed what I said in this very long, convoluted LUKS2 IRC history, I do not recall telling you that I could cryptomount from a --type luks1 partition, simply because I had never had a reason to do so. Again, grub boots my luks1 encrypted /boot system without issue, meaning I

Re: Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-28 Thread Patrick Steinhardt
On Fri, Aug 28, 2020 at 11:37:24AM -0400, Eli Schwartz wrote: > On 8/28/20 11:28 AM, HardenedArray via Grub-devel wrote: > > I run Arch Linux as an encrypted /, /boot and swap system. That > > encrypted /boot is nothing more than a folder under /, however two > > Keyslots are required to boot. > >

Re: Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-28 Thread Eli Schwartz
On 8/28/20 12:35 PM, HardenedArray via Grub-devel wrote: > Hi Eli, > > Unless I missed what I said in this very long, convoluted LUKS2 IRC > history, I do not recall telling you that I could cryptomount from a > --type luks1 partition, simply because I had never had a reason to do > so. 2020-08-1

Re: Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-28 Thread Eli Schwartz
On 8/28/20 12:51 PM, Patrick Steinhardt wrote: > If that's the case, then this is entirely expected right now. > grub-install doesn't yet include the required modules automatically for > LUKS2 support. There is ongoing work to enable this, first by > recognizing LUKS2 devices at all [1,2]. But we'r

Re: Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-28 Thread HardenedArray via Grub-devel
Eli, Sorry if you misunderstood how I decrypted a LUKS2 / from a booted LUKS1 encrypted /boot Arch system. No CLI, nor initramfs was involved. I merely booted my LUKS1 encrypted /boot, logged into SDDM, then used KDE's Dolphin to unlock another LUKS2 / partition. And, of course, grub can boot

Re: Can grub-git be used to decrypt a LUKS2 encrypted partition? Testing Results

2020-08-28 Thread Glenn Washburn
On Fri, 28 Aug 2020 15:28:41 + HardenedArray via Grub-devel wrote: > I run Arch Linux as an encrypted /, /boot and swap system. That > encrypted /boot is nothing more than a folder under /, however two > Keyslots are required to boot. > > If I understand the boot process correctly, LUKS Keys

[PATCH] tests: F2FS test should use MOUNTDEVICE like other tests.

2020-08-28 Thread Glenn Washburn
LODEVICES is not an array variable and should not be accessed as such. This allows the f2fs test to pass as it was failing because a device name had a space prepended to the path. Signed-off-by: Glenn Washburn --- tests/util/grub-fs-tester.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)