[PATCH v2] i386: Make pmtimer tsc calibration not take 51 seconds to fail

2020-05-29 Thread Javier Martinez Canillas
From: Peter Jones On my laptop running at 2.4GHz, if I run a VM where tsc calibration using pmtimer will fail presuming a broken pmtimer, it takes ~51 seconds to do so (as measured with the stopwatch on my phone), with a tsc delta of 0x1cd1c85300, or around 125 billion cycles. If instead of tryi

[BOOTLOADER SPECIFICATION RFC] The bootloader log format for TrenchBoot and others

2020-05-29 Thread Daniel Kiper
Hey, Below you can find my rough idea of the bootloader log format which is generic thing but initially will be used for TrenchBoot work. I discussed this proposal with Ross and Daniel S. So, the idea went through initial sanitization. Now I would like to take feedback from other folks too. So, pl

Re: [PATCH REBASED] verify: search keyid in hashed signature subpackets

2020-05-29 Thread Daniel Kiper
On Fri, May 29, 2020 at 02:10:46PM +1000, Daniel Axtens wrote: > Charles Duffy writes: > > > Amended the test repo to apply this patch; it applies and works-as-intended > > on both 2.04 and current master. > > > > As for the DCO assertions, my portion of the contribution was implemented > > strict

Re: [PATCH 2/6] net/http: Return an error on HTTP error responses

2020-05-29 Thread Daniel Kiper
On Thu, May 28, 2020 at 09:10:59AM +0200, Javier Martinez Canillas wrote: > On 5/25/20 9:02 PM, Daniel Kiper wrote: > > From: Olaf Hering > > > > A http transfer will hang if an error is returned. The error branch > > returns the value GRUB_ERR_NONE which is not expected by the caller. > > > > Sig

Re: [PATCH 4/6] tpm: Drop unneeded code

2020-05-29 Thread Daniel Kiper
On Thu, May 28, 2020 at 09:22:34AM +0200, Javier Martinez Canillas wrote: > On 5/25/20 9:02 PM, Daniel Kiper wrote: > > Drop unused grub_tpm*_execute() and declaration of nonexistent > > grub_tpm_init(). > > > > Signed-off-by: Daniel Kiper > > --- > > [snip] > > > -static grub_err_t > > -grub_tpm

Re: [PATCH] json: Remove invalid typedef redefinition

2020-05-29 Thread Daniel Kiper
On Wed, May 27, 2020 at 11:18:24AM +0200, Patrick Steinhardt wrote: > The C standard does not allow for typedef redefinitions, even if they > map to the same underlying type. In order to avoid including the > "jsmn.h" in "json.h" and thus exposing jsmn's internals, we have exactly > such a forward-

Re: GRUB 2.06 release

2020-05-29 Thread Daniel Kiper
On Wed, Apr 22, 2020 at 12:24:40PM +0200, Daniel Kiper wrote: > On Mon, Mar 16, 2020 at 05:41:29PM +0100, Daniel Kiper wrote: > > On Wed, Mar 11, 2020 at 11:47:35AM +0100, Daniel Kiper wrote: > > > On Tue, Mar 03, 2020 at 06:26:03PM +0100, Daniel Kiper wrote: > > > > On Wed, Feb 19, 2020 at 04:01:3

Re: [PATCH v2] Warn if MBR gap is small and user uses advanced modules

2020-05-29 Thread Vladimir 'phcoder' Serbinenko
On Tue, May 12, 2020 at 1:48 PM Daniel Kiper wrote: > > On Mon, Apr 27, 2020 at 05:51:34PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > We don't want to support small MBR gap in pair with anything but > > the simplest config of biosdisk+part_msdos+simple filesystem. In this > > path "simple fil

Re: [PATCH v2] Warn if MBR gap is small and user uses advanced modules

2020-05-29 Thread Vladimir 'phcoder' Serbinenko
Signed-off-by: Bladimir Serbinenko On Fri, May 29, 2020 at 3:09 PM Vladimir 'phcoder' Serbinenko wrote: > > On Tue, May 12, 2020 at 1:48 PM Daniel Kiper wrote: > > > > On Mon, Apr 27, 2020 at 05:51:34PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > > > We don't want to support small MBR ga

Re: [PATCH REBASED] verify: search keyid in hashed signature subpackets

2020-05-29 Thread Daniel Axtens
Daniel Kiper writes: > On Fri, May 29, 2020 at 02:10:46PM +1000, Daniel Axtens wrote: >> Charles Duffy writes: >> >> > Amended the test repo to apply this patch; it applies and works-as-intended >> > on both 2.04 and current master. >> > >> > As for the DCO assertions, my portion of the contribu

Re: [PATCH] json: Remove invalid typedef redefinition

2020-05-29 Thread Daniel Axtens
Hi Patrick, > The C standard does not allow for typedef redefinitions, even if they > map to the same underlying type. In order to avoid including the > "jsmn.h" in "json.h" and thus exposing jsmn's internals, we have exactly > such a forward-declaring typedef in "json.h". If enforcing the GNU99 C

Re: [BOOTLOADER SPECIFICATION RFC] The bootloader log format for TrenchBoot and others

2020-05-29 Thread Andy Lutomirski
> On May 29, 2020, at 4:30 AM, Daniel Kiper wrote: > > Hey, > > Below you can find my rough idea of the bootloader log format which is > generic thing but initially will be used for TrenchBoot work. I discussed > this proposal with Ross and Daniel S. So, the idea went through initial > saniti