Build RISC-V 32-bit UEFI target fails with kernel.org riscv64 toolchain

2020-03-27 Thread Bin Meng
Hi, I tried to build RISC-V 32-bit UEFI target using kernel.org riscv64 toolchain: https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/7.3.0/x86_64-gcc-7.3.0-nolibc_riscv64-linux.tar.xz $ ./configure --target=riscv32 --with-platform=efi CC=gcc TARGET_CC=/share/toolchains/gcc-7.3.

[PATCH] efi: add missed space in GRUB_EFI_GLOBAL_VARIABLE_GUID

2020-03-27 Thread Flavio Suligoi
Signed-off-by: Flavio Suligoi --- include/grub/efi/api.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/grub/efi/api.h b/include/grub/efi/api.h index d6f4de1..937058d 100644 --- a/include/grub/efi/api.h +++ b/include/grub/efi/api.h @@ -1295,7 +1295,7 @@ struct grub_ef

Re: [PATCH] efi: add missed space in GRUB_EFI_GLOBAL_VARIABLE_GUID

2020-03-27 Thread Vladimir 'phcoder' Serbinenko
Could you explain why we would need this patch? It changes nothing AFAICT On Fri, Mar 27, 2020, 12:01 Flavio Suligoi wrote: > Signed-off-by: Flavio Suligoi > --- > include/grub/efi/api.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/grub/efi/api.h b/include/g

Re: [PATCH] efi: add missed space in GRUB_EFI_GLOBAL_VARIABLE_GUID

2020-03-27 Thread John Paul Adrian Glaubitz
On 3/27/20 1:11 PM, Vladimir 'phcoder' Serbinenko wrote: > Could you explain why we would need this patch? It changes nothing AFAICT It's a cosmetic change, there is one space character missing before the last value in the curly braces: >> #define GRUB_EFI_GLOBAL_VARIABLE_GUID \ >> - { 0x8BE4DF

RE: [PATCH] efi: add missed space in GRUB_EFI_GLOBAL_VARIABLE_GUID

2020-03-27 Thread Flavio Suligoi
Hi Vladimir and Adrian, > > On 3/27/20 1:11 PM, Vladimir 'phcoder' Serbinenko wrote: > > Could you explain why we would need this patch? It changes nothing > AFAICT > > It's a cosmetic change, there is one space character missing before the > last > value in the curly braces: Exactly, this is a

Re: [PATCH] efi: add missed space in GRUB_EFI_GLOBAL_VARIABLE_GUID

2020-03-27 Thread Daniel Kiper
On Fri, Mar 27, 2020 at 12:50:31PM +, Flavio Suligoi wrote: > Hi Vladimir and Adrian, > > > On 3/27/20 1:11 PM, Vladimir 'phcoder' Serbinenko wrote: > > > Could you explain why we would need this patch? It changes nothing > > AFAICT > > > > It's a cosmetic change, there is one space character m

Re: [PATCH] grub.d: Use linuxefi and initrdefi commands if platform is efi

2020-03-27 Thread Konrad Rzeszutek Wilk
On Wed, Mar 25, 2020 at 06:38:54PM +0100, Daniel Kiper wrote: > On Mon, Mar 23, 2020 at 07:53:15PM +0800, Tianjia Zhang wrote: > > When the platform is EFI platform, use 'linuxefi' and 'initrdefi' > > commands instead of 'linux' and 'initrd'. > > > > Signed-off-by: Jia Zhang > > Signed-off-by: Tia

Re: fs/ntfscomp.c:82:11: error: ‘flg’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

2020-03-27 Thread Daniel Kiper
On Thu, Mar 26, 2020 at 04:10:05AM -0700, PGNet Dev wrote: > On 3/26/20 1:39 AM, Paul Menzel wrote: > > > I am unable to reproduce this with > > 1st sanity re-check: > > > > I _am_ able to reproduce this consistently, with same error. > > > > I've tested now on multiple machines; not identical, but

Re: Build RISC-V 32-bit UEFI target fails with kernel.org riscv64 toolchain

2020-03-27 Thread Daniel Kiper
Adding Alex... On Fri, Mar 27, 2020 at 03:01:15PM +0800, Bin Meng wrote: > Hi, > > I tried to build RISC-V 32-bit UEFI target using kernel.org riscv64 toolchain: > https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/7.3.0/x86_64-gcc-7.3.0-nolibc_riscv64-linux.tar.xz > > $ ./config

Re: fs/ntfscomp.c:82:11: error: ‘flg’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

2020-03-27 Thread PGNet Dev
On 3/27/20 7:45 AM, Daniel Kiper wrote: >> _is_ a 'clear' env expected/recommended/required for a grub2 build? > > You control your own build environment. So, if you add options which are > not supported by the GRUB then there is pretty good chance that the > build or generated output will fall ap

Re: [PATCH v4 1/2] lvm: add lvm cache logical volume handling

2020-03-27 Thread Daniel Kiper
On Thu, Mar 19, 2020 at 01:56:13PM +0800, Michael Chang wrote: > The lvm cache logical volume is the logical volume consisting of the original > and the cache pool logical volume. The original is usually on a larger and > slower storage device while the cache pool is on a smaller and faster one. Th

Re: [PATCH] grub.d: Use linuxefi and initrdefi commands if platform is efi

2020-03-27 Thread Daniel Kiper
On Fri, Mar 27, 2020 at 10:44:09AM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 25, 2020 at 06:38:54PM +0100, Daniel Kiper wrote: > > On Mon, Mar 23, 2020 at 07:53:15PM +0800, Tianjia Zhang wrote: > > > When the platform is EFI platform, use 'linuxefi' and 'initrdefi' > > > commands instead of

Re: Build RISC-V 32-bit UEFI target fails with kernel.org riscv64 toolchain

2020-03-27 Thread Bin Meng
On Fri, Mar 27, 2020 at 10:51 PM Daniel Kiper wrote: > > Adding Alex... > > On Fri, Mar 27, 2020 at 03:01:15PM +0800, Bin Meng wrote: > > Hi, > > > > I tried to build RISC-V 32-bit UEFI target using kernel.org riscv64 > > toolchain: > > https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bi