Re: [PATCH v3 1/2] lvm: add lvm cache logical volume handling

2020-03-18 Thread Michael Chang
On Fri, Mar 13, 2020 at 01:23:42PM +0100, Daniel Kiper wrote: > On Wed, Mar 04, 2020 at 02:44:52PM +0800, Michael Chang wrote: [snip] > > @@ -243,6 +279,8 @@ grub_lvm_detect (grub_disk_t disk, > > > >if (! vg) > > { > > + struct cache_lv *cache_lvs = NULL; > > + > >/* First

[PATCH v1] fix kernel cmdline corruption

2020-03-18 Thread Olaf Hering
The functions grub_create_loader_cmdline and its sibling grub_loader_cmdline_size add extra, unexpected characters to the kernel cmdline. Both functions are supposed to copy each argv[] element verbatim. It is up to the caller of the kernel command ('linux' for example) to add desired quoting or es

Re: avoiding quotes in kernel cmdline

2020-03-18 Thread Olaf Hering
Am Fri, 13 Mar 2020 15:26:33 +0100 schrieb Daniel Kiper : > Adding Vladimir. There is a chance that he knows why it was added... In the end this knowledge does not matter much I think. I sent a patch to fix the bug. Olaf pgpfisLVNYarp.pgp Description: Digitale Signatur von OpenPGP

Re: [PATCH v3 3/5] argon2: Import Argon2 from cryptsetup

2020-03-18 Thread Patrick Steinhardt
On Mon, Mar 16, 2020 at 03:57:02PM -0400, Konrad Rzeszutek Wilk wrote: > On Mon, Mar 16, 2020 at 06:21:06PM +0100, Daniel Kiper wrote: > > On Fri, Mar 13, 2020 at 02:13:49PM +0100, Daniel Kiper wrote: > > > On Tue, Mar 10, 2020 at 07:58:30PM +0100, Patrick Steinhardt wrote: > > > > In order to supp

Re: Verifier running out of memory on ieee1275/powerpc64

2020-03-18 Thread Simon Hardy
The 2020/03/17 13:15, Stefan Berger wrote: >  I trying to add (v)TPM support for the ieee1275/powerpc64 platform to grub. > The issue I have been running into is that the verifier runs out of memory. > At that point it has loaded the (~ 32MB) Linux kernel and now the verifier > is invoked to load t

Re: Verifier running out of memory on ieee1275/powerpc64

2020-03-18 Thread Stefan Berger
On 3/18/20 11:59 AM, Simon Hardy wrote: The 2020/03/17 13:15, Stefan Berger wrote:  I trying to add (v)TPM support for the ieee1275/powerpc64 platform to grub. The issue I have been running into is that the verifier runs out of memory. At that point it has loaded the (~ 32MB) Linux kernel and n

Re: Verifier running out of memory on ieee1275/powerpc64

2020-03-18 Thread Stefan Berger
On 3/18/20 3:32 PM, Stefan Berger wrote: On 3/18/20 11:59 AM, Simon Hardy wrote: The 2020/03/17 13:15, Stefan Berger wrote:   I trying to add (v)TPM support for the ieee1275/powerpc64 platform to grub. The issue I have been running into is that the verifier runs out of memory. At that point it

Re: Verifier running out of memory on ieee1275/powerpc64

2020-03-18 Thread Simon Hardy
> > I was wondering whether it would not be possible to load the raw file > > into memory, pass it to the firmware for hashing (and logging) via the > > verifier, and if we do not trust that the firmware treated the file data > > as a read-only array, load the file again into the same array right >

[PATCH v4 1/2] lvm: add lvm cache logical volume handling

2020-03-18 Thread Michael Chang
The lvm cache logical volume is the logical volume consisting of the original and the cache pool logical volume. The original is usually on a larger and slower storage device while the cache pool is on a smaller and faster one. The performance of the original volume can be improved by storing the f

[PATCH v4 2/2] docs: Document notes on LVM cache booting

2020-03-18 Thread Michael Chang
Add notes on LVM cache booting to the GRUB manual to help user understanding the outstanding issue and status. Signed-off-by: Michael Chang Reviewed-by: Daniel Kiper --- docs/grub.texi | 21 + 1 file changed, 21 insertions(+) diff --git a/docs/grub.texi b/docs/grub.texi ind