Re: [RESEND PATCH v4 2/2] Make editenv chase symlinks including those across devices

2020-02-11 Thread Daniel Kiper
On Fri, Jan 17, 2020 at 05:10:43PM +0100, Javier Martinez Canillas wrote: > From: Peter Jones > > The grub-editenv create command will wrongly overwrite /boot/grub2/grubenv > with a regular file if grubenv is a symbolic link. But instead, it should > create a new file in the path the symlink point

Re: [PATCH 3/5] disk: luks2: Add missing newline to debug message

2020-02-11 Thread Daniel Kiper
On Thu, Feb 06, 2020 at 03:27:31PM +0100, Patrick Steinhardt wrote: > The debug message printed when decryption with a keyslot fails is > missing its trailing newline. Add it to avoid mangling it with > subsequent output. > > Signed-off-by: Patrick Steinhardt Reviewed-by: Daniel Kiper I will ta

Re: [PATCH 0/5] Support Argon2 KDF in LUKS2

2020-02-11 Thread Daniel Kiper
Adding Milan, Leif, Alex, Peter, Mathew and Vladimir. On Thu, Feb 06, 2020 at 03:27:28PM +0100, Patrick Steinhardt wrote: > Hi, > > as promised back when LUKS2 support was merged, here's the code that > enables decrypting LUKS2 partitions that use Argon2 as their key derival > function. Most of th

Re: Volume keys in grub2

2020-02-11 Thread Daniel Kiper
On Mon, Feb 10, 2020 at 09:17:18AM +, Workaround Profi_GMan wrote: > Hello! > As far as I see, the volume keys are mapped to the normal "up" and "down" > keys and they function just as up and down keys. So my aim to make them > recognized as different keys so I can adjust each of them separat

Re: [PATCH 0/5] Support Argon2 KDF in LUKS2

2020-02-11 Thread Milan Broz
On 11/02/2020 22:53, Daniel Kiper wrote: > Adding Milan, Leif, Alex, Peter, Mathew and Vladimir. > > On Thu, Feb 06, 2020 at 03:27:28PM +0100, Patrick Steinhardt wrote: >> Hi, >> >> as promised back when LUKS2 support was merged, here's the code that >> enables decrypting LUKS2 partitions that use

Re: [PATCH 0/5] Support Argon2 KDF in LUKS2

2020-02-11 Thread Patrick Steinhardt
On Tue, Feb 11, 2020 at 10:53:59PM +0100, Daniel Kiper wrote: > > GRUB's codebase. This included both stripping off unneeded > > functionality as well as converting the code to use our own coding > > Stripping unneeded functionality is OK. However, I think that it does > not make sense

Re: [PATCH 3/5] disk: luks2: Add missing newline to debug message

2020-02-11 Thread Patrick Steinhardt
On Tue, Feb 11, 2020 at 10:36:22PM +0100, Daniel Kiper wrote: > On Thu, Feb 06, 2020 at 03:27:31PM +0100, Patrick Steinhardt wrote: > > The debug message printed when decryption with a keyslot fails is > > missing its trailing newline. Add it to avoid mangling it with > > subsequent output. > > > >