[PATCH] multiboot2: set min address for mbi allocation to 0x1000

2019-12-13 Thread Lukasz Hawrylko
In some cases GRUB2 allocates multiboot2 structure at 0 address, that is a confusing behavior, so define min address for mbi allocation in x86 and x86_64 platforms Signed-off-by: Lukasz Hawrylko --- grub-core/loader/multiboot_mbi2.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) d

Re: [PATCH] tftp: Normalize slashes in tftp paths

2019-12-13 Thread Javier Martinez Canillas
Hello Daniel, On 11/29/19 4:53 PM, Daniel Kiper wrote: > On Thu, Oct 31, 2019 at 11:33:39AM +0100, Javier Martinez Canillas wrote: >> From: Lenny Szubowicz >> >> Some tftp servers do not handle multiple consecutive slashes correctly; >> this patch avoids sending tftp requests with non-normalized

Re: [GRUB PATCH 1/1] loader/i386/linux: Fix an underflow in the setup_header length calculation

2019-12-13 Thread Javier Martinez Canillas
Hello Daniel, On 12/2/19 6:29 PM, Daniel Kiper wrote: > Recent work around x86 Linux kernel loader revealed an underflow in the > setup_header length calculation and another related issue. Both lead to > the memory overwrite and later machine crash. > > Currently when the GRUB copies the setup_he

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-12-13 Thread Javier Martinez Canillas
On 11/29/19 4:46 PM, Daniel Kiper wrote: > On Wed, Oct 30, 2019 at 06:02:35PM +0100, Javier Martinez Canillas wrote: >> On 10/30/19 2:45 PM, Vladimir 'phcoder' Serbinenko wrote: >>> We had a discussion with Daniel and agreed on following: >>> 1) we accept the feature >> >> Great, thanks. >> >>> 2)

Re: [PATCH] ofnet: Fix incorrect mask for ppc64

2019-12-13 Thread Javier Martinez Canillas
Hello Vladimir, Thanks a lot for your feedback. On 10/31/19 12:58 PM, Vladimir 'phcoder' Serbinenko wrote: > Please don't chain swap_bytes32 with le_to_cpu32 as it's a less readable > equivalent of be_to_cpu32 > That's correct. In fact I think that the patch is wrong and what we should do is jus

Re: [PATCH v3 1/2] Add grub_util_readlink()

2019-12-13 Thread Javier Martinez Canillas
Hello Daniel, On 11/5/19 12:42 PM, Daniel Kiper wrote: [snip] >> --- grub-core/osdep/windows/hostdisk.c >> +++ grub-core/osdep/windows/hostdisk.c >> @@ -365,6 +365,12 @@ grub_util_mkdir (const char *dir) >>free (windows_name); >> } >> >> +ssize_t >> +grub_util_readlink (const char *name, ch

Fwd: [PATCH] ofnet: Fix incorrect mask for ppc64

2019-12-13 Thread Vladimir 'phcoder' Serbinenko
-- Forwarded message - From: Vladimir 'phcoder' Serbinenko Date: Fri, 13 Dec 2019, 15:56 Subject: Re: [PATCH] ofnet: Fix incorrect mask for ppc64 To: Javier Martinez Canillas On Fri, 13 Dec 2019, 15:33 Javier Martinez Canillas, wrote: > Hello Vladimir, > > Thanks a lot for y

Re: [PATCH] ofnet: Fix incorrect mask for ppc64

2019-12-13 Thread Vladimir 'phcoder' Serbinenko
On Fri, 13 Dec 2019, 15:56 Vladimir 'phcoder' Serbinenko, wrote: > > -- Forwarded message - > From: Vladimir 'phcoder' Serbinenko > Date: Fri, 13 Dec 2019, 15:56 > Subject: Re: [PATCH] ofnet: Fix incorrect mask for ppc64 > To: Javier Martinez Canillas > > > > > On Fri, 13 Dec 20

Re: [PATCH] multiboot2: set min address for mbi allocation to 0x1000

2019-12-13 Thread Daniel Kiper
On Fri, Dec 13, 2019 at 10:20:19AM +0100, Lukasz Hawrylko wrote: > In some cases GRUB2 allocates multiboot2 structure at 0 address, that is > a confusing behavior, so define min address for mbi allocation in x86 Could you explain why this behavior is confusing? > and x86_64 platforms > > Signed-o

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-12-13 Thread Daniel Kiper
On Fri, Dec 13, 2019 at 03:28:37PM +0100, Javier Martinez Canillas wrote: > On 11/29/19 4:46 PM, Daniel Kiper wrote: > > On Wed, Oct 30, 2019 at 06:02:35PM +0100, Javier Martinez Canillas wrote: > >> On 10/30/19 2:45 PM, Vladimir 'phcoder' Serbinenko wrote: > >>> We had a discussion with Daniel and

Re: [PATCH v3 1/2] Add grub_util_readlink()

2019-12-13 Thread Daniel Kiper
On Fri, Dec 13, 2019 at 03:44:21PM +0100, Javier Martinez Canillas wrote: > Hello Daniel, > > On 11/5/19 12:42 PM, Daniel Kiper wrote: > > [snip] > > >> --- grub-core/osdep/windows/hostdisk.c > >> +++ grub-core/osdep/windows/hostdisk.c > >> @@ -365,6 +365,12 @@ grub_util_mkdir (const char *dir) > >

Re: [GRUB PATCH 1/1] loader/i386/linux: Fix an underflow in the setup_header length calculation

2019-12-13 Thread Ross Philipson
On 12/02/2019 12:29 PM, Daniel Kiper wrote: > Recent work around x86 Linux kernel loader revealed an underflow in the > setup_header length calculation and another related issue. Both lead to > the memory overwrite and later machine crash. > > Currently when the GRUB copies the setup_header into t

Re: [PATCH v6 2/6] json: Implement wrapping interface

2019-12-13 Thread Daniel Kiper
On Tue, Dec 10, 2019 at 10:26:17AM +0100, Patrick Steinhardt wrote: > While the newly added jsmn library provides the parsing interface, it > does not provide any kind of interface to act on parsed tokens. Instead, > the caller is expected to handle pointer arithmetics inside of the token > array i

Re: [PATCH] docs: Export `superusers` to apply to submenus

2019-12-13 Thread Daniel Kiper
On Tue, Dec 10, 2019 at 01:04:05PM +0100, Paul Menzel wrote: > Date: Tue, 10 Dec 2019 12:52:22 +0100 > Subject: [PATCH] docs: Export `superusers` to apply to submenus > > Signed-off-by: Paul Menzel > --- > docs/grub.texi | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --gi