Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-10-30 Thread Javier Martinez Canillas
Hello Vladimir, On 10/29/19 5:18 PM, Vladimir 'phcoder' Serbinenko wrote: > What is the problem with main grub.cfg just including the files based on > environment variables? > Do you mean having a grub.cfg that fetches the machine specific grub.cfg? i.e: configfile (tftp,$net_default_server)/EFI

[PATCH v3 2/2] Make editenv chase symlinks including those across devices

2019-10-30 Thread Javier Martinez Canillas
From: Peter Jones The grub-editenv create command will wrongly overwrite /boot/grub2/grubenv with a regular file if grubenv is a symbolic link. But instead, it should create a new file in the path the symlink points to. This lets /boot/grub2/grubenv be a symlink to /boot/efi/EFI/fedora/grubenv e

[PATCH v3 1/2] Add grub_util_readlink()

2019-10-30 Thread Javier Martinez Canillas
From: Peter Jones Currently grub-editenv and related tools are not able to follow symbolic links when finding their config file. For example the grub-editenv create command will wrongly overwrite a symlink in /boot/grub2/grubenv with a new regular file, instead of creating a file in the path the

Re: [PATCH v3 2/2] Make editenv chase symlinks including those across devices

2019-10-30 Thread Daniel Kiper
On Wed, Oct 30, 2019 at 11:48:14AM +0100, Javier Martinez Canillas wrote: > From: Peter Jones > > The grub-editenv create command will wrongly overwrite /boot/grub2/grubenv > with a regular file if grubenv is a symbolic link. But instead, it should > create a new file in the path the symlink point

Re: [PATCH] Enable pager by default

2019-10-30 Thread Daniel Kiper
On Fri, Oct 25, 2019 at 11:02:04AM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > On 10/24/19 4:50 PM, Daniel Kiper wrote: > > [snip] > > >> > >> From 7c4da6295ebd3a034d1f7e32099eab33efa465d4 Mon Sep 17 00:00:00 2001 > >> From: Javier Martinez Canillas > >> Date: Tue, 22 Oct 2019 15:35

Re: [PATCH] Enable pager by default

2019-10-30 Thread adrian15 adrian15
I agree. One of the Super Grub2 Disk options consists on showing from its menu the COPYRIGHT page... the pager variable is set to true so that the output is paged when the cat command is run. This usecase might not work anymore if something else than prompting a message on the interactive screen w

Re: [PATCH] Enable pager by default

2019-10-30 Thread Javier Martinez Canillas
On 10/30/19 1:12 PM, Daniel Kiper wrote: > On Fri, Oct 25, 2019 at 11:02:04AM +0200, Javier Martinez Canillas wrote: [snip] >> >> But I'll wait for the discussion to settle and a solution to be agreed upon, >> before posting a new patch for this. > > After some thinking it seems to me that Valdi

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-10-30 Thread Vladimir 'phcoder' Serbinenko
We had a discussion with Daniel and agreed on following: 1) we accept the feature 2) we want to have an option to specify grub config file. And if this option is present, the scanning would be disabled 3) to avoid multiple round-trips can we request all the possible files in parallel? On Wed, 30 O

Re: [PATCH v5 4/5] normal/main: Search for specific config files for netboot

2019-10-30 Thread Javier Martinez Canillas
On 10/30/19 2:45 PM, Vladimir 'phcoder' Serbinenko wrote: > We had a discussion with Daniel and agreed on following: > 1) we accept the feature Great, thanks. > 2) we want to have an option to specify grub config file. And if this > option is present, the scanning would be disabled Sure, you men