Hello John,
Except for lacking commit message and SOB, the fix is LGTM.
You could add my Reviewed-by: Michael Chang if you
resend the patch to mailing list with those missing message fixed.
Thanks,
Michael
On Mon, May 06, 2019 at 07:59:42PM +0200, John Paul Adrian Glaubitz wrote:
> On 5/6/19
On Wed, May 08, 2019 at 01:51:20AM +0100, Neil MacLeod wrote:
> Adrian
>
> I used the attached patch and grub is now building for me with gcc-9.1.
>
> I've no idea if this is the right solution, but it does at least work
> (ie. builds) which is all I require for now as I'm not personally
> using
The function grub_get_node_path could return uninitialized offset with
level == 0 if the block is greater than direct_index + 2*direct_blks +
2*indirect_blks + dindirect_blks. The uninitialized offset is then used
by function grub_f2fs_get_block because level == 0 is valid and
meaningful return to
Hi Michael!
On 5/17/19 9:13 AM, Michael Chang wrote:
> Except for lacking commit message and SOB, the fix is LGTM.
>
> You could add my Reviewed-by: Michael Chang if you
> resend the patch to mailing list with those missing message fixed.
I can do that later today. I'm currently busy with work
CC-ing n...@nmacleod.com
Michael, thank you for posting the patch.
Neil, does it solve your problem?
Daniel
On Fri, May 17, 2019 at 05:00:19PM +0800, Michael Chang wrote:
> The function grub_get_node_path could return uninitialized offset with
> level == 0 if the block is greater than direct_in
Hi Daniel & Michael
I've tested the new patch (in place of my attempt) and grub is
building successfully so it looks good here!
Many thanks!
Neil
On Fri, 17 May 2019 at 13:26, Daniel Kiper wrote:
>
> CC-ing n...@nmacleod.com
>
> Michael, thank you for posting the patch.
>
> Neil, does it solve
On 5/17/19 2:13 AM, Michael Chang wrote:
Hello John,
Except for lacking commit message and SOB, the fix is LGTM.
[snip]
---
grub-core/fs/f2fs.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/grub-core/fs/f2fs.c b/grub-core/fs/f2fs.c
index 1cad2615f..0dd09bc23 100644
--- a
