Re: [PATCH v2 0/2] Fix fallout from 4k section alignment patch

2019-05-06 Thread Daniel Kiper
On Wed, May 01, 2019 at 05:24:00PM +0100, Leif Lindholm wrote: > On Tue, Apr 30, 2019 at 10:43:55PM +0200, Alexander Graf wrote: > > Commit a51f953f4ee87 ("mkimage: Align efi sections on 4k boundary") > > broke ARM builds. There were 2 reasons for that: > > > > 1) An NX bug that was lingering for

gcc9.1 and f2fs

2019-05-06 Thread Neil MacLeod
With the latest grub HEAD (620857c4dccb8f0548cdb855f6b2f46ebea3919e) I'm getting the following compilation error with gcc-9.1: /home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.1-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc -DHAVE_CONFIG_H -I. -Wall -W -DGRUB_UTIL=1 -D_FIL

Re: gcc9.1 and f2fs

2019-05-06 Thread Bruce Dubbs
On 5/6/19 12:15 PM, Neil MacLeod wrote: With the latest grub HEAD (620857c4dccb8f0548cdb855f6b2f46ebea3919e) I'm getting the following compilation error with gcc-9.1: /home/ubuntu/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-9.1-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc -DHAVE_C

Re: gcc9.1 and f2fs

2019-05-06 Thread Neil MacLeod
Hi Bruce I'll give that a try in an hour or two once my build machine is not busy with another job, but presumably this is just for a test as it doesn't seem like a long term fix? Similar errors have all been fixed in code but for some reason this f2fs failure remains. Thanks Neil On Mon, 6 May

Re: gcc9.1 and f2fs

2019-05-06 Thread John Paul Adrian Glaubitz
On 5/6/19 7:15 PM, Neil MacLeod wrote: > Does anyone have a patch? Try the attached patch. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426

Re: gcc9.1 and f2fs

2019-05-06 Thread Neil MacLeod
Thanks Adrian - testing with your patch now, will be another hour or so until the build is complete (cross-compiling environment with own toolchain etc.) Just a correction, I'm testing with 4dd4ceec023111a4ccf69f8de6fa0885c6847a35 (current HEAD) - looks like I cut & pasted a rev from a different r

Re: gcc9.1 and f2fs

2019-05-06 Thread Neil MacLeod
Hi Adrian With your patch, grub now fails to build as follows: fs/f2fs.c: In function 'grub_f2fs_get_block': fs/f2fs.c:864:43: error: 'offset' may be used uninitialized in this function [-Werror=maybe-uninitialized] 864 | return grub_le_to_cpu32 (inode->i_addr[offset[0]]); |