[PATCH 0/8] fix gcc9 build with -Werror=address-of-packed-member

2019-04-09 Thread Michael Chang
This patch set attempts to resolve the build failure in openSUSE build service equipped with new gcc 9 compiler, which has added a new warning flag -Waddress-of-packed-member. The new warning performs the check for taking the address of packed member directly to a pointer variable with higher ali

[PATCH 8/8] efi: fix gcc9 error address-of-packed-member

2019-04-09 Thread Michael Chang
Copy the packed member to the buffer returned by grub_malloc, which is supposed to be suitably aligned for any data type, then use it as argument to grub_utf16_to_utf8. The solved gcc9 error like this. [ 255s] ../../grub-core/kern/efi/efi.c: In function 'grub_efi_get_filename': [ 255s] ../../gr

[PATCH 3/8] hfs: fix gcc9 error address-of-packed-member

2019-04-09 Thread Michael Chang
Add missing packed attribute to struct grub_hfs_extent. The solved gcc9 error like this. [ 83s] ../grub-core/fs/hfs.c: In function 'grub_hfs_iterate_records': [ 83s] ../grub-core/fs/hfs.c:699:9: error: taking address of packed member of 'struct grub_hfs_sblock' may result in an unaligned poi

[PATCH 4/8] hfsplus: fix gcc9 error address-of-packed-member

2019-04-09 Thread Michael Chang
Use pointer to buffer returned by grub_malloc, which is supposed to be suitably aligned for any data type, for holding the UTF16 string converted to host by order from packed struct member catkey->name. The aligned buffer is later used as argument to grub_utf16_to_utf8. By using a new copy of buff

[PATCH 1/8] cpio: fix gcc9 error address-of-packed-member

2019-04-09 Thread Michael Chang
Change the read_number function to use void* type as its first argument to silence the warning. The pointer is later type casted to grub_uint16_t* and use grub_get_unaligned16 for safely deferencing it for the value. The solved gcc9 error like this. [ 59s] In file included from ../grub-core/fs/

[PATCH 6/8] usbtest: fix gcc9 error address-of-packed-member

2019-04-09 Thread Michael Chang
Copy the packed member descstrp->str to the buffer strbuf returned by grub_malloc, which is supposed to be suitably aligned for any data type and after we use strbuf as argument to grub_utf16_to_utf8. The solved gcc9 error like this. [ 229s] ../../grub-core/commands/usbtest.c: In function 'grub_

[PATCH 2/8] jfs: fix gcc9 error address-of-packed-member

2019-04-09 Thread Michael Chang
Change the le_to_cpu16_copy function to use void* type as its second argument to silence the warning. The pointer is later type casted to grub_uint16_t* and use grub_get_unaligned16 for safely deferencing it for the value. The solved gcc9 error like this. [ 60s] ../grub-core/fs/jfs.c: In functi

[PATCH 7/8] chainloader: fix gcc9 error address-of-packed-member

2019-04-09 Thread Michael Chang
Copy the packed member fp->path_name to the buffer path_name returned by grub_malloc, which is supposed to be suitably aligned for any data type and use path_name as argument to grub_utf8_to_utf16. After the function grub_utf8_to_utf16 returns, copy the content of path_name back to fp->path_name.

[PATCH 5/8] acpi: fix gcc9 error address-of-packed-member

2019-04-09 Thread Michael Chang
Add missing GRUB_PACKED attribute to struct grub_acpi_madt. The solved gcc9 error like this. [ 233s] ../../grub-core/commands/lsacpi.c: In function 'disp_acpi_xsdt_table': [ 233s] ../../grub-core/commands/lsacpi.c:201:27: error: converting a packed 'struct grub_acpi_table_header' pointer (alig

GRUB 2.04 RC01 released

2019-04-09 Thread Vladimir 'phcoder' Serbinenko
Hello all. GRUB maintainers team is proud to announce 2.04~rc1 that we have just released. We’re not aware of any of the release-critical bugs but we’re sure that there are some so we need your help finding them. We would like to thank to all the people who have contributed to the project. The

Re: [PATCH 0/8] fix gcc9 build with -Werror=address-of-packed-member

2019-04-09 Thread Vladimir 'phcoder' Serbinenko
On Tue, Apr 9, 2019 at 8:48 PM Michael Chang wrote: > > This patch set attempts to resolve the build failure in openSUSE build > service equipped with new gcc 9 compiler, which has added a new warning > flag -Waddress-of-packed-member. > > The new warning performs the check for taking the address

Re: [PATCH 0/8] fix gcc9 build with -Werror=address-of-packed-member

2019-04-09 Thread Michael Chang
On Tue, Apr 09, 2019 at 08:57:25PM +1000, Vladimir 'phcoder' Serbinenko wrote: > On Tue, Apr 9, 2019 at 8:48 PM Michael Chang wrote: > > > > This patch set attempts to resolve the build failure in openSUSE build > > service equipped with new gcc 9 compiler, which has added a new warning > > flag -

Re: [PATCH 0/8] fix gcc9 build with -Werror=address-of-packed-member

2019-04-09 Thread Vladimir 'phcoder' Serbinenko
On Tue, Apr 9, 2019 at 9:40 PM Michael Chang wrote: > > On Tue, Apr 09, 2019 at 08:57:25PM +1000, Vladimir 'phcoder' Serbinenko wrote: > > On Tue, Apr 9, 2019 at 8:48 PM Michael Chang wrote: > > > > > > This patch set attempts to resolve the build failure in openSUSE build > > > service equipped

Re: GRUB 2.04 RC01 released

2019-04-09 Thread Bruce Dubbs
On 4/9/19 5:53 AM, Vladimir 'phcoder' Serbinenko wrote: Hello all. GRUB maintainers team is proud to announce 2.04~rc1 that we have just released. We’re not aware of any of the release-critical bugs but we’re sure that there are some so we need your help finding them. The tarball is available

Re: GRUB 2.04 RC01 released

2019-04-09 Thread John Paul Adrian Glaubitz
Hi! On 4/9/19 12:53 PM, Vladimir 'phcoder' Serbinenko wrote: > Hello all. GRUB maintainers team is proud to announce 2.04~rc1 that we > have just released. > > We’re not aware of any of the release-critical bugs but we’re sure > that there are some so we need your help finding them. Compile-teste

Re: GRUB 2.04 RC01 released

2019-04-09 Thread Christian Hesse
"Vladimir 'phcoder' Serbinenko" on Tue, 2019/04/09 20:53: > Hello all. GRUB maintainers team is proud to announce 2.04~rc1 that we > have just released. > > We’re not aware of any of the release-critical bugs but we’re sure > that there are some so we need your help finding them. Built an Arch L

Re: [RFC] arm64/linux/loader: Use EFI CODE allocations for the linux kernel

2019-04-09 Thread Ard Biesheuvel
On Mon, 8 Apr 2019 at 02:56, Leif Lindholm wrote: > > On Mon, Apr 08, 2019 at 12:19:05PM +0300, Alexander Graf wrote: > > On 05.04.19 06:06, Leif Lindholm wrote: > > > This does bring to mind the clunkiness of the above. Marking > > > *everything* executable bypasses the improved security provided

Re: [PATCH 0/8] fix gcc9 build with -Werror=address-of-packed-member

2019-04-09 Thread Michael Chang
On Tue, Apr 09, 2019 at 10:15:33PM +1000, Vladimir 'phcoder' Serbinenko wrote: > On Tue, Apr 9, 2019 at 9:40 PM Michael Chang wrote: > > > > On Tue, Apr 09, 2019 at 08:57:25PM +1000, Vladimir 'phcoder' Serbinenko > > wrote: > > > On Tue, Apr 9, 2019 at 8:48 PM Michael Chang wrote: > > > > > > >