Re: [PATCH 1/1] Upgrade Gnulib; switch to bootstrap tool

2019-01-17 Thread Paul Menzel
Dear Colin, On 01/09/19 13:29, Colin Watson wrote: > Upgrade Gnulib files to 20190105. > > It's much easier to maintain GRUB's use of portability support files > from Gnulib when the process is automatic and driven by a single > configuration file, rather than by maintainers occasionally running

Re: [PATCH v4 00/10] Add RISC-V support

2019-01-17 Thread Daniel Kiper
Hey, Sorry for late reply but I was not able to review the patches due to other important work and holiday season. Now I am taking a stab at it and I hope that it will land soon in the GRUB git tree. On Mon, Nov 26, 2018 at 12:38:05AM +0100, Alexander Graf wrote: > As part of the plan for total w

Re: [PATCH v4 01/10] efi: Rename armxx to arch

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:06AM +0100, Alexander Graf wrote: > Some architectures want to boot Linux as plain UEFI binary. Today that > really only encompasses ARM and AArch64, but going forward more > architectures may adopt that model. > > So rename our internal API accordingly. > > Signed-off

Re: [PATCH v4 02/10] PE: Add RISC-V definitions

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:07AM +0100, Alexander Graf wrote: > The PE format defines magic numbers as well as relocation identifiers for > RISC-V. Add them to our include file, so we can make use of them. > > Signed-off-by: Alexander Graf > Reviewed-by: Leif Lindholm > Reviewed-by: Alistair Fr

Re: [PATCH v4 03/10] elf.h: Add RISC-V definitions

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:08AM +0100, Alexander Graf wrote: > The RISC-V ABI document outlines ELF header structure and relocation > information. Pull the respective magic numbers into our elf header > so we can make use of them. > > Signed-off-by: Alexander Graf > Reviewed-by: Alistair Franci

Re: [PATCH v4 04/10] RISC-V: Add setjmp implementation

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:09AM +0100, Alexander Graf wrote: > This patch adds a 32/64 capable setjmp implementation for RISC-V. > > Signed-off-by: Alexander Graf > Reviewed-by: Alistair Francis > Reviewed-by: Bin Meng > Tested-by: Bin Meng Reviewed-by: Daniel Kiper However, one nit pick

Re: [PATCH v4 05/10] RISC-V: Add early startup code

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:10AM +0100, Alexander Graf wrote: > On entry, we need to save the system table pointer as well as our image > handle. Add an early startup file that saves them and then brings us > into our main function. > > Signed-off-by: Alexander Graf > Reviewed-by: Alistair Franc

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:11AM +0100, Alexander Graf wrote: > We currently only support to run grub on RISC-V as UEFI payload. Ideally, > we also only want to support running Linux underneath as UEFI payload. > > Prepare that with a Linux boot case that is not enabled in Linux yet. At > least i

Re: [PATCH v4 07/10] RISC-V: Add awareness for RISC-V reloations

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:12AM +0100, Alexander Graf wrote: > This patch adds awareness of RISC-V relocations throughout the grub tools > as well as dynamic linkage and elf->PE relocation conversion support. > > Signed-off-by: Alexander Graf Except two nitpicks Reviewed-by: Daniel Kiper >

Re: [PATCH v4 08/10] RISC-V: Add auxiliary files

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:13AM +0100, Alexander Graf wrote: > To support a new architecture we need to provide a few helper functions > for memory, cache, timer, etc support. > > This patch adds the remainders of those. Some bits are still disabled, > as I couldn't guarantee that we're always r

Re: [PATCH v4 09/10] RISC-V: Add to build system

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:14AM +0100, Alexander Graf wrote: > This patch adds support for RISC-V to the grub build system. With this > patch, I can successfully build grub on RISC-V as a UEFI application. > > Signed-off-by: Alexander Graf > Reviewed-by: Alistair Francis > Reviewed-by: Bin Men

Re: [PATCH v4 10/10] fdt: Treat device tree file type like ACPI

2019-01-17 Thread Daniel Kiper
On Mon, Nov 26, 2018 at 12:38:15AM +0100, Alexander Graf wrote: > We now have signature check logic in grub which allows us to treat > files differently depending on their file type. > > Treat a loaded device tree like an overlayed ACPI table. > Both describe hardware, so I suppose their threat lev

Re: [PATCH v4 06/10] RISC-V: Add Linux load logic

2019-01-17 Thread Leif Lindholm
On Thu, Jan 17, 2019 at 01:24:29PM +0100, Daniel Kiper wrote: > > +static grub_err_t > > +finalize_params_linux (void) > > +{ > > + int node, retval; > > + > > Please drop this empty line. > > > + void *fdt; > > + > > + fdt = grub_fdt_load (0x400); > > Why this number? Please define constant