Re: [PATCH] linux16 module: code cleanup

On Tue, Aug 07, 2018 at 02:57:53PM +0800, Cao jin wrote: > 1. move relocator related code more close to each other > 2. use variable "len" since it has correct assignment, and keep coding > style with upper code > > Signed-off-by: Cao jin Reviewed-by: Daniel Kiper Daniel __

Re: [PATCH] relocator16.S: comments update

On Tue, Aug 14, 2018 at 03:03:25PM +0800, Cao jin wrote: > Signed-off-by: Cao jin Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v2] ofnet: Initialize structs in bootpath parser

On Mon, Sep 03, 2018 at 10:09:15AM +0200, Julian Andres Klode wrote: > Code later on checks if variables inside the struct are > 0 to see if they have been set, like if there were addresses > in the bootpath. > > The variables were not initialized however, so the check > might succeed with uninitia

Re: [PATCH] grub-probe: Sort lists of enums and targets

On Fri, Aug 31, 2018 at 10:15:20AM -0700, Elliott Mitchell wrote: > This makes it distinctly easier to find things in these tables. Both for > humans trying to add entries, and for computers trying to find entries. This patch does more then commit message says. So, please improve the commit messa

Re: [PATCH] grub-reboot: Warn when "for the next boot only" promise cannot be kept

On Fri, Aug 17, 2018 at 05:33:44PM -0600, dann frazier wrote: > The "for the next boot only" property of grub-reboot is dependent upon > GRUB being able to clear the next_entry variable in the environment > block. However, GRUB cannot write to devices using the diskfilter > and lvm abstractions. >

Re: [PATCH] ahci: Increase time-out from 10 s to 32 s

On Thu, Aug 09, 2018 at 06:10:51PM +0200, Paul Menzel wrote: > Date: Thu, 9 Aug 2018 07:27:35 +0200 > > Currently, the GRUB payload for coreboot does not detect the Western > Digital hard disk WDC WD20EARS-60M AB51 connected to the ASRock E350M1, > as that takes over ten seconds to spin up. > > ```

Re: [PATCH] tests: Fix qemu options for UHCI test

On Mon, Jul 30, 2018 at 12:37:42PM +0100, Colin Watson wrote: > qemu 2.12 removed the -usbdevice option. Use a more modern spelling > instead, in line with other USB-related tests. > > Signed-off-by: Colin Watson Reviewed-by: Daniel Kiper Daniel ___

Re: [PATCH] tests: Disable sercon in SeaBIOS

On Mon, Jul 30, 2018 at 12:37:22PM +0100, Colin Watson wrote: > SeaBIOS 1.11.0 added support for VGA emulation over a serial port, which > interferes with grub-shell. Turn it off. > > Signed-off-by: Colin Watson Reviewed-by: Daniel Kiper Daniel ___

Re: [PATCH] hostdisk: Fix linux disk cache workaround on multipath disks

On Wed, Jul 25, 2018 at 04:49:15PM +0800, Michael Chang wrote: > In hostdisk.c::grub_util_fd_open_device, there's a workaround to linux disk s#hostdisk.c::grub_util_fd_open_device#grub-core/osdep/linux/hostdisk.c:grub_util_fd_open_device()# > cache described below. > > "Linux has a bug that the d

Re: [PATCH v2] ieee1275: obdisk driver

> On Sep 1, 2018, at 11:10 AM, Daniel Kiper wrote: > > On Thu, Aug 30, 2018 at 09:28:52AM -0600, Eric Snowberg wrote: >>> On Aug 30, 2018, at 8:06 AM, Daniel Kiper wrote: >>> On Tue, Jul 17, 2018 at 09:59:33AM -0600, Eric Snowberg wrote: > On Jul 17, 2018, at 7:38 AM, Daniel Kiper wrote: >

grub-mkrescue: Option --core-compress is in help text but not recognized

Hi, on occasion of https://unix.stackexchange.com/questions/466495 i wonder whether it is a mistake that grub-mkrescue option --core-compress= is declared in include/grub/util/install.h, or whether it is a mistake that there is no code to see anywhere which would recognize the associated key GRU

Re: grub-mkrescue: Option --core-compress is in help text but not recognized

Hi, can it be that in commit f23bc65103d045f899f02ade6dd9d1f964cdb707 "Transform -C option to grub-mkstandalone to --core-compress available" it was forgotten to change the old 'C' to GRUB_INSTALL_OPTIONS_INSTALL_CORE_COMPRESS in grub_install_parse() of util/grub-install-common.c ? At least the