Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-06-14 Thread Daniel Kiper
On Sun, Jun 03, 2018 at 08:53:40PM +0200, Goffredo Baroncelli wrote: > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 70 > 1 file changed, 70 insertions(+) > > diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c > index be19544

Re: [PATCH 2/9] btrfs: Add helper to check the btrfs header.

2018-06-14 Thread Daniel Kiper
On Sun, Jun 03, 2018 at 08:53:41PM +0200, Goffredo Baroncelli wrote: > This helper will be used in a few places to help the debugging. As > conservative approach, in case of error it is only logged. This is s/, in case of error it/ the error/ > because I am not sure if this can change something i

Re: [PATCH 3/9] btrfs: Move the error logging from find_device() to its caller.

2018-06-14 Thread Daniel Kiper
On Sun, Jun 03, 2018 at 08:53:42PM +0200, Goffredo Baroncelli wrote: > This is a preparatory patch. The caller knows better if this > error is fatal or not, i.e. another disk is available or not. Please make first sentence last one in separate line. The same applies to other patches. Otherwise LG

Re: Fwd: [PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found.

2018-06-14 Thread Daniel Kiper
On Mon, Jun 04, 2018 at 09:26:06PM +0200, Goffredo Baroncelli wrote: > Resend this patch because I am not sure that all received it. It looks that #4 is a bit unfortunate for you and/or patch series... :-))) > BR > G.Baroncelli > > > Forwarded Message > Subject: [PATCH 4/9] btrf

Re: [PATCH 5/9] btrfs: Move logging code in grub_btrfs_read_logical()

2018-06-14 Thread Daniel Kiper
On Sun, Jun 03, 2018 at 08:53:44PM +0200, Goffredo Baroncelli wrote: > A portion of the logging code is moved outside of internal for(;;). The part > that is left inside is the one which depends by the internal for(;;) index. s/depends by/depends on/ > This is a preparatory patch: in the next one

Re: [PATCH 6/9] btrfs: Refactor the code that read from disk

2018-06-14 Thread Daniel Kiper
On Sun, Jun 03, 2018 at 08:53:45PM +0200, Goffredo Baroncelli wrote: > Move the code in charge to read the data from disk in a separate s/in a/into a/ > function. This helps to separate the error handling logic (which depend by s/depend by/depends on/ Please fix this here and in other patches to

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-06-14 Thread Daniel Kiper
On Sun, Jun 03, 2018 at 08:53:46PM +0200, Goffredo Baroncelli wrote: > Add support for recovery fo a RAID 5 btrfs profile. In addition s/fo /for / > it is added some code as preparatory work for RAID 6 recovery code. > > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs/btrfs.c | 180

Re: [PATCH 9/9] btrfs: Add RAID 6 recovery for a btrfs filesystem.

2018-06-14 Thread Daniel Kiper
On Sun, Jun 03, 2018 at 08:53:48PM +0200, Goffredo Baroncelli wrote: > Add the RAID 6 recovery, in order to use a RAID 6 filesystem even if some > disks (up to two) are missing. This code use the md RAID 6 code already > present in grub. > > Signed-off-by: Goffredo Baroncelli > --- > grub-core/fs

Re: [PATCH V5] Add support for BTRFS raid5/6 to GRUB

2018-06-14 Thread Daniel Kiper
Hi Goffredo, On Sun, Jun 03, 2018 at 08:53:39PM +0200, Goffredo Baroncelli wrote: > > Hi All, > > the aim of this patches set is to provide support for a BTRFS raid5/6 > filesystem in GRUB. > > The first patch, implements the basic support for raid5/6. I.e this works when > all the disks are prese

Re: [PATCH 0/2] efi/fdt: set #address-cells/#size-cells on empty tree

2018-06-14 Thread Daniel Kiper
On Mon, Jun 11, 2018 at 05:24:57PM +0100, Leif Lindholm wrote: > Set #address-cells and #size-cells properties (to 2) for ARM*/UEFI > systems when creating an empty DT at boot time. This resolves an issue > seen in the wild with kexec on certain 64-bit ARM systems. > > First part is moving out the

Re: [PATCH 0/2] efi/fdt: set #address-cells/#size-cells on empty tree

2018-06-14 Thread Leif Lindholm
On Thu, Jun 14, 2018 at 03:38:13PM +0200, Daniel Kiper wrote: > On Mon, Jun 11, 2018 at 05:24:57PM +0100, Leif Lindholm wrote: > > Set #address-cells and #size-cells properties (to 2) for ARM*/UEFI > > systems when creating an empty DT at boot time. This resolves an issue > > seen in the wild with

Re: [PATCH V5] Add support for BTRFS raid5/6 to GRUB

2018-06-14 Thread Goffredo Baroncelli
On 06/14/2018 03:21 PM, Daniel Kiper wrote: > Hi Goffredo, > > On Sun, Jun 03, 2018 at 08:53:39PM +0200, Goffredo Baroncelli wrote: >> >> Hi All, >> >> the aim of this patches set is to provide support for a BTRFS raid5/6 >> filesystem in GRUB. >> >> The first patch, implements the basic support f

Re: Fwd: [PATCH 4/9] btrfs: Avoid a rescan for a device which was already not found.

2018-06-14 Thread Goffredo Baroncelli
On 06/14/2018 01:45 PM, Daniel Kiper wrote: > On Mon, Jun 04, 2018 at 09:26:06PM +0200, Goffredo Baroncelli wrote: >> Resend this patch because I am not sure that all received it. > > It looks that #4 is a bit unfortunate for you and/or patch series... :-))) Yes, but I have another suspect: the p

[PATCH v4] mbi: use per segment a separate relocator chunk

2018-06-14 Thread Alexander Boettcher
-- Alexander Boettcher Genode Labs http://www.genode-labs.com - http://www.genode.org Genode Labs GmbH - Amtsgericht Dresden - HRB 28424 - Sitz Dresden Geschäftsführer: Dr.-Ing. Norman Feske, Christian Helmuth >From b63e9760de70f83e4d8dd2e06d766e2de0135ff9 Mon Sep 17 00:00:00 2001 From: Alexande

Re: [PATCH 1/9] btrfs: Add support for reading a filesystem with a RAID 5 or RAID 6 profile.

2018-06-14 Thread Goffredo Baroncelli
On 06/14/2018 01:17 PM, Daniel Kiper wrote: > On Sun, Jun 03, 2018 at 08:53:40PM +0200, Goffredo Baroncelli wrote: >> Signed-off-by: Goffredo Baroncelli >> --- >> grub-core/fs/btrfs.c | 70 >> 1 file changed, 70 insertions(+) >> >> diff --git a/grub-co

Re: [PATCH 7/9] btrfs: Add support for recovery for a RAID 5 btrfs profiles.

2018-06-14 Thread Goffredo Baroncelli
On 06/14/2018 03:03 PM, Daniel Kiper wrote: > On Sun, Jun 03, 2018 at 08:53:46PM +0200, Goffredo Baroncelli wrote: >> Add support for recovery fo a RAID 5 btrfs profile. In addition > > s/fo /for / > >> it is added some code as preparatory work for RAID 6 recovery code. >> >> Signed-off-by: Goffr