Re: [GRUB PARTUUID PATCH V8 3/4] Add PARTUUID detection support to grub-probe

2018-04-04 Thread Daniel Kiper
On Wed, Mar 28, 2018 at 08:32:53AM -0700, Nicholas Vinson wrote: > Add PARTUUID detection support grub-probe for MBR and GPT partition > schemes. > > Signed-off-by: Nicholas Vinson Reviewed-by: Daniel Kiper Daniel ___ Grub-devel mailing list Grub-dev

Re: [PATCH] F2FS support

2018-04-04 Thread Daniel Kiper
On Thu, Mar 29, 2018 at 05:08:42PM +0100, Pete Batard wrote: > Hi Daniel, > > Thanks for reviewing the patch. > Here's a v2 that takes your comments into account. Thanks, LGTM +/- some nitpicks which I fix before committing. If there are no significant objections I will apply this patch in a week

Re: [GRUB PARTUUID PATCH V8 4/4] Update grub script template files

2018-04-04 Thread Daniel Kiper
On Wed, Mar 28, 2018 at 08:32:54AM -0700, Nicholas Vinson wrote: > Update grub-mkconfig.in and 10_linux.in to support grub-probe's new > partuuid target. Update grub.texi documenation. > > Signed-off-by: Nicholas Vinson > --- > docs/grub.texi | 9 + > util/grub-mkconfig.in |

Re: [PATCH] F2FS support

2018-04-04 Thread Daniel Kiper
On Sat, Mar 31, 2018 at 10:47:29PM +0200, Paul Menzel wrote: > Dear Pete, > > Am Donnerstag, den 29.03.2018, 17:08 +0100 schrieb Pete Batard: > > Thanks for reviewing the patch. > > Here's a v2 that takes your comments into account. > > Could you please make the commit message title a statement by

Re: [PATCH] F2FS support

2018-04-04 Thread Pete Batard
On 2018.04.04 21:37, Daniel Kiper wrote: Thanks, LGTM +/- some nitpicks which I fix before committing. If there are no significant objections I will apply this patch in a week or so. Thanks Daniel. Much appreciated. Regards, /Pete ___ Grub-devel ma

Re: [GRUB PARTUUID PATCH V8 4/4] Update grub script template files

2018-04-04 Thread Nick Vinson
On 04/04/2018 01:23 PM, Daniel Kiper wrote: > On Wed, Mar 28, 2018 at 08:32:54AM -0700, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documenation. >> >> Signed-off-by: Nicholas Vinson >> --- >> docs/grub.texi