Re: [PATCH] ieee1275: NULL pointer dereference in grub_machine_get_bootlocation

2018-03-22 Thread Daniel Kiper
On Wed, Mar 14, 2018 at 08:51:17AM -0700, Eric Snowberg wrote: > Read from NULL pointer canon in function grub_machine_get_bootlocation. > Function grub_ieee1275_canonicalise_devname may return NULL. > > Signed-off-by: Eric Snowberg Reviewed-by: Daniel Kiper Daniel

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-22 Thread Daniel Kiper
Hi John, On Wed, Mar 14, 2018 at 07:00:11PM +, John Lane wrote: > On 14/03/18 13:05, Daniel Kiper wrote: > > On Wed, Mar 14, 2018 at 09:44:58AM +, John Lane wrote: > >> From: John Lane > > > > I have just skimmed through the series. First of all, most if not > > all patches beg for full b

Re: [GRUB PARTUUID PATCH V6 1/4] Centralize guid prints

2018-03-22 Thread Daniel Kiper
On Sun, Mar 18, 2018 at 12:06:00PM -0700, Nicholas Vinson wrote: > Define print_gpt_guid(), so there is a central function for printing > GUID strings. This change is a precursor for later patches which rely > on this logic. > > Signed-off-by: Nicholas Vinson Reviewed-by: Daniel Kiper Daniel

Re: [GRUB PARTUUID PATCH V6 2/4] Update grub_gpt_partentry

2018-03-22 Thread Daniel Kiper
On Sun, Mar 18, 2018 at 12:06:01PM -0700, Nicholas Vinson wrote: > Rename grub_gpt_part_type to grub_gpt_part_guid and update > grub_gpt_partentry to use this type for both the partition type GUID > string and the partition GUID string entries. This change ensures that > the two GUID fields are ha

Re: [GRUB PARTUUID PATCH V6 3/4] Add PARTUUID detection support to grub-probe

2018-03-22 Thread Daniel Kiper
On Sun, Mar 18, 2018 at 12:06:02PM -0700, Nicholas Vinson wrote: > Add PARTUUID detection support grub-probe for MBR and GPT partition > schemes. > > Signed-off-by: Nicholas Vinson > --- > util/grub-probe.c | 51 +++ > 1 file changed, 51 insertions(

Re: [GRUB PARTUUID PATCH V6 4/4] Update grub script template files

2018-03-22 Thread Daniel Kiper
On Sun, Mar 18, 2018 at 12:06:03PM -0700, Nicholas Vinson wrote: > Update grub-mkconfig.in and 10_linux.in to support grub-probe's new > partuuid target. Update grub.texi documenation. > > Signed-off-by: Nicholas Vinson > --- > docs/grub.texi | 9 + > util/grub-mkconfig.in |

Re: [PATCH] Fix packed-not-aligned error on GCC 8

2018-03-22 Thread Daniel Kiper
Hi, Paul, does this patch work for you? Michael, if it does please repost with your SOB and Tested-by: lines. Daniel On Wed, Mar 21, 2018 at 05:44:47PM +0800, Michael Chang wrote: > Here just came up with a patch that fixed the GCC 8 error for me. :) Would you > test it work for you as well ? >

Re: [PATCHv2] os-prober: Fix translating device to mach format

2018-03-22 Thread Daniel Kiper
On Wed, Mar 14, 2018 at 02:14:08PM +0100, Samuel Thibault wrote: > grub-probe --device /dev/sda --target=drive > > would currently print on Linux x86 "hostdisk//dev/sda,msdos1", i.e. not I have a feeling that grub-probe should be fixed instead of that. Probably it was broken at some point because

Re: [PATCH 1/7] Cryptomount support LUKS detached header

2018-03-22 Thread TJ
On 22/03/18 12:38, Daniel Kiper wrote: > Hi John, > > On Wed, Mar 14, 2018 at 07:00:11PM +, John Lane wrote: >> On 14/03/18 13:05, Daniel Kiper wrote: >>> On Wed, Mar 14, 2018 at 09:44:58AM +, John Lane wrote: From: John Lane >>> >>> I have just skimmed through the series. First of a

Re: [PATCH] F2FS support

2018-03-22 Thread Daniel Kiper
On Sun, Mar 18, 2018 at 08:39:45PM +, Pete Batard wrote: > +1 for F2FS integration, which I also requested a few months back and > which I know has also been requested by other people before that. > > While I understand that the GRUB project's priorities might be > elsewhere, I'm just going to

[PATCH] F2FS support

2018-03-22 Thread Pete Batard
Hi, Please find attached a rebased version of the F2FS patch sent by Jaegeuk Kim to this mailing list on 2017.05.04. The original patch was rebased against the latest mainline and we also validated that there were no compilation issues on a Debian 9 x64 platform. Here are the notes from the

Re: [PATCHv2] os-prober: Fix translating device to mach format

2018-03-22 Thread Samuel Thibault
Daniel Kiper, on jeu. 22 mars 2018 15:16:46 +0100, wrote: > On Wed, Mar 14, 2018 at 02:14:08PM +0100, Samuel Thibault wrote: > > @@ -297,8 +297,8 @@ menuentry '$(echo "${LONGNAME} $onstr" | grub_quote)' > > --class hurd --class gnu - > > EOF > >save_default_entry | grub_add_tab > >

Re: [GRUB PARTUUID PATCH V6 4/4] Update grub script template files

2018-03-22 Thread Nick Vinson
On 03/22/2018 06:56 AM, Daniel Kiper wrote: > On Sun, Mar 18, 2018 at 12:06:03PM -0700, Nicholas Vinson wrote: >> Update grub-mkconfig.in and 10_linux.in to support grub-probe's new >> partuuid target. Update grub.texi documenation. >> >> Signed-off-by: Nicholas Vinson >> --- >> docs/grub.texi

Re: [GRUB PARTUUID PATCH V6 3/4] Add PARTUUID detection support to grub-probe

2018-03-22 Thread Nick Vinson
On 03/22/2018 06:51 AM, Daniel Kiper wrote: > On Sun, Mar 18, 2018 at 12:06:02PM -0700, Nicholas Vinson wrote: >> Add PARTUUID detection support grub-probe for MBR and GPT partition >> schemes. >> >> Signed-off-by: Nicholas Vinson >> --- >> util/grub-probe.c | 51 +