Re: [PATCH] ahci: Improve error handling

Dear Stefan, Am Montag, den 29.01.2018, 13:16 +0100 schrieb Daniel Kiper: > On Tue, Jan 23, 2018 at 01:00:56PM +0100, Daniel Kiper wrote: > > On Fri, Jan 19, 2018 at 02:13:29PM +0100, Stefan Fritsch wrote: > > > From: Stefan Fritsch > > > > > > Check the error bits in the interrupt status regis

Re: [PATCH] ieee1275: split up grub_machine_get_bootlocation

On Wed, Mar 07, 2018 at 01:48:10PM -0800, Eric Snowberg wrote: > Split up some of the functionality in grub_machine_get_bootlocation into > grub_ieee1275_get_boot_dev. This will allow for code reuse in a follow on > patch. I would like to see follow up patches in such cases like that one. > Sign

Re: [PATCH v2] grub-install: locale depends on nls

On Wed, Mar 07, 2018 at 10:54:28PM +0100, Olaf Hering wrote: > Am Wed, 7 Mar 2018 22:30:53 +0100 > schrieb Daniel Kiper : > > > Sorry, I do not like it. Please use "__attribute__ ((unused))" for the > > function > > arguments and put #if/#endif around its whole body. > > It is not just this functi

Re: [PATCH] ieee1275: split up grub_machine_get_bootlocation

> On Mar 8, 2018, at 4:19 AM, Daniel Kiper wrote: > > On Wed, Mar 07, 2018 at 01:48:10PM -0800, Eric Snowberg wrote: >> Split up some of the functionality in grub_machine_get_bootlocation into >> grub_ieee1275_get_boot_dev. This will allow for code reuse in a follow on >> patch. > > I would li

Re: [PATCH] ieee1275: split up grub_machine_get_bootlocation

On Thu, Mar 08, 2018 at 08:42:14AM -0700, Eric Snowberg wrote: > > > On Mar 8, 2018, at 4:19 AM, Daniel Kiper wrote: > > > > On Wed, Mar 07, 2018 at 01:48:10PM -0800, Eric Snowberg wrote: > >> Split up some of the functionality in grub_machine_get_bootlocation into > >> grub_ieee1275_get_boot_dev.