Re: [PATCH 2/2] Core TPM support

2017-07-21 Thread Javier Martinez Canillas
On 07/05/2017 11:19 PM, Matthew Garrett wrote: > Add support for performing basic TPM measurements. Right now this only > supports extending PCRs statically and only on UEFI. > --- [snip] > +grub_err_t grub_tpm_init(void); You forgot to remove this function prototype, since the function doesn't

Re: Add TPM measured boot support

2017-07-21 Thread Javier Martinez Canillas
Hello Matthew, On 07/21/2017 12:41 AM, Matthew Garrett wrote: > On Wed, Jul 05, 2017 at 02:19:55PM -0700, Matthew Garrett wrote: >> This patchset extends the verifier framework to support verifying commands >> executed by Grub, and makes use of this to add support for measuring files >> and comman

Re: Add TPM measured boot support

2017-07-21 Thread Daniel Kiper
On Thu, Jul 20, 2017 at 11:41:11PM +0100, Matthew Garrett wrote: > On Wed, Jul 05, 2017 at 02:19:55PM -0700, Matthew Garrett wrote: > > This patchset extends the verifier framework to support verifying commands > > executed by Grub, and makes use of this to add support for measuring files > > and c

Re: [PATCH 1/2] Verify commands executed by grub

2017-07-21 Thread Javier Martinez Canillas
On 07/05/2017 11:19 PM, Matthew Garrett wrote: > Pass commands to the verification code. We want to be able to log these > in the TPM verification case. > --- > grub-core/script/execute.c | 27 --- > include/grub/verify.h | 1 + > 2 files changed, 25 insertions(+), 3

Re: [PATCH 1/2] Verify commands executed by grub

2017-07-21 Thread Vladimir 'phcoder' Serbinenko
On Wed, Jul 5, 2017, 23:26 Matthew Garrett wrote: > Pass commands to the verification code. We want to be able to log these > in the TPM verification case. > --- > grub-core/script/execute.c | 27 --- > include/grub/verify.h | 1 + > 2 files changed, 25 insertions(+

Re: [PATCH 1/2] Verify commands executed by grub

2017-07-21 Thread Matthew Garrett
On Fri, Jul 21, 2017 at 7:39 AM, Vladimir 'phcoder' Serbinenko wrote: > This omits all separators. So it considers e.g. ab and a b to be the same. > Can we have a better array serialization? I.a. following 3 need to be > distinguished: > ab > a b > "a b" It inserts a space after each argv, so I t