Re: [coreboot] RFC: Changing CBMEM console to run as a persistent ring-buffer

2017-04-25 Thread Julius Werner
> > I'm very concerned with compatibility. You can't guarantee that coreboot > and payload match. And in case of mismatch you get a memory corruption that > is very hard to trace. Can we please change signature of cbmem entry? I would rather allow older implementations to continue working as best

Re: [coreboot] RFC: Changing CBMEM console to run as a persistent ring-buffer

2017-04-25 Thread Vladimir 'phcoder' Serbinenko
On Tue, Apr 25, 2017, 20:15 Julius Werner wrote: > I'm very concerned with compatibility. You can't guarantee that coreboot >> and payload match. And in case of mismatch you get a memory corruption that >> is very hard to trace. Can we please change signature of cbmem entry? > > > I would rather

Re: [coreboot] RFC: Changing CBMEM console to run as a persistent ring-buffer

2017-04-25 Thread Julius Werner
> > Did you check that all implementations use unsigned? > Yes, all the ones that I'm now aware of used unsigned, 32-bit. > I am able to build it, I just had to figure out how and install some >> dependencies. But I tried booting it on an HP Chromebook 14 2013 (falco) >> and it doesn't seem to r

Re: [coreboot] RFC: Changing CBMEM console to run as a persistent ring-buffer

2017-04-25 Thread Julius Werner
Managed to get it working with serial input now. Found a few issues with my patch. Will send a new, tested version out. On Tue, Apr 25, 2017 at 11:48 AM, Julius Werner wrote: > Did you check that all implementations use unsigned? >> > > Yes, all the ones that I'm now aware of used unsigned, 32-b

[PATCH v2] grub-core/term/i386/coreboot/cbmemc.c: Update console format

2017-04-25 Thread Julius Werner
Changed cbmemc to support updated console format from coreboot. --- grub-core/term/i386/coreboot/cbmemc.c | 50 --- 1 file changed, 35 insertions(+), 15 deletions(-) diff --git a/grub-core/term/i386/coreboot/cbmemc.c b/grub-core/term/i386/coreboot/cbmemc.c index 2