Re: Unreachable code in mkimagexx (Fwd: New Defects reported by Coverity Scan for GRUB)

2016-03-14 Thread Andrei Borzenkov
On Sun, Mar 13, 2016 at 10:38 AM, Andrei Borzenkov wrote: > > We probably need to #ifdef this section for MKIMAGE_ELF64 case only, it > makes no sense to compile it for 32 bit target. > Hmm ... why translate_relocation_pe, translate_relocation_raw and classify_raw_reloc are not target size specif

Re: [GRUB2 PATCH v3 4/4] multiboot2: Add support for relocatable images

2016-03-14 Thread Daniel Kiper
On Fri, Mar 11, 2016 at 05:13:19PM +0100, Vladimir 'phcoder' Serbinenko wrote: > > > > + if (relocatable) > > > > +{ > > > > + if (base_addr > min_addr) > > > > + grub_multiboot_payload_eip += base_addr - min_addr; > > > > + else > > > > + grub_multiboot_payload_eip -= mi

Re: Bugs and tasks for 2.02[~rc1]

2016-03-14 Thread Matt Fleming
On Fri, 11 Mar, at 04:51:52PM, Vladimir 'phcoder' Serbinenko wrote: > > I'm ok with switching to EFI entry point for EFI platforms if plain 32-bit > entry point stays available for platforms like coreboot. Can we agree on > this? Yes, the legacy 32-bit entry points won't be going anywhere. They w

2.02-beta3 remove attempt to free stack space and initialize variable before possible use

2016-03-14 Thread Aaron Luft
Please consider these improvements to 2.02-beta3. 1) Remove the variable "oldname" which is attempting to free stack space. 2) Initialize the value of mdnobj to silence the compiler warning In function 'grub_free', inlined from 'grub_iso9660_iterate_dir' at grub-core/fs/iso9660.c:764:15: grub-

Re: 2.02-beta3 remove attempt to free stack space and initialize variable before possible use

2016-03-14 Thread Andrei Borzenkov
14.03.2016 17:37, Aaron Luft пишет: > Please consider these improvements to 2.02-beta3. > 1) Remove the variable "oldname" which is attempting to free stack space. > 2) Initialize the value of mdnobj to silence the compiler warning > > In function 'grub_free', > inlined from 'grub_iso9660_iter

Re: [openbsd] 2.02-beta3: build fails - getroot.c:(.text+0x2b): undefined reference to `getrawpartition'

2016-03-14 Thread Jiri B
On Sun, Mar 13, 2016 at 08:41:27AM +0300, Andrei Borzenkov wrote: > > Well, I see something went wrong now with compressing a file: > > > > $ tar tzvf /home/jirib/openbsd/packages/amd64/all/grub-2.02-beta3.tgz | > > grep lzma_decompress > > -r-xr-xr-x 1 root bin 3904 Jan 1 1970

Re: [openbsd] 2.02-beta3: build fails - getroot.c:(.text+0x2b): undefined reference to `getrawpartition'

2016-03-14 Thread Andrei Borzenkov
14.03.2016 21:19, Jiri B пишет: > On Sun, Mar 13, 2016 at 08:41:27AM +0300, Andrei Borzenkov wrote: >>> Well, I see something went wrong now with compressing a file: >>> >>> $ tar tzvf /home/jirib/openbsd/packages/amd64/all/grub-2.02-beta3.tgz | >>> grep lzma_decompress >>> -r-xr-xr-x 1 root

Re: 2.02-beta3 remove attempt to free stack space and initialize variable before possible use

2016-03-14 Thread Aaron Luft
> On Mar 14, 2016, at 1:35 PM, Andrei Borzenkov wrote: > Yes, this is one correct. Please resend as attached patch generated by > "git format-patch" with suitable commit message. Do not expand tabs when > editing. > Ok, attaching the patch to this mail. > > Well ... it cannot really reach code