Re: [PATCH v3] F2FS support

2015-12-14 Thread Andrei Borzenkov
20.11.2015 00:28, Jaegeuk Kim пишет: > Hello, > > Change log from v2: > o Enhance the code quality suggested by Andrei > > Sorry for the long delay. > Could you please check this patch? > > Thank you so much, > Thank you for continuing to work on it! ... > + > +static inline int > +grub_gen

Re: Grub get and set efi variables

2015-12-14 Thread Ignat Korchagin
> Assuming uint8 remains - should not you check that variable size is exactly 1 > byte in this case? There are reports of a buggy firmware returning 4 bytes size for uint8 variables, however did not encounter them myself. > Do we really need unit8 at all? "hex" already provides exactly the same

Re: Grub get and set efi variables

2015-12-14 Thread Ignat Korchagin
Sorry, pasted wrong file. Here is the correct one: diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 0cc40bb..aa7b927 100644 --- a/grub-core/Makefile.core.def +++ b/grub-core/Makefile.core.def @@ -735,6 +735,12 @@ module = { }; module = { + name = efivar; + efi = co

Re: [PATCH v3 1/3] mkstandalone: add argument --fixed-time to override mtime of files

2015-12-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
> + fixed_time = -1; -1 is actually perfectly valid. Can we have a second boolean to avoid special-casing -1? signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/g

Re: [PATCH v3 3/3] Makefile/coreboot use SOURCE_DATE_EPOCH as time source if set

2015-12-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Looks good On 04.12.2015 19:32, Alexander Couzens wrote: > mkstandalone sets timestamps for files which can be overriden by a > fixed_timestamp. > This makes it possible to build reproducible builds for coreboot. > > To build a reproducible build of grub for coreboot do: > export SOURCE_DATE_EPOC

Re: [PATCH v3 2/3] mkrescue: add argument --fixed-time to get reproducible uuids

2015-12-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 04.12.2015 19:32, Alexander Couzens wrote: > The uuid generation is based on the time. > --- > util/grub-mkrescue.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > This breaks uniqueness assumptions for UUID and we use UUID to find the right disk, as it's not possibl

multiboot bootlocation

2015-12-14 Thread Andrei Borzenkov
Why table says "no" for multiboot? It actually supports passing partition, although with some limitation. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: multiboot bootlocation

2015-12-14 Thread Vladimir 'phcoder' Serbinenko
It reffered to i386-multiboot port, not starting i386-pc from multiboot Le 14 déc. 2015 5:48 PM, "Andrei Borzenkov" a écrit : > Why table says "no" for multiboot? It actually supports passing > partition, although with some limitation. > > ___ > Grub-de

Re: [f2fs-dev] [PATCH v3] F2FS support

2015-12-14 Thread Jaegeuk Kim
Thank you for the review. On Mon, Dec 14, 2015 at 11:28:26AM +0300, Andrei Borzenkov wrote: > 20.11.2015 00:28, Jaegeuk Kim пишет: > > Hello, > > > > Change log from v2: > > o Enhance the code quality suggested by Andrei > > > > Sorry for the long delay. > > Could you please check this patch? >

Re: [f2fs-dev] [PATCH v4] F2FS support

2015-12-14 Thread Jaegeuk Kim
Change log from v3: o add grub_test_bit_le() o fix label handling with utf16 o change some minor concerns -- >8 -- From 4ab813c29851113da04d9ca84670219434ee570e Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Tue, 17 Nov 2015 12:45:13 -0800 Subject: [PATCH] F2FS support "F2FS (Flash-Friendl

Re: [PATCH v2] Translate UEFI persistent memory type

2015-12-14 Thread Andrei Borzenkov
14.12.2015 03:41, Elliott, Robert (Persistent Memory) пишет: > Per the thread: > grub causing NVDIMMs to be treated as normal memory > > > Robert Elliott (3): > Translate UEFI persistent memory type > efiemu: Handle all reserved UEFI memory map types the same way > Bump version to 2.0