modules size in mkimage

2015-10-31 Thread Andrei Borzenkov
mkimage sets module size to aligned value; later it is used to actually process it which /may/ lead to inconsistency (as any comparison is against stored aligned size, not actual module size). Same applies to all other embedded types actually. The only one that does it right is pubkey. Just

[PATCH V2] mkimage: zero fill alignment space

2015-10-31 Thread Andrei Borzenkov
This did not cause real problem but is good for reproducible builds. I hit it with recent bootinfoscript that displays embedded config; I was puzzled by random garbage at the end. Prezero memory buffer used to assemble core.img. This makes individual memset redundant. Also ensure buffer is filled

Re: [Savannah-users] Anonymous commit (empty Author and Committer)

2015-10-31 Thread Andreas Schwab
Kaz Kylheku writes: > Nope. They will have a git in which that commit looks like their own > local work. *Someone* will inadvertently do a "git push" to blast out > their changes based on that deleted commit, thereby causing it to > reappear. Not if another one pushes something different in the

Re: [Savannah-users] Anonymous commit (empty Author and Committer)

2015-10-31 Thread Kaz Kylheku
On 30.10.2015 13:59, Lennart Sorensen wrote: I don't have non-fast-forward rights. Does someone from savannah-users have them? Could he just delete this commit? If you do that, then anyone that already did a pull after it went in will have a broken tree. Rather annoying. Nope. They will have

Re: [Savannah-users] Anonymous commit (empty Author and Committer)

2015-10-31 Thread Andrei Borzenkov
31.10.2015 10:02, Andreas Schwab пишет: Kaz Kylheku writes: Nope. They will have a git in which that commit looks like their own local work. *Someone* will inadvertently do a "git push" to blast out their changes based on that deleted commit, thereby causing it to reappear. Not if another on

Re: Anonymous commit (empty Author and Committer)

2015-10-31 Thread Andrei Borzenkov
30.10.2015 23:19, Vladimir 'φ-coder/phcoder' Serbinenko пишет: On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 30.10.2015 15:26, Andrei Borzenkov wrote: See http://git.savannah.gnu.org/cgit/grub.git/commit/?

Re: [Savannah-users] Anonymous commit (empty Author and Committer)

2015-10-31 Thread André Z . D . A .
> 30.10.2015 23:59, Lennart Sorensen пишет: > >> On Fri, Oct 30, 2015 at 09:19:19PM +0100, Vladimir 'φ-coder/phcoder' >> Serbinenko wrote: >> >>> On 30.10.2015 21:09, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>> On 30.10.2015 21:06, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >