Re: [PATCH v2 19/23] x86/efi: create new early memory allocator

2015-08-27 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > There is a problem with place_string() which is used as early memory > allocator. It gets memory chunks starting from start symbol and > going down. Sadly this does not work when Xen is loaded using multiboot2 > protocol because start lives on 1 MiB address. So,

Re: [PATCH v2 20/23] x86: add multiboot2 protocol support for EFI platforms

2015-08-27 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > Signed-off-by: Daniel Kiper For a patch of this size, no description at all seems rather problematic. > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -89,6 +89,13 @@ multiboot1_header_end: > 0, /* Number of the lines

Re: [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-27 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > Current early command line parser implementation in assembler > is very difficult to change to relocatable stuff using segment > registers. This requires a lot of changes in very weird and > fragile code. So, reimplement this functionality in C. This > way code w

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Jan Beulich
>>> On 20.07.15 at 16:29, wrote: > - %fs register is filled with segment descriptor which describes memory > region > with Xen image (it could be relocated or not); This is too fuzzy. Please be very precise which region it is that %fs is supposed to point to (so that reviewers have a chanc

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Daniel Kiper
On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: > >>> On 20.07.15 at 16:29, wrote: [...] > > /* Copy bootstrap trampoline to low memory, below 1MB. */ > > -mov $sym_phys(trampoline_start),%esi > > +lea sym_offset(trampoline_start)(%ebp),%esi > >

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Jan Beulich
>>> On 27.08.15 at 17:10, wrote: > On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: >> >>> On 20.07.15 at 16:29, wrote: >> > /* Copy bootstrap trampoline to low memory, below 1MB. */ >> > -mov $sym_phys(trampoline_start),%esi >> > +lea sym_offset(tramp

Fwd: LVM/BTRFS on LUKS unreadable

2015-08-27 Thread Klemens Nanni
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 - Forwarded Message Subject: LVM/BTRFS on LUKS unreadable Date: Mon, 17 Aug 2015 23:24:32 + From: Autoboot To: bug-g...@gnu.org Hello, GRUB 2.02~beta2 as of commit afd0f21b2027310fda52b00ac1b964041d39a363 used as autoboot pay

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Ben Hildred
On Thu, Aug 27, 2015 at 9:29 AM, Jan Beulich wrote: > >>> On 27.08.15 at 17:10, wrote: > > On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: > >> >>> On 20.07.15 at 16:29, wrote: > >> > /* Copy bootstrap trampoline to low memory, below 1MB. */ > >> > -mov $sym_ph

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Andrew Cooper
On 27/08/15 16:29, Jan Beulich wrote: On 27.08.15 at 17:10, wrote: >> On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: >> On 20.07.15 at 16:29, wrote: /* Copy bootstrap trampoline to low memory, below 1MB. */ -mov $sym_phys(trampoline_start),%es

Re: [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-27 Thread Jan Beulich
>>> On 27.08.15 at 20:04, wrote: > On 27/08/15 16:29, Jan Beulich wrote: > On 27.08.15 at 17:10, wrote: >>> On Thu, Aug 27, 2015 at 07:12:38AM -0600, Jan Beulich wrote: >>> On 20.07.15 at 16:29, wrote: > /* Copy bootstrap trampoline to low memory, below 1MB. */ > -