Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-11 Thread Konrad Rzeszutek Wilk
> +static void vga_parse(const char *cmdline, early_boot_opts_t *ebo) > +{ > +const char *c; > +int tmp; > +size_t la; > +static const char empty_chars_comma[] __text = " \n\r\t,"; > +static const char x[] __text = "x"; > +static const char vga[] __text = "vga="; > +stat

Re: [PATCH v2 20/23] x86: add multiboot2 protocol support for EFI platforms

2015-08-11 Thread Konrad Rzeszutek Wilk
> +run_bs: > +push%rax > +push%rdi > + > +/* Initialize BSS (no nasty surprises!). */ > +lea __bss_start(%rip),%rdi > +lea __bss_end(%rip),%rcx > +sub %rdi,%rcx > +shr $3,%rcx > +xor %eax,%eax > +rep

Re: [Xen-devel] [PATCH v2 22/23] x86: make Xen early boot code relocatable

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:17PM +0200, Daniel Kiper wrote: > Every multiboot protocol (regardless of version) compatible image must > specify its load address (in ELF or multiboot header). Multiboot protocol > compatible loader have to load image at specified address. However, there > is no guar

Re: [PATCH v2 23/23] x86: add multiboot2 protocol support for relocatable images

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:18PM +0200, Daniel Kiper wrote: > Add multiboot2 protocol support for relocatable images. Only GRUB2 > with relevant patches understands that feature. Older multiboot You may want to enumerate what those 'relevant' patches are. > protocol (regardless of version) comp

Re: [PATCH v2 1/6] gitignore: Ignore *.orig, *.rej and *.swp files

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:35:49PM +0200, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk but really - this is quite easy to review :-) > --- > .gitignore |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.gitignore b/.gitignore > index 18ab8

Re: [PATCH v2 4/6] multiboot2: Add tags used to pass ImageHandle to loaded image

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:35:52PM +0200, Daniel Kiper wrote: > Add tags used to pass ImageHandle to loaded image. It is used s/loaded image/loaded image if requested./ > by at least ExitBootServices() function. > > Signed-off-by: Daniel Kiper > --- > grub-core/loader/multiboot_mbi2.c | 46 >

Re: [PATCH v2 5/6] multiboot2: Add support for relocatable images

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:35:53PM +0200, Daniel Kiper wrote: This parts needs a bit of details I think. As in why can't the ELF note that is present in the binary be satisfied. Or under what conditions would the existing code not work? > Signed-off-by: Daniel Kiper > --- > grub-core/loader/i3

Re: [PATCH v2 6/6] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:35:54PM +0200, Daniel Kiper wrote: > Do not pass memory maps to image if it asked for EFI boot services. Maps are > usually invalid in that case and they can confuse potential user. Image should > get memory map itself just before ExitBootServices() call. Can we point to

Re: [PATCH v2 3/6] i386/relocator: Add grub_relocator64_efi relocator

2015-08-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:35:51PM +0200, Daniel Kiper wrote: > Add grub_relocator64_efi relocator. It will be used on EFI 64-bit platforms > when multiboot2 compatible image requests MULTIBOOT_TAG_TYPE_EFI_BS. Relocator > will set lower parts of %rax and %rbx accordingly to multiboot2 specificatio