Re: [PATCH 3/3] net: fix ipv6 routing

2015-08-10 Thread Josef Bacik
On 08/09/2015 10:58 AM, Andrei Borzenkov wrote: В Wed, 5 Aug 2015 14:36:39 -0400 Josef Bacik пишет: Currently we cannot talk to ipv6 addresses outside of our local link area because we don't setup our routes properly nor do we talk to the router properly. Currently net_ipv6_autoconf adds rout

Re: [PATCH 3/3] net: fix ipv6 routing

2015-08-10 Thread Andrei Borzenkov
On Mon, Aug 10, 2015 at 5:00 PM, Josef Bacik wrote: > On 08/09/2015 10:58 AM, Andrei Borzenkov wrote: >> >> В Wed, 5 Aug 2015 14:36:39 -0400 >> Josef Bacik пишет: >> >>> Currently we cannot talk to ipv6 addresses outside of our local link area >>> because we don't setup our routes properly nor do

Re: [PATCH v2 01/23] x86/boot: remove unneeded instruction

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 27, 2015 at 09:46:08PM +0200, Daniel Kiper wrote: > On Fri, Jul 24, 2015 at 12:22:57PM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Jul 20, 2015 at 04:28:56PM +0200, Daniel Kiper wrote: > > > Signed-off-by: Daniel Kiper > > > > Don't you use it in: > > > > /* Switch to low-memor

Re: [Xen-devel] [PATCH v2 04/23] x86/boot: call reloc() using cdecl calling convention

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:28:59PM +0200, Daniel Kiper wrote: > Suggested-by: Jan Beulich > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk > --- > xen/arch/x86/boot/head.S |4 +++- > xen/arch/x86/boot/reloc.c | 20 > 2 files changed, 19 insertions(+

Re: [Xen-devel] [PATCH v2 06/23] x86/boot: use %ecx instead of %eax

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:01PM +0200, Daniel Kiper wrote: > Use %ecx instead of %eax to store low memory upper limit from EBDA. > This way we do not wipe multiboot protocol identifier. It is needed > in reloc() to differentiate between multiboot (v1) and > multiboot2 protocol. > > Signed-off-b

Re: [Xen-devel] [PATCH v2 07/23] x86/boot/reloc: Rename some variables and rearrange code a bit

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:02PM +0200, Daniel Kiper wrote: > Rename mbi and mbi_old variables and rearrange code a bit to make s/mbi_old/mbi_in/ Perhaps you want to say: rename mbi_old with mbi_in, and mbi with mbi_out or better: Replace mbi with mbi_out and mbi_old with mbi_in and ... > i

Re: [Xen-devel] [PATCH v2 08/23] x86: add multiboot2 protocol support

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:03PM +0200, Daniel Kiper wrote: > Add multiboot2 protocol support. Alter min memory limit handling as we > now may not find it from either multiboot (v1) or multiboot2. > > This way we are laying the foundation for EFI + GRUB2 + Xen development. > > Signed-off-by: Da

Re: [Xen-devel] [PATCH v2 09/23] efi: create efi_enabled()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:04PM +0200, Daniel Kiper wrote: > We need more fine grained knowledge about EFI environment and check > for EFI platform and EFI loader separately to properly support > multiboot2 protocol. In general Xen loaded by this protocol uses > memory mappings and loaded module

Re: [Xen-devel] [PATCH v2 10/23] efi: build xen.gz with EFI code

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:05PM +0200, Daniel Kiper wrote: > Build xen.gz with EFI code. We need this to support multiboot2 > protocol on EFI platforms. > > If we wish to load not ELF file using multiboot (v1) or multiboot2 then > it must contain "linear" (or "flat") representation of code and

Re: [Xen-devel] [PATCH v2 11/23] efi: split out efi_init()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:06PM +0200, Daniel Kiper wrote: > ..which initializes basic EFI variables. We want to re-use this > code to support multiboot2 protocol on EFI platforms. > > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk > --- > v2 - suggestions/fixes: >- impro

Re: [Xen-devel] [PATCH v2 12/23] efi: split out efi_console_set_mode()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:07PM +0200, Daniel Kiper wrote: > ..which sets console mode. We want to re-use this > code to support multiboot2 protocol on EFI platforms. > > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk > --- > v2 - suggestions/fixes: >- improve commit mess

Re: [Xen-devel] [PATCH v2 13/23] efi: split out efi_get_gop()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:08PM +0200, Daniel Kiper wrote: > ..which gets pointer to GOP device. We want to re-use this > code to support multiboot2 protocol on EFI platforms. > > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk > --- > v2 - suggestions/fixes: >- improve co

Re: [Xen-devel] [PATCH v2 14/23] efi: split out efi_find_gop_mode()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:09PM +0200, Daniel Kiper wrote: > ..which finds suitable GOP mode. We want to re-use this > code to support multiboot2 protocol on EFI platforms. > > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk > --- > v2 - suggestions/fixes: >- improve commi

Re: [Xen-devel] [PATCH v2 15/23] efi: split out efi_tables()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:10PM +0200, Daniel Kiper wrote: > ..which collects system tables data. We want to re-use this > code to support multiboot2 protocol on EFI platforms. > > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk > --- > v2 - suggestions/fixes: >- improve c

Re: [Xen-devel] [PATCH v2 16/23] efi: split out efi_variables()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:11PM +0200, Daniel Kiper wrote: > ..which collects variable store parameters. We want to re-use this > code to support multiboot2 protocol on EFI platforms. > > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk > --- > v2 - suggestions/fixes: >- im

Re: [Xen-devel] [PATCH v2 17/23] efi: split out efi_set_gop_mode()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:12PM +0200, Daniel Kiper wrote: > ..which sets chosen GOP mode. We want to re-use this > code to support multiboot2 protocol on EFI platforms. > > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk > --- > v2 - suggestions/fixes: >- improve commit m

Re: [Xen-devel] [PATCH v2 18/23] efi: split out efi_exit_boot()

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:13PM +0200, Daniel Kiper wrote: > ..which gets memory map and calls ExitBootServices(). We want to re-use this > code to support multiboot2 protocol on EFI platforms. > > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk > --- > v2 - suggestions/fixes:

Re: [Xen-devel] [PATCH v2 19/23] x86/efi: create new early memory allocator

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:14PM +0200, Daniel Kiper wrote: > There is a problem with place_string() which is used as early memory > allocator. It gets memory chunks starting from start symbol and > going down. Sadly this does not work when Xen is loaded using multiboot2 > protocol because start

Re: [Xen-devel] [PATCH v2 20/23] x86: add multiboot2 protocol support for EFI platforms

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:15PM +0200, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper > --- > v2 - suggestions/fixes: >- generate multiboot2 header using macros > (suggested by Jan Beulich), >- switch CPU to x86_32 mode before > jumping to 32-bit code > (suggested by A

Re: [Xen-devel] [PATCH v2 21/23] x86/boot: implement early command line parser in C

2015-08-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 20, 2015 at 04:29:16PM +0200, Daniel Kiper wrote: > Current early command line parser implementation in assembler > is very difficult to change to relocatable stuff using segment > registers. This requires a lot of changes in very weird and > fragile code. So, reimplement this functiona