[PATCH 2/2] second attempt to fix using grub device name as install device

2013-12-07 Thread Andrey Borzenkov
grub-install already resolved passed install device to grub device. So do the same as grub-setup and strip parenthesis if we get legacy (hdX). --- ChangeLog | 4 ++-- util/grub-install.c | 6 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog inde

[PATCH 1/2] revert 69ca97c820, it broke using OS device name as install device

2013-12-07 Thread Andrey Borzenkov
grub-install already performs install device to grub device mapping (it needs it to compare install and /boot devices), so after this patch SETUP got called with grub device and tried to perform mapping again. --- ChangeLog | 5 + util/grub-setup.c | 41 +++

Re: [PATCH 2/2] second attempt to fix using grub device name as install device

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 07.12.2013 09:44, Andrey Borzenkov wrote: > + install_device[grub_strlen (install_device) - 1] = '\0'; > + install_drive = xstrdup (install_device + 1); > + install_device[grub_strlen (install_device) - 1] = ')'; > +} Bad code. You forgot that grub_strlen changes with y

Re: [PATCH 2/2] second attempt to fix using grub device name as install device

2013-12-07 Thread Andrey Borzenkov
В Sat, 07 Dec 2013 09:47:44 +0100 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 07.12.2013 09:44, Andrey Borzenkov wrote: > > + install_device[grub_strlen (install_device) - 1] = '\0'; > > + install_drive = xstrdup (install_device + 1); > > + install_device[grub_strlen (install_de

Re: [PATCH 2/2] second attempt to fix using grub device name as install device

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 07.12.2013 10:40, Andrey Borzenkov wrote: > В Sat, 07 Dec 2013 09:47:44 +0100 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >> On 07.12.2013 09:44, Andrey Borzenkov wrote: >>> + install_device[grub_strlen (install_device) - 1] = '\0'; >>> + install_drive = xstrdup (install_device +

Re: [Xen-devel] pvgrub2 is merged

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 06.12.2013 16:22, Fabio Fantoni wrote: > Il 06/12/2013 15:55, Vladimir 'φ-coder/phcoder' Serbinenko ha scritto: >> On 06.12.2013 15:44, Fabio Fantoni wrote: >>> Il 06/12/2013 12:32, Vladimir 'φ-coder/phcoder' Serbinenko ha scritto: On 06.12.2013 12:11, Fabio Fantoni wrote: > Il 03/12/20

[PATCH 2/2 v2] second attempt to fix using grub device name as install device

2013-12-07 Thread Andrey Borzenkov
grub-install already resolved passed install device to grub device. So do the same as grub-setup and strip parenthesis if we get legacy (hdX). --- ChangeLog | 4 ++-- util/grub-install.c | 8 +++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog i

[PATCH] fix partition module names when /boot is on diskfilter

2013-12-07 Thread Andrey Borzenkov
/usr/local/grub2/sbin/grub-install: info: grub-mkimage --directory '/usr/local/grub2/lib/grub/i386-pc' --prefix '(mduuid/e6d1dcf06cea72140bafae74a8677f36)/grub' --output '/boot/grub/i386-pc/core.img' --format 'i386-pc' --compression 'auto' 'ext2' 'msdos' 'msdos' 'diskfilter' 'mdraid1x' 'biosdi

Re: [PATCH] fix partition module names when /boot is on diskfilter

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Go ahead. On 07.12.2013 11:46, Andrey Borzenkov wrote: > /usr/local/grub2/sbin/grub-install: info: grub-mkimage --directory > '/usr/local/grub2/lib/grub/i386-pc' --prefix > '(mduuid/e6d1dcf06cea72140bafae74a8677f36)/grub' --output > '/boot/grub/i386-pc/core.img' --format 'i386-pc' --compression

[PATCH, RFC] Allow running with non-terminated boot services in multiboot2

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Patch to spec and GRUB attached. @ xen: don't forget to put wlan card to sleep when you finish boot services diff --git a/doc/multiboot.texi b/doc/multiboot.texi index a8f45e3..d251a51 100644 --- a/doc/multiboot.texi +++ b/doc/multiboot.texi @@ -602,6 +602,21 @@ u32 | size = 8 | If

Re: [PATCH v0] Require human interaction to go to normal shell if grub.cfg has a problem

2013-12-07 Thread Andrey Borzenkov
В Mon, 2 Dec 2013 12:49:03 -0800 Jonathan McCune пишет: > On Mon, Dec 2, 2013 at 12:38 PM, Andrey Borzenkov wrote: > > > > > I still do not quite understand how rebooting can fix the problem. The > > only case it may happen is when you have intermittent network issues > > where grub fails to rea

[PATCH] improve formatting and content of target list in grub-probe help

2013-12-07 Thread Andrey Borzenkov
The number of targets in grub-probe became too large to fit in one line. Change display to match this of grub-mkimage. Additionally sort the target list to make it easier to read. Table driven target list also makes sure new targets are always included in help output automatically. --- util/grub

[PATCH] sort target list in grub-mkimage help output to make it easier to read

2013-12-07 Thread Andrey Borzenkov
--- util/mkimage.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/util/mkimage.c b/util/mkimage.c index ad12f8a..94f7edb 100644 --- a/util/mkimage.c +++ b/util/mkimage.c @@ -959,21 +959,27 @@ grub_util_get_target_name (const struct grub_install_image_target_desc

Behaviour if GRUB_ENABLE_CRYPTODISK is unset?

2013-12-07 Thread Colin Watson
I'm carrying this old patch in Debian at the moment, which predates the addition of LUKS support to GRUB: Index: b/util/grub-mkconfig_lib.in === --- a/util/grub-mkconfig_lib.in +++ b/util/grub-mkconfig_lib.in @@ -130,6 +130,15 @@

Re: Behaviour if GRUB_ENABLE_CRYPTODISK is unset?

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 07.12.2013 14:27, Colin Watson wrote: > I've never totally understood why GRUB_ENABLE_CRYPTODISK is optional to > begin with; it seems like a bit of a "do you want things to work? [y/N]" > option to me. My preferred approach would be to delete the option. Cryptodisk support is allowed to ask u

Re: [PATCH 2/2 v2] second attempt to fix using grub device name as install device

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 07.12.2013 11:19, Andrey Borzenkov wrote: > grub-install already resolved passed install device to grub device. So do the > same as grub-setup and strip parenthesis if we get legacy (hdX). > Did you test it with both syntaxes? > --- > ChangeLog | 4 ++-- > util/grub-install.c | 8 +++

Re: Behaviour if GRUB_ENABLE_CRYPTODISK is unset?

2013-12-07 Thread Andrey Borzenkov
В Sat, 7 Dec 2013 13:27:26 + Colin Watson пишет: > I'm carrying this old patch in Debian at the moment, which predates the > addition of LUKS support to GRUB: > > Index: b/util/grub-mkconfig_lib.in > === > --- a/util/grub-mkconf

Re: [PATCH 2/2 v2] second attempt to fix using grub device name as install device

2013-12-07 Thread Andrey Borzenkov
В Sat, 07 Dec 2013 14:50:09 +0100 Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 07.12.2013 11:19, Andrey Borzenkov wrote: > > grub-install already resolved passed install device to grub device. So do > > the > > same as grub-setup and strip parenthesis if we get legacy (hdX). > > > Did you

Re: Behaviour if GRUB_ENABLE_CRYPTODISK is unset?

2013-12-07 Thread Colin Watson
On Sat, Dec 07, 2013 at 02:49:45PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 07.12.2013 14:27, Colin Watson wrote: > > I've never totally understood why GRUB_ENABLE_CRYPTODISK is optional to > > begin with; it seems like a bit of a "do you want things to work? [y/N]" > > option to m

Re: [PATCH 2/2 v2] second attempt to fix using grub device name as install device

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 07.12.2013 14:59, Andrey Borzenkov wrote: > В Sat, 07 Dec 2013 14:50:09 +0100 > Vladimir 'φ-coder/phcoder' Serbinenko пишет: > >> On 07.12.2013 11:19, Andrey Borzenkov wrote: >>> grub-install already resolved passed install device to grub device. So do >>> the >>> same as grub-setup and strip

Re: [RFT] LUA build system adjustments

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 29.11.2013 07:54, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Current LUA status for non-x86 is pretty horrible. Attached is a patch > which fixes some of issues. Could someone test it? Testing on x86 should > be enough. > Could someone propose a test for LUA which could be run as part of > a

Re: Restrictive file permissions

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 05.12.2013 19:10, Colin Watson wrote: > I learned from a conversation on IRC today that GRUB has started to set > restrictive file permissions in a few places since 2.00. Notably: > > grub-core/osdep/unix/hostdisk.c:184: return open (os_dev, flags, S_IRUSR | > S_IWUSR); > grub-core/osdep/bsd

Re: [PATCH] use light-gray as default color in normal.mod for consistency

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Go ahead On 29.11.2013 09:10, Andrey Borzenkov wrote: > As we are in clean up stage ... annoyed me for quite some time. > > Defalut font color on PC console seems to be light-gray; this is > what user also gets in rescue prompt and what is defined as > GRUB_TERM_DEFAULT_NORMAL_COLOR. But normal.mo

[PATCH] fix timeout handling with GRUB_HIDDEN_TIMEOUT=0

2013-12-07 Thread Andrey Borzenkov
Before 44d488477902f0786d6bce44b74713f1713a34a9 combination of GRUB_HIDDEN_TIMEOUT=0 and GRUB_TIMEOUT!=0 resulted in normal menu with timeout. Now due to GRUB_HIDDEN_TIMEOUT taking precedence, it will always set timeout to 0 and immediately load default entry. To ensure that update does not break

[PATCH] document config_directory and config_file variables

2013-12-07 Thread Andrey Borzenkov
--- docs/grub.texi | 16 1 file changed, 16 insertions(+) diff --git a/docs/grub.texi b/docs/grub.texi index 6144740..e41c8db 100644 --- a/docs/grub.texi +++ b/docs/grub.texi @@ -3038,6 +3038,8 @@ These variables have special meaning to GRUB. * cmdpath:: * color_highlight:: *

[PATCH] trivial fix for config_file without directory part

2013-12-07 Thread Andrey Borzenkov
It is legal to use "configfile " where filename does not contain directory part. In this case config_directory is set to filename. Set it to empty string so $config_directory/file works as expected. May be it makes sense to generate full pathname (including device part) so that interpretation of $

Re: [PATCH] trivial fix for config_file without directory part

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 07.12.2013 20:51, Andrey Borzenkov wrote: > It is legal to use "configfile " where filename does > not contain directory part. In this case config_directory is set to filename. > Set it to empty string so $config_directory/file works as expected. > The only filenames valid in GRUB are of forms:

Re: [PATCH] trivial fix for config_file without directory part

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 07.12.2013 20:51, Andrey Borzenkov wrote: > May be it makes sense to generate full pathname (including device part) > so that interpretation of $config_directory does not depend on possible > change of $root. Adding ($root) to config_file/config_directory if none present would be good. signat

Re: Behaviour if GRUB_ENABLE_CRYPTODISK is unset?

2013-12-07 Thread Chris Murphy
On Dec 7, 2013, at 7:00 AM, Colin Watson wrote: > On Sat, Dec 07, 2013 at 02:49:45PM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >> On 07.12.2013 14:27, Colin Watson wrote: >>> I've never totally understood why GRUB_ENABLE_CRYPTODISK is optional to >>> begin with; it seems like a bit

Re: Behaviour if GRUB_ENABLE_CRYPTODISK is unset?

2013-12-07 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 08.12.2013 00:42, Chris Murphy wrote: > > On Dec 7, 2013, at 7:00 AM, Colin Watson wrote: > >> On Sat, Dec 07, 2013 at 02:49:45PM +0100, Vladimir 'φ-coder/phcoder' >> Serbinenko wrote: >>> On 07.12.2013 14:27, Colin Watson wrote: I've never totally understood why GRUB_ENABLE_CRYPTODISK