Re: [PATCH 2/2] grub-efi: allow compilation without large model support

2013-11-22 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 22.11.2013 11:00, jackie.hu...@windriver.com wrote: > +Upstream-Status: Inappropriate [compatibility] Should be backport as I'm about to commit my patch upstream once I've finished xen part and some documentation pertaining to introduced limits (2GiB) signature.asc Description: OpenPGP digita

Re: grub2 boot root-on-zfs errors

2013-11-22 Thread Colin Watson
On Fri, Nov 22, 2013 at 08:30:14AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 22.11.2013 08:09, Beeblebrox wrote: > > grub-core/osdep/unix/platform.c:34:28: error: use of undeclared > > identifier 'PATH_MAX' > > char *ret = xmalloc (2 * PATH_MAX); > Please try > diff --git a/grub-c

Re: grub2 boot root-on-zfs errors

2013-11-22 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 22.11.2013 14:16, Colin Watson wrote: > On Fri, Nov 22, 2013 at 08:30:14AM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: >> On 22.11.2013 08:09, Beeblebrox wrote: >>> grub-core/osdep/unix/platform.c:34:28: error: use of undeclared >>> identifier 'PATH_MAX' >>> char *ret = xmalloc (2 *

Re: [PATCH 2/2] grub-efi: allow compilation without large model support

2013-11-22 Thread jhuang0
On 11/22/2013 4:00 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 22.11.2013 08:23, jackie.hu...@windriver.com wrote: From: Jackie Huang -mcmodel=large is not supported by gcc with version lower than 4.4, but we don't need to use memory over 4GiB, so add a patch to allow compilation wit

Re: [PATCH 2/2] grub-efi: allow compilation without large model support

2013-11-22 Thread jhuang0
On 11/22/2013 6:06 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 22.11.2013 11:00, jackie.hu...@windriver.com wrote: +Upstream-Status: Inappropriate [compatibility] Should be backport as I'm about to commit my patch upstream once I've finished xen part and some documentation pertaining

Re: [PATCH 2/2] grub-efi: allow compilation without large model support

2013-11-22 Thread jhuang0
On 11/22/2013 4:13 PM, jhuang0 wrote: On 11/22/2013 4:00 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 22.11.2013 08:23, jackie.hu...@windriver.com wrote: From: Jackie Huang -mcmodel=large is not supported by gcc with version lower than 4.4, but we don't need to use memory over 4GiB

Re: grub2 boot root-on-zfs errors

2013-11-22 Thread Beeblebrox
config.log re-sent as link, as requested by mail list admin (file too large) https://drive.google.com/file/d/0Bxs_eepbMt6qejJBZVQyZngtdTA/edit?usp=sharing Regards. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/gr

Re: grub2 boot root-on-zfs errors

2013-11-22 Thread Beeblebrox
The patched file is giving me an error. I tried patching several times, but keep getting same error. Most likely some stupid error on my part: grub-core/osdep/unix/platform.c:43:4: error: expected expression FILE *fp = fdopen (fd, "r"); ^ grub-core/osdep/unix/platform.c:44:20: error: expected

grub2: Patch to correct hidden timeout behavior

2013-11-22 Thread Andreas Cadhalpun
Hi, I'm using Debian with grub version 2.00-20. My /etc/default/grub configuration contains the following lines: GRUB_TIMEOUT=-1 GRUB_HIDDEN_TIMEOUT=3 Expected behavior: When booting, grub should display a three second countdown and if no key is pressed, boot the default grub entry, after the

Re: grub2: Patch to correct hidden timeout behavior

2013-11-22 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 22.11.2013 21:34, Andreas Cadhalpun wrote: > Hi, > > I'm using Debian with grub version 2.00-20. > My /etc/default/grub configuration contains the following lines: > GRUB_TIMEOUT=-1 > GRUB_HIDDEN_TIMEOUT=3 > > Expected behavior: When booting, grub should display a three second > countdown and

Re: grub2 boot root-on-zfs errors

2013-11-22 Thread Vladimir 'φ-coder/phcoder' Serbinenko
> 40 pid = grub_util_exec_pipe ((const char * []){ "ofpathname", dev, > NULL }, &fd); > 41 if (!pid) > 42 Why did you remove the whole chunk of code here? Please use ptach command to apply patches, not some manual way. > 43 FILE *fp = fdopen (fd, "r"); > 44 get_ofpathname (const char *dev)

Re: [PATCH 2/2] grub-efi: allow compilation without large model support

2013-11-22 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 22.11.2013 08:23, jackie.hu...@windriver.com wrote: > From: Jackie Huang > > -mcmodel=large is not supported by gcc with version lower > than 4.4, but we don't need to use memory over 4GiB, so add > a patch to allow compilation without large model support. > Please try attached patch instead