Re: [PATCH] remove unused attribute from grub_biosdisk_iterate pull argument

2013-08-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 04.08.2013 14:19, Andrey Borzenkov wrote: It is not unused anymore. Go ahead Signed-off-by: Andrey Borzenkov --- grub-core/disk/i386/pc/biosdisk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/disk/i386/pc/biosdisk.c b/grub-core/disk/i386/pc/biosdisk.c

Re: GRUB2 on OpenBSD 5.3-amd64: linking problem

2013-08-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 13.08.2013 23:03, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 09.08.2013 15:37, Ilya Bakulin wrote: Could you please help me to solve the linking problem? What else do you need from me? Sounds like your gcc doesn't pass -m32 to linker. Try at configue stage set TARGET_LDFLAGS=-melf_i386

Re: GRUB2 on OpenBSD 5.3-amd64: linking problem

2013-08-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.08.2013 15:09, Ilya Bakulin wrote: So for proper compilation I_have_ to pass -ftrampolines in both CFLAGS and TARGET_CFLAGS. Please use latest bzr version. ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/g

Re: GRUB2 on OpenBSD 5.3-amd64: linking problem

2013-08-14 Thread Ilya Bakulin
On Wednesday 14 August 2013 10:59:24 Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 13.08.2013 23:03, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > On 09.08.2013 15:37, Ilya Bakulin wrote: > >> Could you please help me to solve the linking problem? > >> What else do you need from me? > > > >

Re: GRUB2 on OpenBSD 5.3-amd64: linking problem

2013-08-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.08.2013 15:09, Ilya Bakulin wrote: ./lib/posix_wrap/sys/types.h:25: error: conflicting types for 'size_t' /usr/include/stddef.h:48: error: previous declaration of 'size_t' was here gmake[3]: *** [fs/squash4_module-squash4.o] Error 1 You need to modify following: #ifndef __APPLE__ typedef g

Some questions about GRUB

2013-08-14 Thread Stojsavljevic, Zoran
Hello Vladimir, Again me... This time with more precise info. I managed to download GNU bazaar bzr and upgrade my Fedora 18 VM with this package. Then I executed the command: bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub And downloaded latest GRUB 5091 source code tree revision, as y

Re: GRUB2 on OpenBSD 5.3-amd64: linking problem

2013-08-14 Thread Grégoire Sutre
On 08/14/2013 03:31 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: On 14.08.2013 15:09, Ilya Bakulin wrote: ./lib/posix_wrap/sys/types.h:25: error: conflicting types for 'size_t' /usr/include/stddef.h:48: error: previous declaration of 'size_t' was here gmake[3]: *** [fs/squash4_module-squash4

[PATCH] Get proper mac address when using qemu

2013-08-14 Thread Paulo Flabiano Smorigo/Brazil/IBM
Hi all, This patch fixes an issue when net booting GRUB with QEMU. It was made by Avik Sil, a colleague from IBM. QEMU uses the local-mac-address property to store the mac address but it uses a 64bit property for it. This patch makes a proper treatment. To illustrate, this is the property

[PATCH] Send tftp ack packet before closing the socket

2013-08-14 Thread Paulo Flabiano Smorigo/Brazil/IBM
Hi all, This is another patch from Avik Sil. Bellow are the bug explanation: I found another grub bug in tftp transfer. The issue comes for a subtle corner case. While grub sends tftp acks, it maintains a 'count' variable that is incremented on each data packet received from tftp server. O

Re: Some questions about GRUB

2013-08-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.08.2013 15:38, Stojsavljevic, Zoran wrote: Hello Vladimir, Again me… This time with more precise info. I managed to download GNU bazaar bzr and upgrade my Fedora 18 VM with this package. Then I executed the command: bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub And downloaded

RE: Some questions about GRUB

2013-08-14 Thread Stojsavljevic, Zoran
Hello Vladimir, Could you, please, explain to me bit more how I can try with qemu? I am novice with GRUB, but lot of experience with Open Source. Zoran ___ Most of The Time you should be “intel inside” to be capable to think “out of the box”. -Original Message- I don't see anything

Re: Some questions about GRUB

2013-08-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.08.2013 16:14, Stojsavljevic, Zoran wrote: Hello Vladimir, Could you, please, explain to me bit more how I can try with qemu? I am novice with GRUB, but lot of experience with Open Source. There is qemu port of coreboot. I'd try with this. Zoran ___ Most of The Time you should be “

Re: GRUB2 on OpenBSD 5.3-amd64: linking problem

2013-08-14 Thread Ilya Bakulin
Hi, On Wednesday 14 August 2013 15:49:03 Grégoire Sutre wrote: > On 08/14/2013 03:31 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > You need to modify following: > > #ifndef __APPLE__ > > typedef grub_size_t size_t; > > #else > > #include > > #endif > > to > > #if !defined (__APPLE__) && !d

Re: [PATCH] fix parsing of LVM PV names for short names

2013-08-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Go ahead On 27.07.2013 12:09, Andrey Borzenkov wrote: Default format of vgs output is - two spaces as standard prefix - PV name left aligned to field width which is 10 characters This means that if PV name has less than 10 chacaters it has some spaces at the end. Example: linux-chxo:~ # vgs -

Re: [PATCH] fix memory and descriptor leaks in grub_util_is_imsm

2013-08-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Go ahead. On 19.07.2013 13:53, Andrey Borzenkov wrote: Descriptor leak caused warning from later vgs invocation. Fix memory leak (buffer was not always freed) while on it. Signed-off-by: Andrey Borzenkov --- util/getroot.c | 29 +++-- 1 file changed, 15 insertions(+)

Re: [PATCH] use vgs --nameprefixes to protect against whitespace changes

2013-08-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 19.07.2013 09:11, Andrey Borzenkov wrote: Do not assume single blank at the end of PV name. At least lvm2-2.02.98-24.3 (openSUSE 13.1 M3) puts exra blank at the end. linux-chxo:~ # grub2-probe -t abstraction /lib mdadm: cannot open /dev/md1 : No such file or directory grub2-probe: error: can

Re: GRUB2 on OpenBSD 5.3-amd64: linking problem

2013-08-14 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 14.08.2013 17:16, Ilya Bakulin wrote: If I move the "typedef mbstate .. mbstate_t" into '#if !defined(__OpenBSD__)', then the code uses the version from stddef.h, which lacks "code" and "count" fields. It is defined as follows: Try: #ifdef __OpenBSD__ #define mbstate_t grub_posix_mbstate_t #e