Re: [PATCH] multistring support in gui_label

2013-04-17 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 16.04.2013 11:04, Vladimir Testov wrote: >> Please don't use // comments. > O.k. I won't. >> This code completely forgets the cases >> when even the first word doesn't fit in the available space. > > Mmm. It can handle this case actually. > >> The code as whole breaks some unicode concepts li

Re: [PATCH] multistring support in gui_label

2013-04-17 Thread Vladimir Testov
On Wednesday, April 17, 2013 09:01:47 AM Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Don't write any line-breaking at all yourself. I did not write any line-breaking. It is existing line-breaking. And it have one algorithmic problem. Do not see any problem if I will fix the problem. The pro

Re: [PATCH] multistring support in gui_label

2013-04-17 Thread Vladimir Testov
On Wednesday, April 17, 2013 01:02:44 PM Vladimir Testov wrote: > Suggested patch to fix this problem (second one) is attached. Nope, it won't help. I'll think again... -- With best regards, ___ Vladimir Testov, ROSA Laboratory. www.rosalab.ru

Re: [PATCH] multistring support in gui_label

2013-04-17 Thread Vladimir Testov
On Wednesday, April 17, 2013 01:02:44 PM Vladimir Testov wrote: > O.k. Here it is. > > from grub-core/font/font.c line 1387 function blit_comb : > >do_blit (combining_glyphs[i], > > > >main_glyph->device_width > > > >

Re: [PATCH] multistring support in gui_label

2013-04-17 Thread Vladimir 'φ-coder/phcoder' Serbinenko
> Looks like I've misunderstood something... Sorry. Can't see where the problem > is... > blit_comb has dry run mode and it's what's used to get constructed length. signature.asc Description: OpenPGP digital signature ___ Grub-devel mailing list Gr

Still unable to build from tardist due to libgcrypt (and probably more) POTFILES

2013-04-17 Thread Andrey Borzenkov
I do not quite understand how po/POTFILES are maintained but they refer to files that are not distributed, so rebuild later fails. [ 270s] TARGET_OBJ2ELF= sh genmod.sh moddep.lst gcry_whirlpool.module gcry_whirlpool.mod [ 270s] make[3]: Leaving directory `/home/abuild/rpmbuild/BUILD/grub-2.00/