Re: [PATCH] multistring support in gui_label

2013-04-16 Thread Vladimir Testov
>Please don't use // comments. O.k. I won't. >This code completely forgets the cases >when even the first word doesn't fit in the available space. Mmm. It can handle this case actually. >The code as whole breaks some unicode concepts like e.g. bidi stack. Didn't get what you mean. >Could you re

Re: [PATCH] multistring support in gui_label

2013-04-16 Thread Andrey Borzenkov
В Tue, 16 Apr 2013 13:04:28 +0400 Vladimir Testov пишет: > >Please don't use // comments. > O.k. I won't. > >This code completely forgets the cases > >when even the first word doesn't fit in the available space. > > Mmm. It can handle this case actually. > > >The code as whole breaks some unico

[PATCH] really limit size of efidisk transfer to 0x500

2013-04-16 Thread Andrey Borzenkov
Rev 4859 failed to actually limit transfer size. Signed-off-by: Andrey Borzenkov --- ChangeLog| 4 grub-core/disk/efi/efidisk.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 6f33ff1..77a0819 100644 --- a/ChangeLog +++

Re: [PATCH] fix autogen.sh on "dirty" tree

2013-04-16 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 10.04.2013 18:45, Andrey Borzenkov wrote: > В Tue, 9 Apr 2013 20:20:26 +0400 > Andrey Borzenkov пишет: > >> for x in mpi-asm-defs.h mpih-add1.c mpih-sub1.c mpih-mul1.c mpih-mul2.c >> mpih-mul3.c mpih-lshift.c mpih-rshift.c; do >> -if [ -f grub-core/lib/libgcrypt-grub/mpi/"$x" ]; then >

make failure in grub-core/gnulib in trunk

2013-04-16 Thread Andrey Borzenkov
It fails immediately. bor@opensuse:~/build/grub> LC_MESSAGES=C make bison -d -p grub_script_yy -b grub_script ./grub-core/script/parser.y flex -o grub_script.yy.c --header-file=grub_script.yy.h ./grub-core/script/yylex.l gcc -E -DHAVE_CONFIG_H -I. -Wall -W -I./include -DGRUB_UTIL=1 -DGRUB_LIB

Re: [PATCH] multistring support in gui_label

2013-04-16 Thread Vladimir Testov
On Tuesday, April 16, 2013 09:10:23 PM Andrey Borzenkov wrote: > > +/* Differs from grub_font_draw_line only in multiline output */ > > You mean grub_font_draw_string? Is it possible to extend this function > instead of duplicating it? Hmmm... I'll think through it. Would it be wise? The sets of