Re: [PATCH 2/7] Initial support for ARMv7 architecture

2013-04-01 Thread Francesco Lavra
On 04/01/2013 03:28 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> +grub_err_t >> +reloc_thm_call (grub_uint16_t *target, Elf32_Addr sym_addr) >> +{ >> + grub_int32_t offset, offset_low, offset_high; >> + grub_uint32_t sign, j1, j2, is_blx; >> + grub_uint32_t insword, insmask; >> + >> + /*

Re: [PATCH 4/7] Support for ARM/U-Boot platforms

2013-04-01 Thread Francesco Lavra
On 04/01/2013 04:15 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Which architecture is raspberry pie? I have one here and it would be > good if I could use it for testing. It's ARMv6, so unfortunately it's not supported by this port, which works only on ARMv7. > >> +#define GRUB_KERNEL_MAC

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-01 Thread Francesco Lavra
On 04/01/2013 04:31 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> +static grub_uint64_t > >> +grub_efi_get_time_ms(void) >> +{ >> + grub_efi_time_t now; >> + grub_uint64_t retval; >> + grub_efi_status_t status; >> + >> + status = efi_call_2 (grub_efi_system_table->runtime_services->get_t

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-01 Thread Vladimir 'φ-coder/phcoder' Serbinenko
> > How would you handle such a case? I guess a machine which can't provide > this runtime service would need some more work in its EFI firmware > before being ready for GRUB, so perhaps this is a moot point. > If no timing is available, you'd need at least return a count of calls to the get_tim

Re: [PATCH 4/7] Support for ARM/U-Boot platforms

2013-04-01 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 01.04.2013 11:53, Francesco Lavra wrote: > On 04/01/2013 04:15 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> > Which architecture is raspberry pie? I have one here and it would be >> > good if I could use it for testing. > It's ARMv6, so unfortunately it's not supported by this port, whic

Re: [PATCH] Add DragonFly BSD disklabel64 support

2013-04-01 Thread Radosław Szymczyszyn
2013/4/1 Vladimir 'φ-coder/phcoder' Serbinenko > On 26.03.2013 15:44, Radosław Szymczyszyn wrote: > > > + if (! (dpart.boffset && dpart.bsize)) > > + continue; > > Why do you exclude partitions starting at 0? > Sorry, my mistake. The contract says that "an uninitialized partition has a

Re: [PATCH] Add DragonFly BSD disklabel64 support

2013-04-01 Thread Radosław Szymczyszyn
2013/4/1 Radosław Szymczyszyn > 2013/4/1 Vladimir 'φ-coder/phcoder' Serbinenko > >> On 26.03.2013 15:44, Radosław Szymczyszyn wrote: >> >> > + if (! (dpart.boffset && dpart.bsize)) >> > + continue; >> >> Why do you exclude partitions starting at 0? >> > > Sorry, my mistake. The contract

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-01 Thread Francesco Lavra
On 04/01/2013 01:23 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > get_time is wrong function for getting tsc. You should create a timer > event with 1 units (=1 ms) and in its callback increase millisecond > counter. The problem is that such timer event would be machine-specific and would

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-01 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 01.04.2013 16:10, Francesco Lavra wrote: > On 04/01/2013 01:23 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> get_time is wrong function for getting tsc. You should create a timer >> event with 1 units (=1 ms) and in its callback increase millisecond >> counter. > > The problem is tha

Re: [PATCH 4/7] Support for ARM/U-Boot platforms

2013-04-01 Thread Francesco Lavra
On 04/01/2013 01:24 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 01.04.2013 11:53, Francesco Lavra wrote: > >> On 04/01/2013 04:15 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Which architecture is raspberry pie? I have one here and it would be good if I could use it for tes

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-01 Thread Francesco Lavra
On 04/01/2013 04:16 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 01.04.2013 16:10, Francesco Lavra wrote: > >> On 04/01/2013 01:23 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>> get_time is wrong function for getting tsc. You should create a timer >>> event with 1 units (=1 ms)

Re: [PATCH 6/7] add ARM Linux loader

2013-04-01 Thread Francesco Lavra
On 03/24/2013 06:01 PM, Leif Lindholm wrote: > === added directory 'grub-core/loader/arm' > === added file 'grub-core/loader/arm/linux.c' > --- grub-core/loader/arm/linux.c 1970-01-01 00:00:00 + > +++ grub-core/loader/arm/linux.c 2013-03-24 13:49:04 + > @@ -0,0 +1,405 @@ > +/* lin

Re: [PATCH 7/7] Add support for ARM UEFI ("EFI") platforms

2013-04-01 Thread Francesco Lavra
On 03/24/2013 06:01 PM, Leif Lindholm wrote: > === added file 'grub-core/kern/arm/efi/misc.c' > --- grub-core/kern/arm/efi/misc.c 1970-01-01 00:00:00 + > +++ grub-core/kern/arm/efi/misc.c 2013-03-24 15:43:19 + [...] > +void * > +grub_efi_allocate_loader_memory (grub_uint32_t min_off

Re: [PATCH 5/7] add imported "FDT" module for flattened device tree operations

2013-04-01 Thread Francesco Lavra
On 04/01/2013 04:16 AM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > Could you put the library itself into a separate tar rather than patch? I recall you saying a few months ago that you'd prefer rather without libfdt. In fact, libfdt contains much more than what is needed by GRUB. I rewrote the

Re: [PATCH] Add missing ARM relocation codes and fix existing ones

2013-04-01 Thread Francesco Lavra
On 03/17/2013 09:36 PM, Francesco Lavra wrote: > I'm working on the GRUB port to ARM using the EFI platform. When > generating a relocatable ARM image, some relocation entries use a > relocation code (0x33) which is not defined in include/grub/elf.h. So I > went through the latest edition of the EL