Re: EHCI driver

2012-05-31 Thread Christer Weinigel
On 2012-05-30 14:35, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>/* Now should be possible to power-up and enumerate ports etc. */ >> @@ -926,6 +931,12 @@ grub_ehci_setup_qh (grub_ehci_qh_t qh, >> grub_usb_transfer_t transfer) >> & GRUB_EHCI_DEVPORT_MASK; >>ep_cap |= (transfer->de

EHCI: don't stop after finding the first controller

2012-05-31 Thread Christer Weinigel
Hi, Modern Intel chipsets have multiple EHCI controllers but the EHCI code will only detect the first one. I noticed this because on a test laptop all external USB ports are connected to the second EHCI controller so none of them would show up in grub. The reason is that the PCI code will stop i

Re: EHCI: don't stop after finding the first controller

2012-05-31 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Please update to latest bzr. Something similar was applied quite some time ago. On 31.05.2012 10:46, Christer Weinigel wrote: > Hi, > > Modern Intel chipsets have multiple EHCI controllers but the EHCI code > will only detect the first one. I noticed this because on a test > laptop all external

Re: Standalone Application in GRUB

2012-05-31 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 31.05.2012 08:44, Parul Aggarwal wrote: > Hello, > > I have a standalone application which I want to run in GRUB environment > i.e. for e.g at GRUB prompt. So the flow would be I enter grub prompt > and from there run my standalone application binary. By adding multiboot > header to the binary

Re: Standalone Application in GRUB

2012-05-31 Thread Parul Aggarwal
Thanks Vladimir. 1. In uboot we can have standalone application (which uses uboot functions) compiled and run independently on uboot prompt. As I understand from your comments that in GRUB this is not possible. We wanted to run the application in a way similar to memtest in GRUB. But our applicati

Re: Standalone Application in GRUB

2012-05-31 Thread Vladimir 'φ-coder/phcoder' Serbinenko
On 31.05.2012 12:03, Parul Aggarwal wrote: > Thanks Vladimir. > > 1. In uboot we can have standalone application (which uses uboot > functions) compiled and run independently on uboot prompt. As I > understand from your comments that in GRUB this is not possible. We > wanted to run the applicatio

Re: EHCI: don't stop after finding the first controller

2012-05-31 Thread Christer Weinigel
On 2012-05-31 10:46, Christer Weinigel wrote: > diff --git a/grub-core/bus/usb/ehci.c b/grub-core/bus/usb/ehci.c > index d8ecf26..240c0d5 100644 > --- a/grub-core/bus/usb/ehci.c > +++ b/grub-core/bus/usb/ehci.c > @@ -839,7 +839,7 @@ grub_ehci_pci_iter (grub_pci_device_t dev, >grub_dprintf ("eh

[PATCH] correct definition of GRUB_EHCI_MULT_ONE, TWO and THREE

2012-05-31 Thread Christer Weinigel
I might as well submit this "obviously correct" patch also and save the big EHCI patch for later. This patch was made against the latest version in the trunk on bzr.savannah.gnu.org. /Christer GRUB_EHCI_MULT_ONE, TWO and THREE should be 1, 2 and 3 but were all zero. Use the correct values ins

Re: EHCI driver

2012-05-31 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Thanks, I've committed the patch with just style changes. On 30.05.2012 14:12, Christer Weinigel wrote: > On 2012-05-30 11:28, Christer Weinigel wrote: > >> [talk about EHCI problems with low speed split transactions] > >> Now I just have to fix up the queue management so that it properly keeps

[PATCH] fix off-by-one in grub_file_getline

2012-05-31 Thread Christer Weinigel
I'd like to submit a few trivial patches that I've had on my hard drive for a while. This patch is against the latest version in the trunk on bzr.savannah.gnu.org. If grub_file_getline tries to read a line which is exactly 64 bytes long it will write the terminating zero past the end of the alloc

Re: [PATCH] fix off-by-one in grub_file_getline

2012-05-31 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Committed, thanks. Could you supply ChangeLog entry next time? On 31.05.2012 13:43, Christer Weinigel wrote: > I'd like to submit a few trivial patches that I've had on my hard > drive for a while. This patch is against the latest version in the > trunk on bzr.savannah.gnu.org. > > If grub_file_