On gratuitous modularization

2010-01-25 Thread Robert Millan
Please be careful when adding modules. I see that too often new modules are added without any real need to host this code separately. There are many examples where this happened. I just noticed: commands/hdparm.c: struct grub_disk_ata_pass_through_parms apt; commands/hdparm.c: if (grub_disk_

Re: Changes in GRUB help

2010-01-25 Thread Robert Millan
On Sun, Jan 24, 2010 at 11:15:11PM +0530, KESHAV P.R. wrote: > * Add support for Fedora's initramfs (semi-patch attached) - name like > initramfs-2.6.31.9-174.fc12.x86_64.img . Your patch looks like it ought to work; have you tested it? > Please document grub-extras in grub.enbug.org website. Y

Re: [PATCH] nested partitions

2010-01-25 Thread Grégoire Sutre
Robert Millan wrote: With this approach, the burden is no longer in GRUB. Then I don't care how weird disk layouts can become, because GRUB doesn't have to probe them. We can even support things like this if it makes users happy: (hd0,bsd2,msdos1,sun1,apple4,msdos1) I like this generic ap

Re: [PATCH] Multiboot video support

2010-01-25 Thread Michal Suchanek
2010/1/25 Robert Millan : > On Mon, Jan 25, 2010 at 12:29:41AM +0100, Michal Suchanek wrote: >> 2010/1/24 Vladimir 'φ-coder/phcoder' Serbinenko : >> > There is a big difference between orientation and the rest of fields: >> > orientation is configuration variable whereas other fields are a >> > har

[PATCH] Fix use of ENABLE_NLS (which is not always defined)

2010-01-25 Thread Grégoire Sutre
Hi, This message concerns both gnulib and grub. As discussed on irc and on the list [1], ENABLE_NLS is not used correctly, which leads to a build failure when gettext is not detected (or with configure option --disable-nls). ENABLE_NLS is defined in AM_GNU_GETTEXT and the documentation of t

Re: [PATCH] make 'sleep --interruptible 0' interruptible

2010-01-25 Thread Colin Watson
On Mon, Jan 25, 2010 at 08:55:33AM +0100, Robert Millan wrote: > On Wed, Jan 20, 2010 at 10:50:25PM +0100, Szymon Janc wrote: > > Colin Watson wrote: > > > On the PC architecture, you can't check for Escape without having some > > > kind of delay. Only modifier keys can be checked instantaneously.

Re: [PATCH] [RESEND] GRUB script lexer rewrite using flex

2010-01-25 Thread BVK Chaitanya
On Mon, Jan 25, 2010 at 1:27 PM, Robert Millan wrote: > On Sat, Jan 23, 2010 at 10:39:47AM +0530, BVK Chaitanya wrote: >> Attached is the updated patch with changes as per review comments (by >> phcoder).  With these changes sh.mod file size is reduced from 38K to >> 28K :-) > > Very nice!  But I

Re: [PATCH] Fix use of ENABLE_NLS (which is not always defined)

2010-01-25 Thread Yves Blusseau
Le 25/01/2010 10:53, Grégoire Sutre a écrit : ENABLE_NLS is defined in AM_GNU_GETTEXT and the documentation of this macro [2] does not require ENABLE_NLS to be defined when gettext is not available. However, uses of ENABLE_NLS assume it to be defined, which is not correct. Seems good for me,

Re: Changes in GRUB help

2010-01-25 Thread KESHAV P.R.
> > Date: Mon, 25 Jan 2010 09:08:45 +0100 > From: Robert Millan > Subject: Re: Changes in GRUB help > To: The development of GNU GRUB > Message-ID: <20100125080845.gi13...@thorin> > Content-Type: text/plain; charset=us-ascii > > On Sun, Jan 24, 2010 at 11:15:11PM +0530, KESHAV P.R. wrote: > > * A

[PATCH] DM-RAID probing

2010-01-25 Thread Colin Watson
I've pushed this branch with improved DM-RAID probing support: sftp://bzr.sv.gnu.org/srv/bzr/grub/branches/dmraid-probe/ This makes it possible for things like this to work: grub-probe --target=partmap --device ... which in turn makes it possible for grub-install to work when /boot/grub is

Re: Changes in GRUB help

2010-01-25 Thread richardvo...@gmail.com
On Mon, Jan 25, 2010 at 7:22 AM, KESHAV P.R. wrote: >> Date: Mon, 25 Jan 2010 09:08:45 +0100 >> From: Robert Millan >> Subject: Re: Changes in GRUB help >> To: The development of GNU GRUB >> Message-ID: <20100125080845.gi13...@thorin> >> Content-Type: text/plain; charset=us-ascii >> >> On Sun, J

Re: Changes in GRUB help

2010-01-25 Thread Colin Watson
On Mon, Jan 25, 2010 at 03:12:51PM -0600, richardvo...@gmail.com wrote: > On Mon, Jan 25, 2010 at 7:22 AM, KESHAV P.R. wrote: > > Yes, the patch definitely works. It is part of Fedora's GRUB2 src-rpm > > package. But I changed the 10_linux.in file manually before compiling grub2. > > The strange t

Re: On gratuitous modularization

2010-01-25 Thread Christian Franke
Hi Robert, Robert Millan wrote: Please be careful when adding modules. I see that too often new modules are added without any real need to host this code separately. There are many examples where this happened. I just noticed: commands/hdparm.c: struct grub_disk_ata_pass_through_parms apt;

Re: comment about grub_error, capitalisation and one commit

2010-01-25 Thread Carles Pina i Estany
Hi, On Jan/24/2010, Robert Millan wrote: > On Wed, Jan 20, 2010 at 11:37:38PM +, Carles Pina i Estany wrote: > > a) if someone has a better idea to avoid this mistake again than paying > > attention I can implement. > > b) Robert: I reverse it, fine? > > I just removed capitalization of erro

macrofy fontcontants

2010-01-25 Thread Carles Pina i Estany
Hello, Find attached a way to macrofy the constants from font files between util and grub kernel. Comments, name changes, etc. are welcomed. -- Carles Pina i Estany http://pinux.info === modified file 'ChangeLog' --- ChangeLog 2010-01-25 17:04:22 + +++ ChangeLog 2010-01-25 23:03:56

Multiboot's boot_device field specification + implementation bug

2010-01-25 Thread Grégoire Sutre
Hi, I'm trying to understand the specification of the multiboot boot_device field. How should this information be interpreted by a kernel that uses a native (non-DOS) disk label? For instance, if the MBI passed to the NetBSD kernel says part1=5 and part2=part3=0xFF, does this mean: - 6th p

Re: Changes in GRUB help

2010-01-25 Thread richardvo...@gmail.com
On Mon, Jan 25, 2010 at 3:22 PM, Colin Watson wrote: > On Mon, Jan 25, 2010 at 03:12:51PM -0600, richardvo...@gmail.com wrote: >> On Mon, Jan 25, 2010 at 7:22 AM, KESHAV P.R. wrote: >> > Yes, the patch definitely works. It is part of Fedora's GRUB2 src-rpm >> > package. But I changed the 10_linux

Re: [PATCH] [RESEND] While and until loops support to GRUB script

2010-01-25 Thread BVK Chaitanya
Hi, Attached patch implements while and until loops support to GRUB script. Its been pushed into branches/while-until-loops as well. Let me know your comments. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: bvk.gro...@gmail.com-20100126040951-4jx21vvs3as5bp6u

Re: [PATCH] [RESEND] For loop support to GRUB script

2010-01-25 Thread BVK Chaitanya
Pushed into branches/for-loop -- bvk.chaitanya ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel

Re: macrofy fontcontants

2010-01-25 Thread Evgeny Kolesnikov
On Mon, 2010-01-25 at 23:07 +, Carles Pina i Estany wrote: > Find attached a way to macrofy the constants from font files between > util and grub kernel. > > Comments, name changes, etc. are welcomed. Can you please consider my patch for anti-aliased fonts in your scheme. It's in the way to

Re: [PATCH] [RESEND] While and until loops support to GRUB script

2010-01-25 Thread BVK Chaitanya
Adding a testcase for while and until loops caught several GRUB script bugs in handling return value ($?). Attached patch has these issues fixed along with the testcase. Its been pushed into branches/while-until-loops as well. -- bvk.chaitanya # Bazaar merge directive format 2 (Bazaar 0.90) #